mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: brking@us.ibm.com, jejb@linux.vnet.ibm.com,
	martin.petersen@oracle.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org
Subject: [BUG] drivers/scsi/ipr: two possible sleep-in-atomic bugs
Date: Tue, 12 Dec 2017 11:00:39 +0800	[thread overview]
Message-ID: <0e9454f8-4419-ae82-470e-53edb7e7342b@gmail.com> (raw)

According to drivers/scsi/ipr.c, the kernel module may sleep under a 
spinlock.
The function call paths are:
ipr_shutdown (acquire the spinlock)
   irq_poll_disable
     msleep --> may sleep

ipr_ata_post_internal (acquire the spinlock)
   ipr_device_reset
     ipr_send_blocking_cmd
       wait_for_completion --> may sleep (&hrrq->_lock is still held)

I do not find a good way to fix them, so I only report.
These possible bugs are found by my static analysis tool (DSAC) and 
checked by my code review.


Thanks,
Jia-Ju Bai

                 reply	other threads:[~2017-12-12  3:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e9454f8-4419-ae82-470e-53edb7e7342b@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=brking@us.ibm.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®