From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757444AbcIONta (ORCPT ); Thu, 15 Sep 2016 09:49:30 -0400 Received: from mail-co1nam03on0052.outbound.protection.outlook.com ([104.47.40.52]:32662 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752297AbcIONtV (ORCPT ); Thu, 15 Sep 2016 09:49:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up To: Baoyou Xie , , , , , , , , References: <1473947006-28038-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <0e95ce24-45af-e244-2ff2-7afc2c1f8501@amd.com> Date: Thu, 15 Sep 2016 15:49:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473947006-28038-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:5036:9c7:9152:f15b] X-ClientProxiedBy: AM2PR09CA0052.eurprd09.prod.outlook.com (10.160.228.148) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: d0dd5e51-1f7a-4bf3-90ff-08d3dd6f1720 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:SZbY9oDVp16XwoOeThQFb/9EqYa2lb7Kp6u8gKOn3+5Aox52yus1pktPRsxw2BjqYGLaxx4c2ns/u5VF/+Ly2fOgmWsyuqLBq2RfV/a/1UJ/eBzgBYtdO/QEhGaA28Dy7RMQ9sU5rCsd4t+5iguZNnEreDHNvbtdktSjz4LPmO63HrVzm3iyUPu8VU5RJH59;3:Ku+uZKVIMof5w9to7zcXO7WUMbsgZamliSb1wIcj72YToiiwSq6zt0zjcOtayUz1xkWXBErICaW0QdFxybfiJ2kPrrR5k7x2lHrerL5zgI8IvZx+ous33olmc0wawqTD;25:2v70IEMV3bQTGrhoqsLL2JbFsCzTaQ96D4lce3XVYzYPemqOERITZW+wQdAjdbMhBL8qdxfhugp46dbWFw3Q5fVhXDfSkj1FynWaNW3xg5ok2pXPcrZthFEN/d2idFajz1+WnkYLKnsXbe+MytQdZ2oY6RvYdo2NHYTEFPKi7i7RfodzSIN6xIhtnztIaGaY/RdMXEgRSGzmXqyNknuLrg6KwNvddkTz12NvrSfyIl/Fida6SPfokM1EL2p2YBXRDJg6jX2eGaCi4mrau8877iyiJeuRKrApX0JOuEv9u8B6kPLDzvHBQiuL+ejT4kDSU6rsrXkik2q78rEGD7SEQHYCmczozcFtzO7PAD1lIqKo/vLQ8YDV76EoCltL/YJUr9+Y5glntVs7kcbddshwlbXh7qQUvaISy2rwZhOlxlA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:Gc4Zhgk3/B4CBF43nyHXz1nEIh0iw5rlpHDYQm3vgvf1dgbhGZyPLUBPbGwiCWAFLOiopW8mPCh2WV229fTo1bYtpVqFzrEvFeRuRDM8+YuUw4gKzjheTOouiKnp10C0ani7vKfmbO0yYCSR0qP0tMd3BmIuzTKnL6bfjo/se7oWtNvY2lFPqY0zQSfCwt982YuFssEK6zYm7JEs1XuX1o17c+vz5RKff6ANC/zmR3w=;20:KzW73DNN1zNdSNkRQgoEMIs/YaY+q06BerIAcaIJiqJd+LxBxBS0l+npu1F6zZh/XrZ7V9dzFvOvLTM7cIuDGnWF82wadDgOvlQ2Pywk8TL+aB1hoi/HsUhg8z6eWkJ6sQ7p+OhOdde85om7ujuz4vuRCJnQj59H6YJz6pYM+NRrbHvOeEqV39vgLgY0cI3UizmbHxMLoCGOyJTMaDDBq/A915v3b3zaKZk2Squ3AbQhA6qVE2KSUi7e5gdchNN14S6XMUUT4bg+R/vNkWXm0PrsUhJgqd7B4wDx1NR8WxlParLWJeidL/wo9f3bxQMt14YO7IkdEVLG9FssI88F4yrS+yXBt01p+F670tHYegayvWlxqpx8ehnPNgwVwNTXKmnXUmPwe97kZkJKIOHTVGN7UwpL1zGlf2K1l6w4LZSoKptG/Nt50erLhSpl+dPf3SuzS94SUuzydyKkdqTMLz4Iv9ksjTD9OUT285N0RXBlKyW9sTOtjNkSbaUxCWPO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:8hBQU/Z1yTNl2AydI/m62mH9nSYODSDgCA8GDbcW4Vwt4TxQtmrTlOYMwXQTDB7IG7mrIMgeS+rt3DWt4dK73XnAKR0VBozudy3sZKSWwLB5NVJ71RDIwu/rW8TQK2txFEVFM/DsLKahMzKnAeFPw3GLRqOfCYY3IMdGaa/GEBLBvFRrVpJDfWGc8PLgM1ylmuJhBX+zu7+qCo5S7r+73Kt6fhZpfgFbVymaVfQLez3RUOZ4f7reEKv4e8QU3cH6dOL5XAy9Wilzx24LOAigEVg0MIX8oUjtOat4I1diEDiFkBpJg95A+wwRmRcSaPqfi0s55YxR35cKJ8/SIkLMApdPh0bWgGC6948szlIXZIsF2Y+Loobe4PLFtXUmFPFaYymVrQDcw0vAGPwmITb1JkAUfKezQO3A4bpthlTSDsMPoTW6tw7oFiejBBpsobjQ X-Forefront-PRVS: 0066D63CE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(65806001)(1706002)(305945005)(83506001)(586003)(36756003)(6116002)(31696002)(7736002)(2906002)(65826007)(189998001)(101416001)(68736007)(92566002)(4001350100001)(4326007)(5001770100001)(86362001)(106356001)(5660300001)(97736004)(2870700001)(2201001)(64126003)(19580405001)(77096005)(7846002)(54356999)(23756003)(76176999)(50986999)(65956001)(2950100001)(47776003)(42186005)(8676002)(105586002)(50466002)(33646002)(19580395003)(81166006)(31686004)(81156014)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:5036:9c7:9152:f15b];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BN6PR12MB1298;23:fPOmQR7IF1VqUsqTNDD3NTNZ6qIqnurj0ECnLQ?= =?iso-8859-15?Q?u+gDCP/73edT9XVTJlDuaYdvoeaxq/b1/Ug2TeXdKhG8pETCSCw29TuTe?= =?iso-8859-15?Q?JZYnFgqSvy0MC2wAKPHTHWn98LWghAEB5u3wVOX0dAhrp287fNjwpY81p?= =?iso-8859-15?Q?xgyqbk2kHxGMjQCYOByulEDcnllXBRjMLmEFODJlXV0/SUr6kUtiEiKpT?= =?iso-8859-15?Q?7MOylTIr/JHNaYUTQv+P5ay64EN0oq5ubckAztC4IKF3tUrza/DZItJ8D?= =?iso-8859-15?Q?TcMQ4i40EPhGRspdrrStbpOMKS+SLxB2YFR1xkPO1cHMbqLMwd4atc1Hb?= =?iso-8859-15?Q?z5JSOVCcKGUgkDH09pjA1OYfEj//2FDzwX32Kg6xgz0ffXs/zUZibmVBz?= =?iso-8859-15?Q?74W3nQQ+rZ0gth3OqHFGzP3MVziwDyUTrJ6/TPj+nhs630BINmGwCxeNH?= =?iso-8859-15?Q?dXsSGqqxl3FxGh+ns/S5hm4JyE5UFAbMNpLARzKFWe3Ja1NA3zdZfwSPQ?= =?iso-8859-15?Q?L0NukbwR3o8c1DXDppnI8qcJRUwphKYkKPZcPEKnnByxt5ZjGKZWMApIq?= =?iso-8859-15?Q?ksd0WfiI/bvtJmS+0tVUmrId4xeFh0U2KEH7XjzO5kROIPmne3zt/SpUQ?= =?iso-8859-15?Q?Qm4IwrS4fa48veOBBqK7ataA3EK/Q/qgSrluUaWd3UAO2TrWVeDv7UmAr?= =?iso-8859-15?Q?SC+eXaUQcLcSfvylqZ+9e8euOV0gN9NFtvKl1vCPju5jeYWr5E3QPGFOO?= =?iso-8859-15?Q?d1wIptZsU/BAf/DS7ZhrXgLf1nY768NByjtVGGgkcynqxtl1w6hkTo2ds?= =?iso-8859-15?Q?mirIUahY3V6iI/+u5nGFXffkIEEK4/9/7zmguqhwjIcDMOslgVpQJXdlK?= =?iso-8859-15?Q?QVXViD4ZQ6Esq3aPNRdhcqfTMslW7mIiHAqt5i1qp9kFHyuJsl45+yaqe?= =?iso-8859-15?Q?qvwxwVtNdioMFVfuvevB+4nBQftOy4UwcnEI3knlNXw+iW7k5Zsc9Msnx?= =?iso-8859-15?Q?wj2A9IZ3SNesSuom3cbBz2Y1F8Dlym5bWjd/MxDYu/EwjGWggCzIFutUP?= =?iso-8859-15?Q?Kn0S52l/pMkLG+x9KDK1vEa8CXj1X/khqRajjfjrIBxlOmRN7/NI9lc3q?= =?iso-8859-15?Q?OZhPle3mOT27u3ZxkRNUTBeufgdjvytf8lFHK6M4j6Mb9cx9YaF64WHTJ?= =?iso-8859-15?Q?1McVXw2lwuNUKwQbnnZJMz+Vx7t4BxImimYyUS7tL+XbA4vNsGx/ibYq7?= =?iso-8859-15?Q?qPCOPK+jOx6OdJCfRw513DrMD0VXhe/kVBA/gVZC8ExHsg4mduKb8ITJb?= =?iso-8859-15?Q?G+Lhuae17hdcaaQZjN1LKKUr+LiCfKupynw/kIiYcSfvZ?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:yZcnVKt1HFXV/CR+A0B8SaRyVgOc2sr04tVB7h418vaMrBpXDBuIIdkRJ85efI3Wo08mrYNm0TwoBXPeCsjHCTG0B/vZfqcrhkoRv567pvz/naKbETy6ESqXOsulea0Hn8Lg2facgHzMhSOYJJl5JC2F0+lGq4kqvTvHgwNvxgHDlNKqWkcj7QbgstQnaw95ude2A9kOnY+Hf4nIPQyrZM/WqzZSD/ricogAW8oc0dCkx/1On8jvb87WEUSwD9hYbzs6DFFPkxkfHzc/KbnMsdwNt1wOeOb1DPKQWxnpupJtDss7daFarDvq2of8BPXSdKT//QEj2OrVXykwbY/rvQ==;5:rmPzDP03lIhttmQ0hBcx82eELmvQA9rpcUKb8MLcy0FAEuiQcUM6/9IDmaCimUpZou/mC9yYJcluqiTGkTCKdQdeTSB1o+/yZh4y8kLdfmqJd4RvvrGmtHM+6f2jNhxaYnvTi4NP9LpHvsj2q1AiLQ==;24:iojO3WVDsWQ2wwffOhT5+BHZ3K/mvyB6PPnudCOvzvkWEndVBHwQO9HejrAvLhF/FYs0nhJQYFgHm+gEy0pSqDiDZmhn0Jd579oPjV1k1w4=;7:hoZ227CXwFm7me8WdPL5qJADG/3RKcRXJlV1dqzjoQSbEUD8x1M6H/IXAbzcHAOZsVUY0UN+j8l3uTiQS37s4S2Rwi/L2iMh03inXv9YuTzxYoNOqHvoE249d+O6lzVNw/9WM2fPtNdKV3o/VN8/OKT9Z8GO6FNdZXV2kNDgc9eJq2VgQ+H8bgATkq+0BLMvwbcPZCLl7JrP4T1qhzF6arr3wERwMR9hwwU8YgOZu91ApVQ31E+kCbj8MNcWcx7p SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:yyRnbggXnnQox/RiCK+QoDYb5oY3mSjZPhGOSsYfJonbpImCgzUN3I2lWjKbjWm69/EFW0NiwtwAxM4B66RgBQ6w+kAmb31WCT/y3t318YHTGnkFieyxsC6oXCdfNrz2mBkI2dFLbGnpvMlntmqaPiNoBk4+vd8MVB5cz1zV5kB7Q6/u5TAKq+Id2VCMi51TgmDXa3tn08UTwgurg/zFETYvPcSTYnA3rclWYigDUtrco+kL8K0hJsOVRRggrUC2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 13:49:17.1445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.09.2016 um 15:43 schrieb Baoyou Xie: > We get 2 warnings when building kernel with W=1: > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:985:5: warning: no previous prototype for 'amdgpu_ttm_init' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1092:6: warning: no previous prototype for 'amdgpu_ttm_fini' [-Wmissing-prototypes] > > In fact, both functions are declared in > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, but should be declared in > a header file, thus can be recognized in other file. > > So this patch moves the declarations into > drivers/gpu/drm/amd/amdgpu/amdgpu.h. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index a7bb862..3208608 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -2402,6 +2402,8 @@ void amdgpu_gtt_location(struct amdgpu_device *adev, struct amdgpu_mc *mc); > void amdgpu_ttm_set_active_vram_size(struct amdgpu_device *adev, u64 size); > u64 amdgpu_ttm_get_gtt_mem_size(struct amdgpu_device *adev); > int amdgpu_ttm_global_init(struct amdgpu_device *adev); > +int amdgpu_ttm_init(struct amdgpu_device *adev); > +void amdgpu_ttm_fini(struct amdgpu_device *adev); > void amdgpu_program_register_sequence(struct amdgpu_device *adev, > const u32 *registers, > const u32 array_size); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index b17734e..30f05d8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -38,8 +38,6 @@ > #include "amdgpu_trace.h" > > > -int amdgpu_ttm_init(struct amdgpu_device *adev); > -void amdgpu_ttm_fini(struct amdgpu_device *adev); > > static u64 amdgpu_get_vis_part_size(struct amdgpu_device *adev, > struct ttm_mem_reg *mem)