From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: madera: Drop GPIO includes
Date: Fri, 4 Jan 2019 13:29:28 +0000 [thread overview]
Message-ID: <0e99200a-7a4f-17e7-aec6-a84dfed268ea@opensource.cirrus.com> (raw)
In-Reply-To: <20190103102623.29685-1-linus.walleij@linaro.org>
On 03/01/19 10:26, Linus Walleij wrote:
> This irqchip does not use anything GPIO-related so drop
> the GPIO includes.
>
An older version did some stuff with GPIOs but when that code was removed
this include obviously was forgotten.
> Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/irqchip/irq-madera.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-madera.c b/drivers/irqchip/irq-madera.c
> index e9256dee1a45..8b81271c823c 100644
> --- a/drivers/irqchip/irq-madera.c
> +++ b/drivers/irqchip/irq-madera.c
> @@ -7,7 +7,6 @@
> */
>
> #include <linux/module.h>
> -#include <linux/gpio.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/irqdomain.h>
> @@ -16,7 +15,6 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/irqchip/irq-madera.h>
> #include <linux/mfd/madera/core.h>
>
Acked-by: Richard Fitzgerald <rf@opensource.cirrus.com>
prev parent reply other threads:[~2019-01-04 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 10:26 Linus Walleij
2019-01-04 13:29 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e99200a-7a4f-17e7-aec6-a84dfed268ea@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®