From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B9A34CFC6 for ; Tue, 16 Dec 2025 14:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895571; cv=none; b=Bw8RvuHM6yMsjSOQlM1nIuAnONh7Fgx87mVidIaTIm6J7FSXtP3LV/CcFdllQpovx5CG30n9I3ft/qy6rxGPP1hhGK4e8O+yO0oRD0E/I9nJDmZBiZR/uPhRx8AT67e2ZJ6z8isoNMR7t3c4ha7h15XWtkvuQtDxue92TmK5Q00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895571; c=relaxed/simple; bh=LQFNapVMCQ/JalvfgYjYQfiqmX6OJbnFjF63HzBCz58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZVOz8xJZJ/UUmG5XtcjX0WNVKo5OL1etBRwyj9b2RRlDeIZvUifsRawMHQp6Wp5auzKmHZT+1UrH/nzkx9jNdOEYIleCoKNf2F/fNn3EoB0Oau70HSJI+D7bVOLx9vigS5XE+GQbxZPlA58jlyIUX+p9iahSgrC3iGT1WQ+1x9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l52Ekt3/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RQpJS5lV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l52Ekt3/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RQpJS5lV" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BGC7Cne3708516 for ; Tue, 16 Dec 2025 14:32:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sSSMICGICe2f0YIccl2tqHqDQh0xExPvbuAKbmzyLo4=; b=l52Ekt3/3tztiqwG gVwiPPv7VlpREtpqvlh+JR4YQIKRXVgsl88qyfDFPt12ZTOjlfN5AA9jXn1Iq6kt UnlEGkX5kemeL+qfmIY+CzLK+ZE/zCZAXTIuOO7IsLnhJjZdzciHhcw2GaMcdfdS x48nkxLCX4zvGJJSEVk8Mw6wnQ1UQiRpzNGIZrn5zzU5EwzwH8W59EGWehMlzvv9 6U/Qk4IdbXbdQdJqzIYM+FONRucm04VVmDXNa1ac05LWk/38iB7KZjMUdd1TwsdE vxkW16kHscGUYs5HMVlKxdoJe8nnmHBzGyNvxosPwSUCEJUH9lypLw09kziVWvas pSOhlw== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b375b0hqv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Dec 2025 14:32:48 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-93f57cdeb11so3014525241.0 for ; Tue, 16 Dec 2025 06:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765895568; x=1766500368; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sSSMICGICe2f0YIccl2tqHqDQh0xExPvbuAKbmzyLo4=; b=RQpJS5lV8i83cmun5YDgvjIDrsRG5B6jm9S2XFtwKxKWo2FLYiarLkxJ/ePrS44HoL cWY5ayrGBZGbSvehZmiFwm9G7gRTNADrPzjhchPJ8qzPAh9o+0ns47RO6ufgjYR9cHA1 gUMQcWyeE1mHxGRVgLE+BWMFXwGxSRV1NwRRQIEID+P3STSEUv0lZLEUylPKLFuO3sLW W3OWwZfwRVPIOYSuMi9brhJoiLU8LnQXRRECATJWxVyL+Rb8A6/MCd3oYQesaIu3yma4 8pSuXl2DHfH6kcVvzylz47ucyfZAQIaEbmalVF2roc4rCBBlBp4NxfQqhmAqOsacA/dr pg6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765895568; x=1766500368; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sSSMICGICe2f0YIccl2tqHqDQh0xExPvbuAKbmzyLo4=; b=ecdNeJoT9I99wOQB9WENg2NVUMzj1lazFJfH97vHLq3KD1TPS18kT38sx7FL0/zoLx 93+0CCOIIrp0VKQ2I1ysi2f5mnEg/J8Bmi1HK8T9HjwdVRr7TwQqWA82CebBLFTJKAlV 23NGdF8m2g2mayUif2nK5IUWU9YCUUUyV6MacsLfgZB5T3ePvf2EGqTldAC7LvZeaNmZ FJRQqXp4CeTHyEkgwIcNG+nt08UYAdxCG2pdjGaaC32iZLdToVgFkXs7lYqx5v0GqUXT fFyHQVgcq17frsODr5xMV/y+JZgb9KKyIP/RoescC/hwO2vDwru1pmHqCYFHL9+UknU4 kO9Q== X-Forwarded-Encrypted: i=1; AJvYcCVgE7hUR1Alk6AplZtPqKB7B2kFNr0Zbj2f/8nPTMfrk+BHy0LpkPItaSxbK/hSSlzl0OqR7p1E7NnDHD8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUo2fwavQAFuO9LbGQoci5tFjs4O27CLsFSJiTaE3H7RPwgpuv rebAHNs8jBQYd3d9owieKaSewbIg5VfU98gHLiJnZHmsBlPjppteKqqLtGLle/5i0dI1QIC1qz4 OKsM00rH1N3HEepM9V2fXjly4oxvEwvJDKvKHmKwbhcEKqgSa2mQYX+B2WsSmPikaBTU= X-Gm-Gg: AY/fxX5DlMcgv2n9FTFfxQz7XURmgogDaDxh/5jwXch6jNTv5nAMqkkSTm9wM7k/s1Y rphTmvnHS4s+uRk7Sj8IbM9ROCXkLJVwljLUVPY4v7r2ZpX1j/lZ72NxVGIH9LJO/e+Vf7rAR1H l05RWfgIgUvxHuqdFZfBbc+ym32Elhk0mgMvPqq+FXJ66N1Rok3SDO7O4drlOMbRAXnR2WSs68d on0Cg/7oi+ipY3pODpTY/HefkmwdqWX9wTnZ01yLVtvJzU4FJEWCdFz5lW6YSyA8dROd90ZWxPI J1zpmLjewB19LqR6ZYuB/TO031Iny5Yl3xWo2wJVRUTndzLy9NgWkOTje2PwTJU5w597fEhdzcg kwpkrQDOMSBJnvIzbMKj+rupU9RnGOpTWPxxQQXnenD10Mylq4BRgZ0gfC1PleUYY9uMn X-Received: by 2002:a05:6102:4487:b0:5db:f615:1819 with SMTP id ada2fe7eead31-5e827488c7fmr4127729137.3.1765895567485; Tue, 16 Dec 2025 06:32:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5bvKhIUfXMFuxDOHV/Y5m3VNAwV/RECgvjwhUnC/dgoHjCv0Ee4gAMKdHTBXr7UcOFJElvA== X-Received: by 2002:a05:6102:4487:b0:5db:f615:1819 with SMTP id ada2fe7eead31-5e827488c7fmr4127698137.3.1765895566843; Tue, 16 Dec 2025 06:32:46 -0800 (PST) Received: from [10.193.196.209] (82-128-196-119.bb.dnainternet.fi. [82.128.196.119]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5990da1a7d8sm954688e87.37.2025.12.16.06.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 06:32:46 -0800 (PST) Message-ID: <0e9c0f8d-c1f6-4c84-b467-37e11837882e@oss.qualcomm.com> Date: Tue, 16 Dec 2025 16:32:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dp: Enable support for eDP v1.4+ link rates table To: Dale Whinham Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= , Steev Klimaszewski References: <20251214-drm-msm-edp14-v1-1-45de8c168cec@gmail.com> <2c1656ff-cba9-4122-a414-d22958f5857b@gmail.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <2c1656ff-cba9-4122-a414-d22958f5857b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE2MDEyNCBTYWx0ZWRfX7Z0brR/euBwp EVMxdGfK9T/nprZfWlIx31u3kd9Z+4H/fJcFp/m3OWTGSMlMHWAXJLFHd2rzc3c5A0BFXgST0GS hPD/OdcmFtObg0RS23fHZg7L/QRDvARnUdmyJvCmJKCpZr6c/1hIsLvb7knrcAfhLDMmOmrQYdU FFADnTOVE8iNnB/KcUpdW3fhhNa5DJoAp2OyA1jWfiTaOZxhSFjuS3+4H3Gt/+5bYtU73AZH3nM 2JqNywGGsFjg3gRnve8jlItVlQ5CrJv9me33pKD1hbP+eao63dqKNItAhQZLEdFcF3Mr+KrMLvX MdSh7p3b1UlUNwwGihvjMJg6KWT5Hw0MJpbbQdBZfLL3uAl+43zlGOMhRHP+R0VNw/QoZZrJn6K G29sDFTIWAMUmLr6G8m9D1jb45uNgg== X-Proofpoint-GUID: Kd2WuwMAwpHIc4sqFQHyEEnzJKhV6TAz X-Proofpoint-ORIG-GUID: Kd2WuwMAwpHIc4sqFQHyEEnzJKhV6TAz X-Authority-Analysis: v=2.4 cv=T9qBjvKQ c=1 sm=1 tr=0 ts=69416d90 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=UP4AmmvVc3sGQHJQO2VA4Q==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8z4_Mw9kuIkUejV11uIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-16_02,2025-12-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512160124 On 16/12/2025 16:31, Dale Whinham wrote: > On 15/12/2025 22:15, Dmitry Baryshkov wrote: >> I'd suggest following i915 and writing DP_LANE_COUNT_SET before >> DP_LINK_BW_SET. > > Thank you - made this change for v2. > >>> +    /* For eDP v1.4+, parse the SUPPORTED_LINK_RATES table */ >>> +    if (link_info->revision >= DP_DPCD_REV_14) { >> >> No, eDP has separate versioning register. DP revision != eDP revision. > > You're absolutely right, this was a mistake. > Does something like this seem reasonable for v2? Yes. > >     if (msm_dp_panel->dpcd[DP_EDP_CONFIGURATION_CAP]) { >         u8 edp_rev; > >         rc = drm_dp_dpcd_read_byte(panel->aux, DP_EDP_DPCD_REV, &edp_rev); >         if (rc) >             return rc; > >         if (edp_rev >= DP_EDP_14) { >             // parse the rates >             // ... >         } >     } -- With best wishes Dmitry