From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B067230BF1; Wed, 2 Apr 2025 11:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743593283; cv=none; b=rOS9USFTM4EmvvthhKa0cea5QJF+C1jW2Xhal+OuDF4A7O3g3uUmd5tPn9irVFWgQtntcHjCnUzuxVD0sM8yi0QhtdksLgdbvvcYablihoOiFrdneoIOdE0xs8iK+J9xwBnxlBrBRuv9zNC5Sy5JyHlyokOGbXclH3GnleFnpcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743593283; c=relaxed/simple; bh=Ln2iIqBwDcrHbRPLNI+ZBsnlsDpxFaob7450jwaXdC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OEp3XHiocG3sE8pIVjxvkSR8QlzWrGmmtbQgR7TTrF+SjzGHav6D7Ginv4YvzMN/G/7wYXFEvLYwKdTWWYEe6xgBFhi58rzofRBheMQBy7NvTaZ1IlfKmXUpGsOQPwI9HUfKYp9I7400G1eI0z+ZTMNKc6HIcEa6QQWUehnHiuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=nFwfoGRU; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nFwfoGRU" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 422CD6A2; Wed, 2 Apr 2025 13:26:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743593167; bh=Ln2iIqBwDcrHbRPLNI+ZBsnlsDpxFaob7450jwaXdC8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nFwfoGRUibxpoTVTH03GR/2nFcvgFNtU8O2boyKa7Y+Tb6vfP1UFZ7i2gxDu9c8PT 3mmJs/k+zldhO+fskHpcvYTB1U0QPyJjbxfxw8mVApq4k6YgdMkk1FeSeBEe2uuOjX H/oe/WKBrrL0VARKtHYbnJelZop+rVwiBZ+w+b0s= Message-ID: <0e9cef43-0f15-497c-9781-d31e5cd0adb7@ideasonboard.com> Date: Wed, 2 Apr 2025 14:27:57 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] media: i2c: ds90ub960: Enable second i2c interface To: Yemike Abhilash Chandra Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, vaishnav.a@ti.com, u-kumar1@ti.com, r-donadkar@ti.com, mchehab@kernel.org References: <20250305121705.2143540-1-y-abhilashchandra@ti.com> <9032362c-a332-4b44-8c77-386edb1f09f7@ideasonboard.com> <8b377d15-1fe3-42fb-b220-09f4e667f7da@ti.com> Content-Language: en-US From: Tomi Valkeinen Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <8b377d15-1fe3-42fb-b220-09f4e667f7da@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 20/03/2025 12:36, Yemike Abhilash Chandra wrote: > Hi Tomi > > On 18/03/25 20:16, Tomi Valkeinen wrote: >> Hi, >> >> On 05/03/2025 14:17, Yemike Abhilash Chandra wrote: >>> The DS90UB960-Q1 includes a second I2C interface for independent control >>> of the deserializer and remote devices. However, the current driver does >>> not utilize it, thus restricting users to either CSI TX0 or CSI TX1 on >>> the primary I2C interface. Enable the second I2C interface, allowing >>> flexible routing where CSI TX0 can be used on the primary and CSI TX1 on >>> the secondary, or vice versa by enabling appropriate ports in DT. To >>> achieve the same only modify the bits relevant to the enabled RX and TX >>> ports of that interface and during probe and enable_streams call, few >>> registers were being reset to HW reset state, these operations are not >>> necessary for functionality and resets the state when secondary I2C >>> interface is probed, thus drop them. >> >> I'm a bit confused about the description. My recollection is that both >> CSI TX0 and TX1 can be programmed just fine from the first I2C >> interface. Is that not so? >> > > I apologize for not giving the entire context while sending the RFC. > The purpose of this patch is not only to enable secondary I2C interface > but also to overcome the v4l2 framework limitation by doing that. > >> Also, even if the driver supports both CSI TXes, at the moment v4l2 >> framework doesn't work with it, at least in many cases. E.g. if you >> connect one TX to a CSIRX, the other TX to another CSIRX, and those >> CSIRXes are independent, have their own media graphs, it's not going >> to work at all. >> > > Lets say that the overlay applied is as shown in [1] > > [1]: https://gist.github.com/Yemike-Abhilash- > Chandra/5c53a5f3a77954b28c5bd4c27cd336a5 Ok. No, we can't merge anything like that. You're creating two linux devices for a single HW device, without any specific support for such. If it works for you, it's just by luck. Tomi