mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	Mahesh Rao <mahesh.rao@altera.com>,
	Richard Gong <richard.gong@intel.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Delete some stray tabs
Date: Tue, 9 Dec 2025 17:40:03 -0600	[thread overview]
Message-ID: <0e9fbd34-9916-455c-b6c0-816837033325@kernel.org> (raw)
In-Reply-To: <aSBqcEl5y5fqF72v@stanley.mountain>



On 11/21/25 07:34, Dan Carpenter wrote:
> These lines are indented one tab too far.  Delete the extra tabs
> for readability.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/firmware/stratix10-svc.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index b91f68d9ae98..59d9f588d9ee 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -1316,7 +1316,7 @@ int stratix10_svc_async_send(struct stratix10_svc_chan *chan, void *msg,
>   		dev_dbg(ctrl->dev,
>   			"Async message sent with transaction_id 0x%02x\n",
>   			handle->transaction_id);
> -			*handler = handle;
> +		*handler = handle;
>   		return 0;
>   	case INTEL_SIP_SMC_STATUS_BUSY:
>   		dev_warn(ctrl->dev, "Mailbox is busy, try after some time\n");
> @@ -1701,12 +1701,12 @@ int stratix10_svc_send(struct stratix10_svc_chan *chan, void *msg)
>   			kthread_run_on_cpu(svc_normal_to_secure_thread,
>   					   (void *)chan->ctrl,
>   					   cpu, "svc_smc_hvc_thread");
> -			if (IS_ERR(chan->ctrl->task)) {
> -				dev_err(chan->ctrl->dev,
> -					"failed to create svc_smc_hvc_thread\n");
> -				kfree(p_data);
> -				return -EINVAL;
> -			}
> +		if (IS_ERR(chan->ctrl->task)) {
> +			dev_err(chan->ctrl->dev,
> +				"failed to create svc_smc_hvc_thread\n");
> +			kfree(p_data);
> +			return -EINVAL;
> +		}
>   	}
>   
>   	pr_debug("%s: sent P-va=%p, P-com=%x, P-size=%u\n", __func__,

Applied!

Thanks,
Dinh


      reply	other threads:[~2025-12-09 23:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 13:34 Dan Carpenter
2025-12-09 23:40 ` Dinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e9fbd34-9916-455c-b6c0-816837033325@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahesh.rao@altera.com \
    --cc=richard.gong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®