From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7835C001DF for ; Thu, 3 Aug 2023 09:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234967AbjHCJIn (ORCPT ); Thu, 3 Aug 2023 05:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234964AbjHCJIk (ORCPT ); Thu, 3 Aug 2023 05:08:40 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ADDFE7 for ; Thu, 3 Aug 2023 02:08:37 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9ab1725bbso10936451fa.0 for ; Thu, 03 Aug 2023 02:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691053715; x=1691658515; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lL6o/KcStrptKgvvlzpf2g3HB3hx11T5k5Y/jU/1lFU=; b=NI9g2tBpu8/9zS0rwuwUWSv6MvnFoaUBwXr4sK9UTsHdyUvkrNMi8Ks+zt9da/jHrw Ve0Egy6UUcn+qghjFjUrSkehwu/8mQ/l4hqx5K/2v8hstX4/3f6tXBpKrxvjBzYJF9QT 8gW+4CGXpG9VKNUlEraiLHhlMgICDJ5q7HXZhc0e0gPz8n7pw8MUYtFNvpf4yoePmNS2 4fkDqmUXRbPTSqay4emxrXtCobrPsdHdje03JHfcam/P4/SPBEzf3BHz4jvV4wPmb9DG ULmjU6S25u2aY0lqaD8lJZxNL4oUvsNBF65lviF3YSY/OizSLCCaPgU5poFOrWTzxRxK 5KLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691053715; x=1691658515; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lL6o/KcStrptKgvvlzpf2g3HB3hx11T5k5Y/jU/1lFU=; b=X+SvrHn7xwwXunctHo4dqf4Df9ynvLIi8X2xaf88AuRsUnIw8RWx4o+3YBi+Cm051W RFqQy7UZR29CWYVirUiRAuTsHyHy1H1cd34HpJJ/IozhO5IwCKYN9zzHhx/0K5H0DR9r XeeSOf8mQ9ka0Fg+XsLffSGOlmeablkdBdYtBEV6W+CxAyVIXEq0Yf4q3U4jrYBl2PIX A3Es9AD5h4Nr7x8Be+vTjzsEhNpRIl5b9yKtY/Kd5uGMTgge2hVfOBCLBeOLPFDiwtHz 6Lq8JnUGcN4bznKRpobgTg0CeKSfJ2CSahxsFKwipnHjTks03SGz91I6mzJZV4jGFF7g iIZg== X-Gm-Message-State: ABy/qLZkphDDbl5b11IBfMsd1zl1qyYgqmYJ6YzVbwxssoaDsbFlWMpi onDRlf2ztNHuFTs/+1A50abQZA== X-Google-Smtp-Source: APBJJlHOqAV2i4Wnq0dOO1J5u/qsLMvUhNpr6WrZRCrVB983RluHKR4r4vNi+n6ZlpXBeA1dY0MN1A== X-Received: by 2002:a2e:98d0:0:b0:2b6:9ed0:46f4 with SMTP id s16-20020a2e98d0000000b002b69ed046f4mr7505851ljj.23.1691053715562; Thu, 03 Aug 2023 02:08:35 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n1-20020a05600c4f8100b003fe15ac0934sm13156770wmq.1.2023.08.03.02.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 02:08:34 -0700 (PDT) Date: Thu, 3 Aug 2023 12:08:32 +0300 From: Dan Carpenter To: Nick Desaulniers Cc: Su Hui , chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, trond.myklebust@hammerspace.com, anna@kernel.org, nathan@kernel.org, trix@redhat.com, bfields@fieldses.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] fs: lockd: avoid possible wrong NULL parameter Message-ID: <0ea832fa-de39-47fa-8666-5743a68a8519@kadam.mountain> References: <20230802080544.3239967-1-suhui@nfschina.com> <531df8ee-ba09-49df-8201-4221df5853c6@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I could have sworn there was an issue with glibc annotating these parameters as non-NULL, but maybe it was a different function. With the memcpy() bug in 2010, there were never any numbers to show that it helped improve performance. The only person who measured was Linus and it hurt performance on his laptop. So from a kernel developer perspective it just seemed totally bonkers. regards, dan carpenter