From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760919AbdAFUsL (ORCPT ); Fri, 6 Jan 2017 15:48:11 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44170 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752119AbdAFUr7 (ORCPT ); Fri, 6 Jan 2017 15:47:59 -0500 Subject: Re: [Regression 4.7-rc1] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl To: Joseph Salisbury , References: CC: , , , , , , <1619918@bugs.launchpad.net> From: Chris Mason Message-ID: <0ea8d8ad-b410-b81b-5732-b5d6beca1d10@fb.com> Date: Fri, 6 Jan 2017 15:46:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:180::bfcb] X-ClientProxiedBy: DM5PR21CA0053.namprd21.prod.outlook.com (10.175.112.143) To MWHPR15MB1246.namprd15.prod.outlook.com (10.175.3.8) X-MS-Office365-Filtering-Correlation-Id: b97589d8-d53d-4124-de5f-08d436752044 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1246; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;3:z4P69oLtpwlJP3fHebac0/jkWVy/AB8Ss6s0ufVxwjVNA0gVWNjAoLG9oed2zTSIVzlvMXtrHxgKqVZIsruonF+P9Xza3ynFF12+kfbGtAaPEIC/5Ltg8Pu2Z5J7huSAOv+xhDaK6BX9qKcmfPp5tu446mAitT+4xor6F5AMGR8whSBFSYU4paUMT/T242yvD3RhZssyEYZFg40ov/YO0/+0YWF8VNgwdGFFkFbyQEgyOnoeVTFDqk7hx3YL601YBPAhZ3jw4ik6n3XzGRGYug== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;25:kM69S18L0xw/OVkODqStQR3DgjGHcH4KxLUdQAgNhDiUPnI7U/mWRDvFDxritm4QY7CzAnjT/MIdQyjGZIuuVTuKD/4klljgFlIXoDIWveE3AaQbk3Iza9IwWkmfsnTJBcgrKMnDQ5GGf+oWUH4PL0qtrAzxgqAozK8zDOcPAuEPTSAdCV4ZJWlGw4xvX04kfCbv5CJaYstkPKzQpbCID6qSs4rcc2zn1wtEr9E80mRObiRooUOW2BwPef+Jq7ITWrZoSjKW+deTw77GQzP+jKiEMtJHxffTw1cF8wzMZLhjdXS66KAUXCHlWatENPZOvkqgD7lW33IfKgAh18GLB3w10hvCoAcEltThc+pMBSzNGCtuhVGcklYPaL0pqn2d5UQQHwebkJCMA9ObUmugK543xZo4hgtB8N/7gwiXn+szyVy4is4rcqEXzaPO8D/PZpPis2NCllCIMPPvnKmYGieIMdJRl/UHiT9bg8C11k4w77d4L+QHEx77+z9mrwKtmtoaLqg9o8LrCKxgxEMHLZJQR/tKamQtgtrvlH/ZPs1JEJucJCB3CBvFy0lT+5lIl21ckZOuqvwfgCnNTF1RiU0sbBHODm8x8YM4XXT0VVEdboi4GsZeLrKjtMP9OPkr2RMRJz8rxbhN8V63eglleUEMAHy9yeaRn50KVvoc+rYMfN2Q4AjekUn/VdXN/Xr/3G2yqv35SSZeBhy0OBiXEiD7dSuigfG7GEW9D6MriIc= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;31:cSxs/br1OE7KfhLFWiGwm2d/hLmYbK6jYowdY4ic8f1AZLRsFgpa/+SX8Mk4JuKyhVslZPC610/uVACnQLOaNrnh5+FYkTE0pAzBP5p/D3TIJ9ORHE2iX8iYgGWQgpqXaEzc2eBXpWKMQIekkV8xC3SIW2QKrdVEJEVnul7RWlvHfBETcWQrvpd5GZnRFbpjDF1P5UyNvFvoBDW8GSRKHUIbg0bercsEFcnTO2DOVU9sXuuevurUDg8WB6bVFJoq;20:unt0buDhlnfrC+ycYOPo92ETcSpJInRcY+KgpxgVNrd3S32nASWPNJewvyQUJjxTutyzPVrXlldt4sLDSWXf4m5h7ZbPDxVC3MiE+qs6Ov2mwDZOBihBxsj4NgVwv5k8T+b6f6nRvmvIXTmtx8HL7BflUrW67RAT8lER1kYC/OuPIXpnoXT0qkDfU9ZTg4//eYRo+9XEAmdgrXKeFL3+JICleU0CN2DIwLO3uHVzIk00WREzvSrGyFau6oqvhbRZKJmUBPvCzfJeOO5k2HYSn2YxEQ6k0CHmC6dS2qbo4/C/Sm+XXWc3dRWayUWIU7u6sI10t6MxXBWrErF78xDK/hAKLamkkA25IyHJ8x1cWYqYa8Z6SEyZYIjwjQomF4/JILl7J9EJ6uHrS1ZQlECeBK8S/Xqmdtvcrvn6O4r31ehHnobnVXAedtV/BhflBowzirVDmqpruUEk1hp2Crn2rW/IEQrFadDBcsrTq6AxA+wr80zYiYJ1cH+FLTy7R44b X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(20161123558021)(6072148);SRVR:MWHPR15MB1246;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1246; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;4:qPm4nhP3NYeukP7zHbEgqWyfEFBz76NBxCFBRNWQN42dFyg8LafsyJbX2ii0Wfzlb4YPxSVTTD3EDwn6OCgcW4dGRwsYyPQGwZn8pLTBBp/SJejGuSyZW0f9dXYIXMYWMb0WXATDkSKW8hu7Z0utsB6HhFuDe1j88RbN+UK+8lEHo1mCjj6VpqgehGNEmoLcROXDkiAYpiLEbbjeDht9Dmc/R/gwlhc78DFXSPprHpSWJQHZe8iUuCJMeOkLaJs35+3+q0u2CMqKeuVjg5V+TvluNNSQSV+6Vpu232LiE7b5ol/VJ09a48Y+yBiYgQCh8HaNS/t9Ww8261hD24+CTIX8y3mYIaRnnb5HhCXkvcsXeFcZHqdVFhrIUzG5fltWwgBuBE4gcHE2ux9d63LaGFEjo/gN3p86Seq34sbaQN4KXN/7+2ROIsFIhGsEhyuNq1qwzmgF0EJLXyPS8bexpum1Fe6KCDszGBiGPhepwmi8B3wlPPCAyBPU/eEp8vb10F85Dy9528uOfO+dEuK5n5SyFSIneAW4RweqdZue+IDC69wz9QQVX+nkv9vPOnQk1SCWLQSTywizig/qJE4p6jUcPUAEw9Ak0YZx30A6Uy8= X-Forefront-PRVS: 01792087B6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39830400002)(39410400002)(39450400003)(199003)(24454002)(189002)(377454003)(6116002)(38730400001)(36756003)(33646002)(5001770100001)(1706002)(92566002)(97736004)(6666003)(2906002)(4326007)(4001350100001)(6486002)(229853002)(83506001)(23676002)(101416001)(54906002)(86362001)(50466002)(2950100002)(64126003)(65806001)(65956001)(50986999)(106356001)(189998001)(31696002)(105586002)(42186005)(31686004)(81156014)(305945005)(8676002)(68736007)(7736002)(76176999)(65826007)(81166006)(230700001)(47776003)(5660300001)(54356999)(25786008)(142933001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1246;H:[IPv6:2620:10d:c0a1:1110::1074];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjE1TUIxMjQ2OzIzOkRVcUN2bXo2RTlyVWFtV1ltSXRobFNvcGtI?= =?utf-8?B?V3h5UjNDc29KdnNqb1NMcktnenM0UkMvZHRhRnpiVTZHSTQxbFN1MFB2SVlJ?= =?utf-8?B?TlFLVmdVRnJNaXpyWWlPMGxaYk1rZnZTMTVGQ3orSFZzZ3hmbzBYRUh3TEtq?= =?utf-8?B?SkRuR3lmWEVuYUlmUkY2dDhiMm1nUkIyRmQ3MFVEbUdjallTUGJHQ05qRDNE?= =?utf-8?B?cjl2ejJxRytyQ1JtdG15Q1VvL0lqVjAycHlrNEFVUmtURnVZK3EvRkk2Sldi?= =?utf-8?B?WjhWRWQrTU0zMzM1cTJEbGNyUHlMRUVSaytUTTNmSDlzd0RGR3ZvZ05tTDJ1?= =?utf-8?B?aTZ0LzJNQnJFVnAwTlZhSkx2ckIwY0s5bHh4UWRKZ3VMd3JOdzQ3blk5MFls?= =?utf-8?B?SVFpZkVUWlNMWVJlM0xTZzdlSFpiUllNRHNkQjZZZ3ZNemx3MExWTnh4dUdq?= =?utf-8?B?aWUrU3M4Uk9xMlo4RW9vL0F0UG11ZTZyOHc2dHd4ajFUK0grME8xVFlNL0NT?= =?utf-8?B?akltaFkydUZqZjRTMHZoSzFHdXFtY0JLL2FPWW9DMFRGc3FhMWZmZk9XNjlT?= =?utf-8?B?bjJBZkpWdUJrelczcjFuMDZCOVhjMmU5VW8yVlhHb243SGtzS1djOVIxUDhl?= =?utf-8?B?WHY3Z1lqNWlWaTNpUUljRXRaR0JmRlZUMkFxcm5sVm9sZmFONGpLY2QvbGNO?= =?utf-8?B?Lzc4RitMc0U5bUVBY0lrcCtzUW5leG1YVXhwRXdjbS94QmJRc0h1VzZYamYy?= =?utf-8?B?NFNRQ3NJVm40dm4zaDM2dFRNbXF1RHNDd3U0bkp2b0taa2pLMjh1RGljT1Qw?= =?utf-8?B?NmYyd2ZxM3FLTFRvUDhPbTRXRWlNZVlkT3ZQWmJyeVh4VVNCcFE4dFFHNVR1?= =?utf-8?B?VzE2c2dYWi81bnFWa0pud28zdHU1Mlh2bmZRODFuamZEaTVTeTZSbFVWSGps?= =?utf-8?B?OXlFZ0owaGtpZ21YYTNsaUtDa0F2eUI1bmxvWi8vVU83KzMxaGw3ZTloRGlX?= =?utf-8?B?d3NRSU1lNW9xdWVSRHgwcUVBMGRiMlVtdGQ4QmVDRTlFZ0dmczd5YjlhUG9T?= =?utf-8?B?ZnhBdzh1U2luWVlOalI4QWxQdGxDWWN1NVU4YTZiSmpNZnR3L3UzZjdScjNM?= =?utf-8?B?WjZaUTBpUzBjSDNlV2hIcXdnUlpKTUNiVHpXWFdQTy9GcFZQdm16NXNUdzlr?= =?utf-8?B?VithdE1uS1FYU1dBYjRiaTY1eUU4RlZ0M0d4bllaNDdWdWhRTUFHNHhVTHNt?= =?utf-8?B?U3ZOa2F4bUxtUjl6VGYzYmlkbUZpNkVLVXc1QWxOU3hCSk42UGN3TWUwK3hJ?= =?utf-8?B?TExKdTV1V29yRDIyLzNMN21ZM2ZkdXZXMVBrT3k3SEFGUnRNS0REMzcvRWxO?= =?utf-8?B?NjFGNHBhZitBZG5LY1E3YVdOMXY4bVFzT1VRVnpkOUZMR0NFSnB0QmRlZ1Ey?= =?utf-8?B?RUQ4WFVZSHAvYkJNMHJ5V3dvMlFmNG5uR1ZhOCtKVEtnMEdvRDVzekdRRWhI?= =?utf-8?B?UUNpNHNXcEx1VmFnZXdFVm1pT1pwQkVaL0FuMlFYU1pwMzlBRThEU0VBN3Yx?= =?utf-8?B?N2F5c0JvdW1jNUpCYlN0QnpJLzErL2xxNDN3eGo1ZUcvQitlYk9TVDFQM3hY?= =?utf-8?B?R3ZMdjUrOHVhcEh2eGlwV0E3NTZhcEFabEQzN2NBT1BGSzNyRm5zUXg4Mmcr?= =?utf-8?B?RmtwYWdGNWUrVXVIb0ZEUVR6UWZ5Z2VBL1RGaHV5NExaTGJBT295YzF4d09p?= =?utf-8?B?Uk92WmlLZW0rTHBkcHN6UEkxM3V3eC9TMm9lR0FDRHhoR2RiZW9hTjFselE1?= =?utf-8?B?UC9oZmJNZzRoeTlwSytZdjZxaGliWGx4R0ZMOGhRUlNpVnc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;6:vEB7p9txpnMUZz1KN6K0RWgT1JcoU1v7v9vjF26+fVdRCby0FjPzf0zNOR7k/B/NnQR8kVOX98DOlOaSem01ddtlUDklhjiVFGsbc42F5/cuy4z8vcxcBv1SLE3iPXN3gXMyj/KmS/ZjKkHURVqRfYbo9exxKMYJm/p2YZDhUn5DzuZ18KLAbg3hE2GBeJFlSxdWO/RR9h45shqAlKN9DEOGYtJ/MjngZoPLBrm3uLwUECqITgJm5GBLMNVyaqmKSf6YgGn6/T1hJeral16oqjQchb29y4l6TUL9tMcwCsMbJPJOqsc4ODfMbwYjRX/OqksKCGqeiObUb9muAac6iPNYSgnVF5ufvx5fCu5Evw6mY4rAonb0Izg3ui71kxpF4JIDNh3XDuEkToSkRJC5lspxabx1qBLRuwl15ttxK7g=;5:zpmOD4W7AGm1jYXtEWW+d/7rP6TElOVpDVy+XvPdyHhcWCZeje6dJpKIbmFr1SdGu9/1UaPWWX7VkJAdVydbtbX0iafyAI2FNSN+mlznjIP8QQckUP88It31go/PmML1UoATxDfn9ymabQJ0XlQu2e7dy1pgubMdJbom3M8vGXw=;24:qc98EzXjHVjLGugTY6Rh3yyjALKE+C0oKCfRDF6bZ3YT8aXOKPpI+9MxVXmwC2CdrJ8zgvBT9oQ69zTtZCS7fFO4CAeSq9j/jtQzHvkv3K0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1246;7:6I3mWI7Pg3x9vLDbmpqf2Tlci/XppFgdyjnv/jHKJQ14JfB3nnY4P2xgiUfZGWjA5/YfeAqQVR5FemEVqKCIO73Er+erXg42uxs9GVUoFBjSYu1S8LfZUh3rdQ1j1EwMcI1/ZXMI95/tFwblLs6GCLKJQOp/8RN5AaFOcmodzRAudE5QRUrxHPgLqI2hyLiDI19+oRxPnpsNIMrL7vE59PfTwj+34YoUfiLuRfChPVrKCfaIlRQpHsyhlfOIXYHfTbim4e7OjBzr3GqSMD3rAFM6ieBMvT64FVwysAHIPJVYUiQ/1mWxMK0y6C2dPRfU1VCCOK63qZ3YTX1RmDJgT6QVFaDpMENJJ/YnboN9UjSLjliUZWo0zhxJuLBtygtbyz2hZRMH+oT4rkBP/TM1qOoUXnFaB7WpQLYA3lOX3jOsrlVarMD/Eg16XSXpVEPm2eh1GuQj2o+pGw2tSXVnKg==;20:Lq8hcMUtKNIGNGbvhxCbC+ha20es7sIQwQ2RREZzNf4quF3SYWirpfXRh9FK3B8bayag25cX3e1T1V3PREFuUQpmt3eRPgLlxxCNlLjhj8pcxXmm+hClSBFMS5Ba9L+4SDytiY8T8E8jIbApfVntBn2EOy9Ly0XTJY0f8VzHsqY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2017 20:46:42.6984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1246 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-06_14:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2017 12:22 PM, Joseph Salisbury wrote: > Hi Luke, > > A kernel bug report was opened against Ubuntu [0]. This bug was fixed > by the following commit in v4.7-rc1: > > > commit 4c63c2454eff996c5e27991221106eb511f7db38 > > Author: Luke Dashjr > Date: Thu Oct 29 08:22:21 2015 +0000 > > btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in > btrfs_ioctl > > > However, this commit introduced a new regression. With this commit > applied, "btrfs fi show" no longer works and the btrfs snapshot > functionality breaks. > > > > I was hoping to get your feedback, since you are the patch author. Do > you think gathering any additional data will help diagnose this issue, > or would it be best to submit a revert request? This is working for me, could you please include an strace of the problem? Thanks! -chris