From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755069AbeASIga (ORCPT ); Fri, 19 Jan 2018 03:36:30 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39906 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754693AbeASIgG (ORCPT ); Fri, 19 Jan 2018 03:36:06 -0500 Subject: Re: [PATCH] smc: return boolean instead of integer in using_ipsec To: "Gustavo A. R. Silva" , "David S. Miller" Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180118233323.GA22539@embeddedor.com> From: Ursula Braun Date: Fri, 19 Jan 2018 09:35:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180118233323.GA22539@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18011908-0008-0000-0000-000004C3880F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011908-0009-0000-0000-00001E56FE0C Message-Id: <0eadb528-9d82-3e0d-dc21-cd61244900e5@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-19_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801190111 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2018 12:33 AM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/smc/smc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/smc/smc.h b/net/smc/smc.h > index 0bee9d1..ef13af4 100644 > --- a/net/smc/smc.h > +++ b/net/smc/smc.h > @@ -258,7 +258,7 @@ static inline bool using_ipsec(struct smc_sock *smc) > #else > static inline bool using_ipsec(struct smc_sock *smc) > { > - return 0; > + return false; > } > #endif > Gustavo, thanks for reporting, but your improvement seems to be incomplete. Besides changing line 260 of net/smc/smc.h, line 255 should be adapted the same way. Will you come up with a second patch version here? Kind regards, Ursula Braun