mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Juri Lelli <juri.lelli@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>,
	Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	luca.abeni@santannapisa.it, claudio@evidence.eu.com,
	tommaso.cucinotta@santannapisa.it, bristot@redhat.com,
	mathieu.poirier@linaro.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>,
	Quentin Perret <qperret@google.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 6/7] cgroup/cpuset: Protect DL BW data against parallel cpuset_attach()
Date: Wed, 29 Mar 2023 12:05:20 -0400	[thread overview]
Message-ID: <0eae9e7c-8bfc-6e89-c4ad-e1cd40ec03b5@redhat.com> (raw)
In-Reply-To: <20230329160240.2093277-1-longman@redhat.com>

On 3/29/23 12:02, Waiman Long wrote:
> It is possible to have parallel attach operations to the same cpuset in
> progress. To avoid possible corruption of single set of DL BW data in
> the cpuset structure, we have to disallow parallel attach operations if
> DL tasks are present. Attach operations can still proceed in parallel
> as long as no DL tasks are involved.
>
> This patch also stores the CPU where DL BW is allocated and free that BW
> back to the same CPU in case cpuset_can_attach() is called.
>
> Signed-off-by: Waiman Long <longman@redhat.com>

Juri, this patch is an addendum to your series to address the issues 
that I found from the cpuset point of view.

Cheers,
Longman


  reply	other threads:[~2023-03-29 16:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 12:55 [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli
2023-03-29 12:55 ` [PATCH 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Juri Lelli
2023-04-04 20:05   ` Qais Yousef
2023-03-29 12:55 ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Juri Lelli
2023-04-04 17:31   ` Waiman Long
2023-04-26 11:57     ` Juri Lelli
2023-04-26 14:05       ` Waiman Long
2023-04-27  2:58         ` Xuewen Yan
2023-04-27  5:53           ` Juri Lelli
2023-04-27 11:50             ` Xuewen Yan
2023-04-28 11:22             ` Qais Yousef
2023-04-26 14:31       ` Daniel Bristot de Oliveira
2023-04-04 20:05   ` Qais Yousef
2023-03-29 12:55 ` [PATCH 3/6] sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets Juri Lelli
2023-04-04 20:06   ` Qais Yousef
2023-10-09 11:43   ` Xia Fukun
2023-10-09 15:26     ` Waiman Long
2023-03-29 12:55 ` [PATCH 4/6] sched/deadline: Create DL BW alloc, free & check overflow interface Juri Lelli
2023-03-29 14:24   ` Waiman Long
2023-03-29 12:55 ` [PATCH 5/6] cgroup/cpuset: Free DL BW in case can_attach() fails Juri Lelli
2023-03-29 14:25   ` Waiman Long
2023-03-29 14:31     ` Waiman Long
2023-03-29 16:39       ` Dietmar Eggemann
2023-03-29 18:09         ` Waiman Long
2023-03-30 15:14           ` Dietmar Eggemann
2023-03-30 16:13             ` Waiman Long
2023-03-29 12:55 ` [PATCH 6/6] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
2023-04-04 20:06   ` Qais Yousef
2023-04-26 11:58     ` Juri Lelli
2023-03-29 14:34 ` [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Waiman Long
2023-03-29 16:02 ` [PATCH 6/7] cgroup/cpuset: Protect DL BW data against parallel cpuset_attach() Waiman Long
2023-03-29 16:05   ` Waiman Long [this message]
2023-03-30 13:34   ` Dietmar Eggemann
2023-04-04 20:09 ` [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Qais Yousef
2023-04-18 14:11 ` Qais Yousef
2023-04-18 14:31   ` Waiman Long
2023-04-20 14:15     ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eae9e7c-8bfc-6e89-c4ad-e1cd40ec03b5@redhat.com \
    --to=longman@redhat.com \
    --cc=agordeev@linux.ibm.com \
    --cc=bristot@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=claudio@evidence.eu.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gor@linux.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=haoluo@google.com \
    --cc=hca@linux.ibm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=luca.abeni@santannapisa.it \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=qyousef@layalina.io \
    --cc=rickyiu@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sudeep.holla@arm.com \
    --cc=tj@kernel.org \
    --cc=tommaso.cucinotta@santannapisa.it \
    --cc=vincent.guittot@linaro.org \
    --cc=wvw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®