From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB1A37DEBE for ; Tue, 11 Aug 2026 18:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474193; cv=none; b=P1WY4MNWZdlrN6/nTrnUUDjx8j85y+dy+BekZw+zlvR8R626k6XJvFPAlyAf2HKBcM6iWAFJwZbZGc3DiMPrTKGWrnrbgSHQoJqL/o+BldhP3p74DFvn+WC2x9MSAvNEpi7CjvCe3TPaVxi8DdvIaewcGnGzB0EfxF4RYAXGiVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474193; c=relaxed/simple; bh=Pq954XThEFQI+Donsj8xARWPsX+stWa3fBnDG8S1gtU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lqyjz5/9MW5vMnXcdhuhwnSW9sgcq3SMI+F63RU4DuEa0yaFvL7fi7Z2qfpdnkSDMPQHDMKtyACj3mr0PVR1m8oyXLtyT24hyaFZkbL774WuuXVMuroVG/XvMFQU+IPiUpSK5U0mBzNTiB0HC53+A/i4gBVR+2s5fDgp9aJtoNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R6N5n+wl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R6N5n+wl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5626A1F000E9; Tue, 11 Aug 2026 18:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786474192; bh=+dHjbBbWrA37kJZ885T7+w7Pqd1cWVUcE26OuZvp9OI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=R6N5n+wltg5SKuy1zFP2wSZLF27S6MWlYcXSpL3NHa+lUH9btGWYqeIdvUplTrP7r iEVi5GyaYufCpIxfcywTLoKRdBiKm8CsnwUha1v6ubg9uIZ73uUnUHMKqVhr38NWeL mZ5bVvX7vHHviBUOXUH6vuM7q3i879fXrifLytL+Xn4JiAZeRK8guJE23Fi81MRrYS ib91J8Ih6KCCk5lqVjlQtjnQToq1Qz5+piNOIwEeSppr95YiXa4Z16+Q21RC7Rjdts u/dOVGbaBeqGdIxowKOi8nt4gwtEDmmUL6lawHUcq8S+rERwN0i+QZRfhKiPJzo8T/ rywTFKdkmTs/w== Message-ID: <0ec056ff-222c-42a4-a737-0bd65d1f0a93@kernel.org> Date: Tue, 11 Aug 2026 20:49:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] selftests/mm: add stale walk->action race test To: "Lorenzo Stoakes (ARM)" Cc: Hyunwoo Kim , akpm@linux-foundation.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260811161949.3879321-1-imv4bel@gmail.com> <20260811161949.3879321-3-imv4bel@gmail.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/11/26 20:23, Lorenzo Stoakes (ARM) wrote: > On Tue, Aug 11, 2026 at 07:11:59PM +0200, David Hildenbrand (Arm) wrote: >> On 8/11/26 18:18, Hyunwoo Kim wrote: >>> The added pagewalk_race_test maps two PMDs and faults in 2MB of the first >>> one. A second thread then faults in the second PMD and drops it again with >>> MADV_DONTNEED in a loop, while the main thread reads Rss for the mapping >>> from /proc/self/smaps. >>> >>> Clearing the second PMD while smaps_pte_range() runs leaves walk->action >>> erroneously set to ACTION_AGAIN, which causes the PUD walk to be retried, >>> so the first PMD is counted twice and Rss comes out twice as large as what >>> was faulted in. >>> >>> mincore() is the caller named in the fix, but the second walk writes past >>> the length mincore() copies back, so it cannot be seen from userspace >>> there. smaps reports what the callbacks counted, so the duplicate shows up >>> in Rss. >>> >>> A failure can only come from the kernel counting the same page twice, so >>> missing the race is harmless. On an unfixed kernel the test fails after a >>> few hundred reads at most and takes about half a second. >>> >>> Assisted-by: Claude:claude-opus-5 >>> Signed-off-by: Hyunwoo Kim >>> --- >> >> I'm sorry, but I don't consider such a specialized reproducer for a problem we >> hit once a good fit for a selftest. >> >> Or am I missing something, that this here is more generic? > > To be fair I did ask him for this. :) > > I thought it would be useful to have a regression test because there's certainly > no harm in it? The code is very sensitive and catching a similar mistake in > future could be useful. > > If you're sure this isn't valuable then he could just drop it, but it's my fault > sorry Hyunwoo for giving you extra work in this case! My bad. pagewalk_race_test is just rather odd. If this would be part of a bigger test that covers more things than just one odd race, it might be better. But we certainly don't want one new test file for each kernel bug we ever trigger, right? :) -- Cheers, David