From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3571E4110 for ; Mon, 3 Mar 2025 06:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740982842; cv=none; b=gvaOWrcSUfQjRwTInGOfB9ufSyOps6qcNz1Rrj7hhM9P92LXvPuab9BYC+waYKEmCmSCMWzxC88Xz9GonLaSBWld3qQFcdcZJG23Ej1v5XQryU8Ltj4BoMP2PmXEjf9GXq5MVVe/IvzdeOX91hKkeDsvBK4hC/EoRnHU0heEA20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740982842; c=relaxed/simple; bh=xnkf9dHEY/bxJnJp3UuspjIPE+0ejwYLRa1u2I2pWLw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F26KNtzuGRKublzNkVW4Z6oj9bbo3MW3VQBd1NscwFGLbKGBKObJAJGJmJkvY/eUg0buP1yU5NVatOVLKYn7KpVw/iRzCoOV21sD/yUYR01xkM8ciIyH46wA/CtDJ25fj4SdSfaYBg9XoTU/k0KPaiF/IsYiRw6Qu5stnV6LQDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=n4GHLkjH; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="n4GHLkjH" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-22334203781so78405005ad.0 for ; Sun, 02 Mar 2025 22:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1740982840; x=1741587640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dyr2GA3li0orAMv11T62PbEJr2SsMfqcDoVbAywiFjQ=; b=n4GHLkjHDB19+s2CbedRjrcjp3Cnndf7K9chgfbcrOk5G748SCu80SjY9wpDEI5sI7 Zg20PPbKFJqNI7ezc/NtdeoxeM4XqKewFfQwHlRdFCkHSV2tVP9a/huDBA4TMQvDMc2p imbs5qZ+s+bsTiq70qf5Z78pZlLzd9+zY8L3f9GMHlqf6wholg71sPtsfwOLNdyO+po7 OABDt0UAozddrEPAe2fEgg4LdCFiAITPd5QpgaqQKINIPXpfOvLEeRlHWR8K6ko9vYgW 8LxitVKYYPB6fN66UamaS5nPf+qCqyGm7YeCvYFeCvH8zl3aaQ32p+NvJRqnhj2CWvwb ngYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740982840; x=1741587640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dyr2GA3li0orAMv11T62PbEJr2SsMfqcDoVbAywiFjQ=; b=d2KdP/KbdTVbnpT4w2Yj74U8soFVI5WJYA84ojCH0ieO/L/YGxT+xp0eJdAjRxnKEq 2LozxjqDbW+zJngPOmJow/JPYvZ96sZMjFam9poBdLUtpowZOs+kl1HgG94eOYvTpA2O xWg10IMke2K4GCEk3Akkv3zudAvihcJEOg7M2IF/ILz4Cj4Q90IeN9fZIVNq9gpsLymW u+hdgZyEq9Kc/1NtcxC8TVV1y9VFqtQfE4ALcIqrgCCWCP8W2s8t4YdlG2/j9YSLTqLL b7UCphoKXl8fheXzpswhEs30OEHeKbqqZx1H+GODGfR95Wwp/9PTFfiF8dU/JGHlLiBT HJyg== X-Forwarded-Encrypted: i=1; AJvYcCV6XLJaEF+q1Mz4+54iZ8kxLjiaH6YLSD8+tkY3hGPptgGZTa7tcs2z+ueu3r4/5qPAGTzZ+STuD72U47k=@vger.kernel.org X-Gm-Message-State: AOJu0YzRaZQhd2rjf/v4ggLC1aOUf9Zd2NDcMlTBA8KTmTorgHS3OStq PX89mFBIltiAlPu8cGM2lariiTDmn4uOvweicjIZPNjyWfZzT6XpgtOGHbCAEV4= X-Gm-Gg: ASbGncsUXGQAbLZ7ESXMDouJFcy414NIW69LSsKb1yma2L0PQgmSdSiijFsqqM3XMoe ce2QiVSzRqUhXT7INlbITtLRcK9LXE0olUVB4ncp/xVZpnW3yiJjNDpEUAJxP2wxsVbxbxYyaXk FEDNj63EZLJ+R9pCsHcMwn6tLFlQLiZpIWIUhGYdPyNCmV+tbKDBln1y7Y/g4RHtpYe7g9O+z1q xHOOPKc6e2FU01xLa/lUiqXSXkExfJaMoQHfW195FFF6ESJygTlD0zGHf9R2PlLAryxTFRcvdae 0V3VHPspp5UcILM71pmkADWHuVpEHT1/Lp3cSzkGksKnwmR/e2rC0Pp/nQ== X-Google-Smtp-Source: AGHT+IEieq/BD1K+cE8LpIHguGq+X9OAmHwKGwyKh2uFq+hVqj0tth75vrcZnQUypyq8Bcdl5DillA== X-Received: by 2002:aa7:8207:0:b0:734:26c6:26d3 with SMTP id d2e1a72fcca58-7349d1ec1a1mr23805966b3a.5.1740982838260; Sun, 02 Mar 2025 22:20:38 -0800 (PST) Received: from [157.82.207.107] ([157.82.207.107]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736614c13dcsm414807b3a.42.2025.03.02.22.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Mar 2025 22:20:37 -0800 (PST) Message-ID: <0ec77558-bdfb-4471-a44b-0a37a9422f72@daynix.com> Date: Mon, 3 Mar 2025 15:20:33 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 5/6] selftest: tun: Add tests for virtio-net hashing To: Jakub Kicinski Cc: Jonathan Corbet , Willem de Bruijn , Jason Wang , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Michael S. Tsirkin" , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Yuri Benditovich , Andrew Melnychenko , Stephen Hemminger , gur.stavi@huawei.com, Lei Yang References: <20250228-rss-v7-0-844205cbbdd6@daynix.com> <20250228-rss-v7-5-844205cbbdd6@daynix.com> <20250228062947.7864a59c@kernel.org> Content-Language: en-US From: Akihiko Odaki In-Reply-To: <20250228062947.7864a59c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/02/28 23:29, Jakub Kicinski wrote: > On Fri, 28 Feb 2025 16:58:51 +0900 Akihiko Odaki wrote: >> The added tests confirm tun can perform RSS and hash reporting, and >> reject invalid configurations for them. > > The tests may benefit from using FIXTURE_VARIANT(), up to you. I took a look at it after seeing your suggestion, but it is unfortunately not straightfoward to use FIXTURE_VARIANT() for them so I'll leave it as is. The problem is that a packet for each test has a different type and requires different functions to construct. Tests added in "[PATCH net-next v7 4/6] selftest: tun: Test vnet ioctls without device" are easier to adopt FIXTURE_VARIANT(), but one exceptional test case, which is for TUNGETVNETHASHCAP, does not fit well so I also keep the current form. Thank you for your suggestion anyway. > > The IPv4 tests fail reliably on a VM with a debug kernel > (kernel/configs/debug.config included in the config): > > # 5.90 [+0.00] ok 14 tun_vnet_hash.unclassified > # 5.90 [+0.00] # RUN tun_vnet_hash.ipv4 ... > # 6.18 [+0.28] # tun.c:669:ipv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), 0, VIRTIO_NET_HASH_REPORT_IPv4, 0x6e45d952) (0) > # 15.09 [+8.92] # ipv4: Test failed > # 15.10 [+0.00] # FAIL tun_vnet_hash.ipv4 > # 15.10 [+0.00] not ok 15 tun_vnet_hash.ipv4 > # 15.10 [+0.00] # RUN tun_vnet_hash.tcpv4 ... > # 15.36 [+0.26] # tun.c:689:tcpv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), VIRTIO_NET_HDR_F_DATA_VALID, VIRTIO_NET_HASH_REPORT_TCPv4, 0xfb63539a) (0) > # 24.76 [+9.40] # tcpv4: Test failed > # 24.76 [+0.00] # FAIL tun_vnet_hash.tcpv4 > # 24.76 [+0.00] not ok 16 tun_vnet_hash.tcpv4 > # 24.77 [+0.00] # RUN tun_vnet_hash.udpv4 ... > # 25.05 [+0.28] # tun.c:710:udpv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), VIRTIO_NET_HDR_F_DATA_VALID, VIRTIO_NET_HASH_REPORT_UDPv4, 0xfb63539a) (0) > # 32.11 [+7.06] # udpv4: Test failed > # 32.11 [+0.00] # FAIL tun_vnet_hash.udpv4 > # 32.11 [+0.00] not ok 17 tun_vnet_hash.udpv4 I cannot reproduce the failure. What commit did you apply this patch series on? What architecture did the kernel run on?