From: Faiz Abbas <faiz_abbas@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <robh+dt@kernel.org>,
<bcousson@baylibre.com>, <paul@pwsan.com>, <t-kristo@ti.com>,
<mark.rutland@arm.com>, <sboyd@kernel.org>
Subject: Re: [PATCH v5 4/6] bus: ti-sysc: Add support for software reset
Date: Tue, 10 Jul 2018 18:50:14 +0530 [thread overview]
Message-ID: <0ece4ef9-1306-d36a-acff-6ee4b98337c8@ti.com> (raw)
In-Reply-To: <20180710114248.GI99251@atomide.com>
Hi Tony,
On Tuesday 10 July 2018 05:12 PM, Tony Lindgren wrote:
> Hi,
>
> * Faiz Abbas <faiz_abbas@ti.com> [180709 16:50]:
>> Add support for the software reset of a target interconnect
>> module using its sysconfig and sysstatus registers.
> ...
>> --- a/drivers/bus/ti-sysc.c
>> +++ b/drivers/bus/ti-sysc.c
> ...
>> +static int sysc_reset(struct sysc *ddata)
>> +{
>> + int offset = ddata->offsets[SYSC_SYSCONFIG];
>> + int val = sysc_read(ddata, offset);
>
> Testing with omap4 sysc dts data I noticed we already
> have modules where there is only rev register and no
> SYSC_SYSCONFIG. So not using legacy mode. The
> above offset with -ENODEV value will not work :)
>
> I added some more checks and moved them to the reset
> function.
Great. Thanks for the fix.
Thanks,
Faiz
next prev parent reply other threads:[~2018-07-10 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 16:48 [PATCH v5 0/6] Add MCAN Support for dra76x Faiz Abbas
2018-07-09 16:48 ` [PATCH v5 1/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-07-09 16:48 ` [PATCH v5 2/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas
2018-07-10 5:44 ` Tony Lindgren
2018-07-09 16:48 ` [PATCH v5 3/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas
2018-07-09 16:48 ` [PATCH v5 4/6] bus: ti-sysc: Add support for software reset Faiz Abbas
2018-07-10 11:42 ` Tony Lindgren
2018-07-10 13:20 ` Faiz Abbas [this message]
2018-07-09 16:48 ` [PATCH v5 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas
2018-07-09 16:48 ` [PATCH v5 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ece4ef9-1306-d36a-acff-6ee4b98337c8@ti.com \
--to=faiz_abbas@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®