From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 04/18] scripts/get_maintainer.pl - Warn on missing git or git repository
Date: Sat, 23 May 2009 19:37:35 -0700 [thread overview]
Message-ID: <0ececbed9b6408124176a0e3b8fefdecdffc2633.1243131992.git.joe@perches.com> (raw)
In-Reply-To: <cover.1243131992.git.joe@perches.com>
support older versions of grep (use -E not -P)
no need to return data in routine recent_git_signoffs
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/get_maintainer.pl | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index e733e87..fe49122 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -443,11 +443,21 @@ sub recent_git_signoffs {
my @lines = ();
if (which("git") eq "") {
- die("$P: git not found. Add --nogit to options?\n");
+ warn("$P: git not found. Add --nogit to options?\n");
+ return;
+ }
+ if (!(-d ".git")) {
+ warn("$P: .git repository not found.\n");
+ warn("Use a .git repository for better results.\n");
+ warn("ie: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n");
+ return;
}
$cmd = "git log --since=${email_git_since} -- ${file}";
- $cmd .= " | grep -Pi \"^[-_ a-z]+by:.*\\\@.*\$\"";
+ $cmd .= " | grep -Ei \"^[-_ a-z]+by:.*\\\@.*\$\"";
+ if (!$email_git_penguin_chiefs) {
+ $cmd .= " | grep -Ev \"${penguin_chiefs}\"";
+ }
$cmd .= " | cut -f2- -d\":\"";
$cmd .= " | sort | uniq -c | sort -rn";
@@ -486,7 +496,6 @@ sub recent_git_signoffs {
push(@email_to, $line);
}
}
- return $output;
}
sub uniq {
--
1.6.3.1.10.g659a0.dirty
next prev parent reply other threads:[~2009-05-24 2:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 2:37 [PATCH 00/18] MAINTAINERS and scripts/get_maintainer.pl updates Joe Perches
2009-05-24 2:37 ` [PATCH 01/18] scripts/get_maintainer.pl - Output first field only in mailing lists and after maintainers Joe Perches
2009-05-24 2:37 ` [PATCH 02/18] scripts/get_maintainer.pl - Better fix for subscriber-only mailing lists Joe Perches
2009-05-24 2:37 ` [PATCH 03/18] scripts/get_maintainer.pl - improve --git-chief-penquins (Linus Torvalds) filtering Joe Perches
2009-05-24 2:37 ` Joe Perches [this message]
2009-05-24 2:37 ` [PATCH 05/18] scripts/get_maintainer.pl - support M: lines with names and multiple entries per M: line Joe Perches
2009-05-24 2:37 ` [PATCH 06/18] scripts/get_maintainer.pl - Better email name quoting Joe Perches
2009-05-24 2:37 ` [PATCH 07/18] scripts/get_maintainer.pl - Support both "P:/M:" and integrated "M:" lines Joe Perches
[not found] ` <20090526144141.570594cf.akpm@linux-foundation.org>
[not found] ` <1243455722.27337.65.camel@Joe-Laptop.home>
[not found] ` <20090527151510.fb773db6.akpm@linux-foundation.org>
2009-06-01 17:45 ` Script to integrate MAINTAINERS P: and M: lines Joe Perches
2009-06-02 9:12 ` Pavel Machek
2009-06-05 21:47 ` Sam Ravnborg
2009-06-05 22:57 ` Joe Perches
2009-05-24 2:37 ` [PATCH 08/18] scripts/get_maintainer.pl - Don't print maintainers when not requested Joe Perches
2009-05-24 2:37 ` [PATCH 09/18] scripts/get_maintainer.pl - Allow 8 bit characters in email addresses Joe Perches
2009-05-24 2:37 ` [PATCH 10/18] scripts/get_maintainer.pl - change "die" to "warn" when command line file is not a patch Joe Perches
2009-05-24 2:37 ` [PATCH 11/18] MAINTAINERS - Swap mismarked ECRYPT FS M: and P: entries Joe Perches
2009-05-24 2:37 ` [PATCH 12/18] MAINTAINERS - Pair EDAC-E752X P: and M: entries Joe Perches
2009-05-24 2:37 ` [PATCH 13/18] MAINTAINERS - Add file patterns to "THE REST" Joe Perches
2009-05-24 2:37 ` [PATCH 14/18] MAINTAINERS - Update M32R file patterns after rename Joe Perches
2009-05-24 2:37 ` [PATCH 15/18] MAINTAINERS - Mark ALSA lists as moderated Joe Perches
2009-05-24 2:37 ` [PATCH 16/18] MAINTAINERS - Remove L: linux-kernel@vger.kernel.org from all but "THE REST" Joe Perches
2009-05-24 3:18 ` Grant Likely
2009-05-24 3:22 ` Joe Perches
2009-05-24 4:28 ` Grant Likely
2009-05-24 4:39 ` Joe Perches
2009-05-24 4:51 ` Grant Likely
2009-05-24 4:58 ` Joe Perches
2009-05-27 1:33 ` Paul Mundt
2009-05-27 5:38 ` Joe Perches
2009-05-27 5:50 ` Paul Mundt
2009-05-27 6:00 ` Andrew Morton
2009-05-27 6:02 ` Paul Mundt
2009-05-27 16:12 ` Joe Perches
2009-05-24 10:42 ` Mark Brown
2009-05-26 23:42 ` Paul E. McKenney
2009-05-27 18:18 ` [PATCH] MAINTAINERS: Add Paul McKenney to RCU and RCUTORTURE Joe Perches
2009-05-27 21:03 ` Paul E. McKenney
2009-05-24 2:37 ` [PATCH 17/18] MAINTAINERS - Mention scripts/get_maintainer.pl in the preface Joe Perches
2009-05-24 2:37 ` [PATCH 18/18] MAINTAINERS - Add file pattern to CISCO FCOE HBA DRIVER Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ececbed9b6408124176a0e3b8fefdecdffc2633.1243131992.git.joe@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®