From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbeASHNc (ORCPT ); Fri, 19 Jan 2018 02:13:32 -0500 Received: from mga11.intel.com ([192.55.52.93]:25175 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbeASHNZ (ORCPT ); Fri, 19 Jan 2018 02:13:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,380,1511856000"; d="scan'208";a="11796304" Subject: Re: [PATCH v4] perf report: Fix regression when decoding intelPT traces To: Arnaldo Carvalho de Melo Cc: Mathieu Poirier , jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org References: <1515616312-27645-1-git-send-email-mathieu.poirier@linaro.org> <20180118162950.GH18383@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <0ed21b26-83f5-99fe-af03-26d26e7afdb6@intel.com> Date: Fri, 19 Jan 2018 09:12:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180118162950.GH18383@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/18 18:29, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 10, 2018 at 01:31:52PM -0700, Mathieu Poirier escreveu: >> Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered >> events) breaks intelPT trace decoding by invariably returning an error if >> the event type isn't a PERF_SAMPLE_TIME. > > Adrian, have you had the chance of looking at this? > > I'm tentatively applying with Jiri's ack. Yes, it is fine. FWIW Acked-by: Adrian Hunter > > - Arnaldo > >> With this patch the timestamp is initialised and processing is allowed to >> continue if the error returned by function >> perf_evlist__parse_sample_timestamp() is not a fault. >> >> Signed-off-by: Mathieu Poirier >> Acked-by: Jiri Olsa >> --- >> Changes for v4: >> - Rebased to latest perf/core branch >> - Added Jiri's ACK >> --- >> tools/perf/util/session.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c >> index 54e30f1bcbd7..07221884f725 100644 >> --- a/tools/perf/util/session.c >> +++ b/tools/perf/util/session.c >> @@ -1508,10 +1508,10 @@ static s64 perf_session__process_event(struct perf_session *session, >> return perf_session__process_user_event(session, event, file_offset); >> >> if (tool->ordered_events) { >> - u64 timestamp; >> + u64 timestamp = -1ULL; >> >> ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); >> - if (ret) >> + if (ret && ret != -1) >> return ret; >> >> ret = perf_session__queue_event(session, event, timestamp, file_offset); >> -- >> 2.7.4 >