From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BECC433E0 for ; Mon, 20 Jul 2020 04:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5128207EA for ; Mon, 20 Jul 2020 04:13:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EiTFv+f0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726029AbgGTENi (ORCPT ); Mon, 20 Jul 2020 00:13:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56510 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725263AbgGTENi (ORCPT ); Mon, 20 Jul 2020 00:13:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595218416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5W6bavoC2QFTavpGU5cs5NwNxhTst/1scGklkKaWEu8=; b=EiTFv+f03gcwEcBEXkec1vyRRmKqqj6fLg2Qfvd3FHaqc4RQqS7cJnzZS5zHHXLKE5geam sqVAsSUJOZ8aP4OhLxl2KWjoQzwWecGIC/isjUwQJyLBOIAMXXbnm2i6xKgjtvy7IGmGM1 Pg++RDc62C+w3yTlMmPuZDRHrSTqgvk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-imyCPF87OSKWeaQHXtT7jw-1; Mon, 20 Jul 2020 00:13:33 -0400 X-MC-Unique: imyCPF87OSKWeaQHXtT7jw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5D288064DD; Mon, 20 Jul 2020 04:13:31 +0000 (UTC) Received: from [10.72.13.139] (ovpn-13-139.pek2.redhat.com [10.72.13.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7918A5C1B2; Mon, 20 Jul 2020 04:13:26 +0000 (UTC) Subject: Re: [PATCH vhost next 06/10] vdpa: Add means to communicate vq status on get_vq_state To: Eli Cohen Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, shahafs@mellanox.com, saeedm@mellanox.com, Parav Pandit References: <20200716072327.5359-1-eli@mellanox.com> <20200716072327.5359-7-eli@mellanox.com> <20200716082116.GA182860@mtl-vdi-166.wap.labs.mlnx> <296e6fcb-946c-f577-2e22-46528f78fda9@redhat.com> <20200716102533.GB186790@mtl-vdi-166.wap.labs.mlnx> From: Jason Wang Message-ID: <0ed28d74-cb0c-89af-61dd-9256e8bb2328@redhat.com> Date: Mon, 20 Jul 2020 12:13:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200716102533.GB186790@mtl-vdi-166.wap.labs.mlnx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/16 下午6:25, Eli Cohen wrote: > On Thu, Jul 16, 2020 at 05:35:18PM +0800, Jason Wang wrote: >> On 2020/7/16 下午4:21, Eli Cohen wrote: >>> On Thu, Jul 16, 2020 at 04:11:00PM +0800, Jason Wang wrote: >>>> On 2020/7/16 下午3:23, Eli Cohen wrote: >>>>> Currently, get_vq_state() is used only to pass the available index value >>>>> of a vq. Extend the struct to return status on the VQ to the caller. >>>>> For now, define VQ_STATE_NOT_READY. In the future it will be extended to >>>>> include other infomration. >>>>> >>>>> Modify current vdpa driver to update this field. >>>>> >>>>> Reviewed-by: Parav Pandit >>>>> Signed-off-by: Eli Cohen >>>> What's the difference between this and get_vq_ready()? >>>> >>>> Thanks >>>> >>> There is no difference. It is just a way to communicate a problem to >>> with the state of the VQ back to the caller. This is not available now. >>> I think an asynchronous is preferred but that is not available >>> currently. >> >> I still don't see the reason, maybe you can give me an example? >> >> > My intention was to provide a mechainsm to return meaningful information > on the state of the vq. For example, when you fail to get the state of > the VQ. > > Maybe I could just change the prototype of the function to return int > and the driver could put an error if it has trouble returning the vq > state. That's fine. Thanks