RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

["Yashwant Varur" <yashwant.v@samsung.com>]

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Wednesday, April 23, 2025 8:41 PM
To: Yashwant Varur <yashwant.v@samsung.com>; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; niyas.ahmed@samsung.com
Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

On 23/04/2025 08:00, Yashwant Varur wrote:
> This patch adds the ethernet pin configuration.


> 
> Signed-off-by: Yashwant Varur <yashwant.v@samsung.com>
> Signed-off-by: Changsub Lee <cs0617.lee@samsung.com>

Incorrect chain or confusing. Who was the author? What is the meaning of the last SoB?
>
Sorry will correct the order.


> ---
>  .../dts/exynos/exynosautov920-pinctrl.dtsi    | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi 
> b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> index 663e8265cbf5..778584d339d5 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank {
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  	};
> +
> +	eth0_pps_out: eth0_pps_out {

Please follow DTS coding style carefully. This applies to all commits you try to send from your downstream/vendor code.
>
Sure, thanks

What is more important, I don't really understand why you are doing this
- there is no user of these entries - and commit msg does not help here.
>
Understood, in v2 will add the Ethernet node as well.



Best regards,
Krzysztof