mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Balbir Singh <balbirs@nvidia.com>
To: Wei Yang <richard.weiyang@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: david@kernel.org, ljs@kernel.org, riel@surriel.com,
	liam@infradead.org, vbabka@kernel.org, harry@kernel.org,
	jannh@google.com, willy@infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, lance.yang@linux.dev
Subject: Re: [PATCH] mm/page_vma_mapped: guard check_pmd() with CONFIG_TRANSPARENT_HUGEPAGE
Date: Fri, 26 Jun 2026 10:08:10 +1000	[thread overview]
Message-ID: <0ed9b9ea-6294-44e4-896a-36a1541ebd47@nvidia.com> (raw)
In-Reply-To: <20260625064102.tcmvrctcqibl54yr@master>

On 6/25/26 16:41, Wei Yang wrote:
> +cc Balbir
> 
> On Wed, Jun 24, 2026 at 09:59:43PM -0700, Andrew Morton wrote:
>> On Thu, 25 Jun 2026 03:46:29 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:
>>
>>>> Sashiko had an off-topic complaint about the surrounding code:
>>>> 	https://lore.kernel.org/oe-kbuild-all/202606240042.ffPsEXVc-lkp@intel.com/
>>>
>>> I see this robot reply, but not see the Sashiko comment.
>>>
>>> How can I view Sashiko's commnet?
>>
>> oop sorry.
>>
>> You can go to https://sashiko.dev/ and search for the email subject. 
>>
>> Or append your Message-ID to "https://sashiko.dev/#/patchset":
>>
>> 	https://sashiko.dev/#/patchset/20260624082359.2869-1-richard.weiyang@gmail.com
>>
> 
> Got it, thansk
> 
> This one mentioned two things:
> 
>   a. page_vma_mapped_walk() return without check
>   b. whether __split_huge_pmd_locked() would split device-private pmd
> 
> For a., it is being fixing at [1].
> 
> For b., to be honest I am not 100% for sure. If a device-private pmd could be
> file backed, then this looks like a bug.
> 
> Balbir,
> 
> Would you mind taking a look at the second comment raised by Sashiko?
> 
> [1]: https://lore.kernel.org/linux-mm/20260624065353.1622-1-richard.weiyang@gmail.com/
> 

device-private pmd's are not file backed

Balbir

  parent reply	other threads:[~2026-06-26  0:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  8:23 Wei Yang
2026-06-24 20:14 ` Andrew Morton
2026-06-25  3:46   ` Wei Yang
2026-06-25  4:59     ` Andrew Morton
2026-06-25  6:41       ` Wei Yang
2026-06-25 13:51         ` Lorenzo Stoakes
2026-06-26  0:08         ` Balbir Singh [this message]
2026-06-25 13:45 ` Lorenzo Stoakes
2026-06-25 13:49   ` David Hildenbrand (Arm)
2026-06-25 14:02     ` Lorenzo Stoakes
2026-06-25 14:30       ` David Hildenbrand (Arm)
2026-06-25 16:18         ` Wei Yang
2026-06-25 23:13           ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ed9b9ea-6294-44e4-896a-36a1541ebd47@nvidia.com \
    --to=balbirs@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=harry@kernel.org \
    --cc=jannh@google.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=richard.weiyang@gmail.com \
    --cc=riel@surriel.com \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome