From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbdAWPZO (ORCPT ); Mon, 23 Jan 2017 10:25:14 -0500 Received: from mout.web.de ([212.227.17.12]:60459 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdAWPZM (ORCPT ); Mon, 23 Jan 2017 10:25:12 -0500 Subject: [PATCH 2/4] perf probe: Delete an unnecessary assignment in try_to_find_absolute_address() To: Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , He Kuang , Ingo Molnar , Jiri Olsa , Masami Hiramatsu , Milian Wolff , Peter Zijlstra , Ravi Bangoria , Wang Nan References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <0ede09ec-79b6-c8bd-5b20-02c63ed98aab@users.sourceforge.net> Date: Mon, 23 Jan 2017 16:24:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LirvrcOvEWIYUvIYItACzXt0dGfe4BEcNFNXYrcgWWitQzVd3Tx qq7YhZxzCp1uVQ7T3YyawhqXwMiHCLbXHWCKiqXD92RHlalaWxa60VlXfPrlBhcGqeKXSVC kYEI/NW3EUj8rf60Glx0XMCgxAgEdxx9JekVJrGL06+GBu9Uurgu2QtYFpwnikFzjDWKN7W KVjxr0n91kvKuLIVj9C0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:3nW+kFssZbw=:UQaFzDK6fZ767qbimXmarZ /9QE74J0LHPnhB1NjjNQEMrPlhBwMFLfY0wlomFJIlZBDeAXwDNbpBw3twpcyp4qTO9kB9aCC IlNg5asE3+b/HXKkNqOomZCr+JvooroQSvXQvzyP33qzeoRJmO2fP+7GEwojqBCkCDkMvBBiv AbWum8PcdFkWyScz6uDYTXzpjlkEc3KMVaWzOTrWzHudV03hmSielAn2KHFfvgVFJcfZRoUvQ +Z914UMlWJwdsWPBr91CKo7KLc26YBf2B6xm6JTKorSUsku+HYQBMlA265kC0wSZ7ii0oxNWK p+1leyrMa5zPK7PcUmdeB4B88mUCtGJvvCaKhD1Wifjyk/jjUdpHHCPUydLoqEnVyPU6Ga2Vv yRwod3LmDSrJMYzdzfthdQlwtcSKBQrcTpsoMACCMGoYPCWlmQEEuBfHnbw0WfSReB5dhcmJv HBEOwPMlzMnBd2SMwFkVApVdw6YYZJJGc2uCaNhyvCI1VuSVmDs/7z341v0ttNfbU3Z7bJukL Li9ELEoLMQ55xA2Ug8vvVrc4Jt0xtuy/p7wSQ4HVarduLJEvJuXGO/r+DbpDc/tA57Ol2LPUu iM3XsDGhV5ccduKz7YafEGCLJy6gYAY95IvK6cbkkEa4GT1EOlp6d7txW0mbkbg4jrHGNeYN7 JBO7N9HsbTikcURFuRA1taRBP/6vsq98Ve4gXNGiQe0t//lWuuWfOiuCtsKTP3MqJKBUrCv3e ZBVcK5OizQjU1L4NLl0MX5Lrv0G3t5aH8WMChmpmpoiAP2EVwxvP1ZdaMdQsBlB/AKcJYjmal UcyY+Tz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 23 Jan 2017 15:10:19 +0100 Remove an error code assignment which is redundant in an if branch for the handling of a memory allocation failure because the same value was set for the local variable "err" before. Signed-off-by: Markus Elfring --- tools/perf/util/probe-event.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 6c7508337fe8..5a34c93b818a 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2956,10 +2956,9 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, tev->nargs = pev->nargs; tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs); - if (!tev->args) { - err = -ENOMEM; + if (!tev->args) goto errout; - } + for (i = 0; i < tev->nargs; i++) copy_to_probe_trace_arg(&tev->args[i], &pev->args[i]); -- 2.11.0