mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Ivan Mikhaylov <fr0st61te@gmail.com>
Cc: Iwona Winiarska <iwona.winiarska@intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH 2/3] hwmon: (peci/dimmtemp) add Intel Emerald Rapids platform support
Date: Tue, 7 Oct 2025 10:26:10 +0200	[thread overview]
Message-ID: <0ede72a9-4555-4e4d-959d-3a505b6598ee@molgen.mpg.de> (raw)
In-Reply-To: <20251006215321.5036-3-fr0st61te@gmail.com>

Dear Ivan,


Thank you for your patch.

Am 06.10.25 um 23:53 schrieb Ivan Mikhaylov:
> Extend the functionality of hwmon (peci/dimmtemp) for Emerald Rapids
> platform.
> 
> The patch has been tested on a 5S system with 16 DIMMs installed.

What is 5S? 5 sockets? (Probably not.)

> Verified read of DIMM temperature thresholds & temperature.

Also paste the output?

> Using Sapphire's callbacks about getting thresholds because it's same
> platform/socket.
> 
> Signed-off-by: Ivan Mikhaylov <fr0st61te@gmail.com>
> ---
>   drivers/hwmon/peci/dimmtemp.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/hwmon/peci/dimmtemp.c b/drivers/hwmon/peci/dimmtemp.c
> index fbe82d9852e0..a281476c7a31 100644
> --- a/drivers/hwmon/peci/dimmtemp.c
> +++ b/drivers/hwmon/peci/dimmtemp.c
> @@ -32,6 +32,8 @@
>   #define DIMM_IDX_MAX_ON_ICXD	2
>   #define CHAN_RANK_MAX_ON_SPR	8
>   #define DIMM_IDX_MAX_ON_SPR	2
> +#define CHAN_RANK_MAX_ON_EMR	8
> +#define DIMM_IDX_MAX_ON_EMR	2
>   
>   #define CHAN_RANK_MAX		CHAN_RANK_MAX_ON_HSX
>   #define DIMM_IDX_MAX		DIMM_IDX_MAX_ON_HSX
> @@ -571,6 +573,12 @@ read_thresholds_spr(struct peci_dimmtemp *priv, int dimm_order, int chan_rank, u
>   	return 0;
>   }
>   
> +static int read_thresholds_emr(struct peci_dimmtemp *priv, int dimm_order,
> +			       int chan_rank, u32 *data)
> +{
> +	return read_thresholds_spr(priv, dimm_order, chan_rank, data);
> +}
> +
>   static const struct dimm_info dimm_hsx = {
>   	.chan_rank_max	= CHAN_RANK_MAX_ON_HSX,
>   	.dimm_idx_max	= DIMM_IDX_MAX_ON_HSX,
> @@ -620,6 +628,13 @@ static const struct dimm_info dimm_spr = {
>   	.read_thresholds = &read_thresholds_spr,
>   };
>   
> +static const struct dimm_info dimm_emr = {
> +	.chan_rank_max  = CHAN_RANK_MAX_ON_EMR,
> +	.dimm_idx_max  = DIMM_IDX_MAX_ON_EMR,
> +	.min_peci_revision = 0x40,
> +	.read_thresholds = &read_thresholds_emr,
> +};
> +
>   static const struct auxiliary_device_id peci_dimmtemp_ids[] = {
>   	{
>   		.name = "peci_cpu.dimmtemp.hsx",
> @@ -649,6 +664,10 @@ static const struct auxiliary_device_id peci_dimmtemp_ids[] = {
>   		.name = "peci_cpu.dimmtemp.spr",
>   		.driver_data = (kernel_ulong_t)&dimm_spr,
>   	},
> +	{
> +		.name = "peci_cpu.dimmtemp.emr",
> +		.driver_data = (kernel_ulong_t)&dimm_emr,
> +	},
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(auxiliary, peci_dimmtemp_ids);

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

  reply	other threads:[~2025-10-07  8:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 21:53 [PATCH 0/3] Add Emerald Rapids PECI support Ivan Mikhaylov
2025-10-06 21:53 ` [PATCH 1/3] peci: cpu: add Intel Emerald Rapids support Ivan Mikhaylov
2025-10-07  8:19   ` Paul Menzel
2025-10-12 18:11   ` Guenter Roeck
2025-10-06 21:53 ` [PATCH 2/3] hwmon: (peci/dimmtemp) add Intel Emerald Rapids platform support Ivan Mikhaylov
2025-10-07  8:26   ` Paul Menzel [this message]
2025-10-13 11:44     ` Ivan Mikhaylov
2025-10-13 14:47       ` Guenter Roeck
2025-10-12 18:12   ` Guenter Roeck
2025-10-06 21:53 ` [PATCH 3/3] hwmon: (peci/cputemp) add Intel Emerald Rapids support Ivan Mikhaylov
2025-10-07  8:31   ` Paul Menzel
2025-10-12 18:13   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ede72a9-4555-4e4d-959d-3a505b6598ee@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=fr0st61te@gmail.com \
    --cc=iwona.winiarska@intel.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®