From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405D6470424 for ; Thu, 23 Jul 2026 13:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784813610; cv=none; b=arNsNSVTqbGAXOwYbOOn3YtYa4+fSvBrOgQfg6J5RAgxBpCF9dOynLzxjBHW1bRyWRJ+wlDz763Fw9oG+3htKqcVwPiT3J5QYFQEtLkt89ZMWExBbkaM6xM0OWSeGnqeprWuZeZ7A5Hy7j+2fk0VvSwf9jHKyS/i32zUxWC/Tdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784813610; c=relaxed/simple; bh=pWsZFrbNUS6eEaXbQAM66UZCQPvicce1zTVxzu/L6nM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s3RM0lc4DJ7y4DRQKPbNPy7SQ7OQPopieH36v89G8YLvjqPhbxcJ0gyaQqDp980bFMJ4ibSum8EYPBM96yOp93THOlubeEz3NjJnuhwd5j0IpEbqlP14Qs8BTPhij7uTUuMg+DY4vTI8H7A3Ez748JBDY2wmrT0J4DIFWEjoxYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d5itg1F0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J11p23F9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d5itg1F0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J11p23F9" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NCvXJF3954473 for ; Thu, 23 Jul 2026 13:33:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AAJ92+dVKkhStldqu20Psdf6IGjmApe60MPX/QGCFWI=; b=d5itg1F0Kk0mU1DI fimuZV/3TiUVVzE8yLSvIflcj1ApAf2/HjRwb7DE9KCmAND+kTWLsTmaE1tMl4Q2 NZbjavDKoY3MQaNgufXBodHRUpggkEEVDXCTtYAoGY1+4MC+hSGfkiuFEf/438I5 +J471LtDsPK/R+svfiWFa13EYwD3nFw+/P1iyCuIpBFgSptn9UBlyGeOFZFbMrK3 BXikjjCnAB0eQDgE7eB8b6iAw/6DCAIlpavYu0qrj3AqwwvWk5xBdPnxIWlHXYDj qeFuxIKnk2wFpmY3bocGO7H0uFlVwSiQYr+voyuhZnPeJHTmLDXYSM14Z5hfn04i k6Jong== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fke0kskey-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 13:33:27 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7ebeeb51976so515462a34.1 for ; Thu, 23 Jul 2026 06:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784813606; x=1785418406; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AAJ92+dVKkhStldqu20Psdf6IGjmApe60MPX/QGCFWI=; b=J11p23F9BfB6j79a6DacxHlNmDE8vSliGBWTa5RDSfADKHUNrzNHCNy6OW2NxzO8yv ZeutIuCtBFtbRb76nSyAeBzA4x2t5BXloH+X3hmxFqqdOgjUt9r6FlYLIbB3cw8pohQW RRrqCsBkotktbQbhCIVM4ocpsgNe49tUmDMe6grj9493yqu6osmv0AQEzpQ3TZvRU5FR +ol3BVaVUEZ86dRWJgl87JCJWeiNXnzoudrAEWZCqhaXyj3B2pDomx1Vh+xUTrTHXtsF j8WGEwB9NNv3TME5RC3iyCTJzHFMlf4wtAQLHjHW3BaQNZ3iqccWCRC0uiRU7xGXBLSV WUBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784813606; x=1785418406; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AAJ92+dVKkhStldqu20Psdf6IGjmApe60MPX/QGCFWI=; b=FcG0KDTZikqvt5AzpHvxvzOdPO7mWHGxfDFnklzB/jIE1EJ1CxuO9VA2SkiIg00sLA ZApQIoYhQxIqhXsFGKKlM+SiuRelKY/S6yKq0AIhhRqoAmRv6/OjbycxdKMAvKwU2Tm2 WKBQUAcD+fougpVL/HwM0wy7AO9VUHSwJlq7XXBLefhePGonrErxVkTLfGZdN8BnaZzx HT8R8AQZ5E7eqZQuwILvBtvXopRDI7ZExFeHHUqiErqroV6pvNnC3jou8iCNVw7CEun2 EqnxPbhFpk0Eb7hZiDe1g7IwMyJybeTCGrx8Pv5MnYFo4thz2LZhNRyZurdAXkIEzR73 0BEA== X-Forwarded-Encrypted: i=1; AHgh+RqgCErU9b4NQjwU+vO3yuzdw73zvqArzH6y4RYlDmsbYgz8ghzz5R4Gx5rxCMM8ueUwUX5fRt0RJvEA9sk=@vger.kernel.org X-Gm-Message-State: AOJu0YzpbB1KyipGS8E8Ru3lKIrInEENrSsj9ey5I8+kTSYv5+r6wuPK us4kumnJ91fH1qtEWvOOkCGPQL+XSGQHbz8y3Kpo8Yn93NfNhdkHh+qkMD9LELc8E2ybGQSsh7e PaMQU48haJUZy56ziDA4PDKIGBCzIH6IFDJlv2G9HwBOXXKPIC2ubIEtCAf3fpaK8k8I= X-Gm-Gg: AR+sD11D8daHLZDox3BT8Bfoav9dbqesTI4thj/xyv9NSL4xvrjl4mN7OydXLT0Ym3q tr5OlOgaRC9Vp3VRL1MZwP5r2o6ly6PnLX89TDEx81XiF83XaPFkKmDLZELy/mYvvHzTSW4nSda lj/ZSGG8l+RauqJ/aw2EhiLsNMxpYpmwAWEh7K5tsrMl6Y+23tgYAN60gqYdfmNweXhxqDwkcxM NwZj0lK9WMUe8KWFpB07C3jt3NJdPzsIPQeMKdRzmZHzEvqMevzys/rQTzWUvkmbl0TDgaIKpZv QarIJ/aIsk9Gn+CmsphfHHqAFGJom93ElnN4wBHHYKRav4VSrq96mXpVuw6QXNXEdSghzMecdak /xNSYRxOZvAjMPGrEYkdNPsAc076o4MwmS1s= X-Received: by 2002:a9d:7d8c:0:b0:7e9:dd46:b9f8 with SMTP id 46e09a7af769-7ee471926ebmr889179a34.15.1784813606315; Thu, 23 Jul 2026 06:33:26 -0700 (PDT) X-Received: by 2002:a9d:7d8c:0:b0:7e9:dd46:b9f8 with SMTP id 46e09a7af769-7ee471926ebmr889159a34.15.1784813605732; Thu, 23 Jul 2026 06:33:25 -0700 (PDT) Received: from [10.219.57.229] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ee2a0b3803sm3569083a34.21.2026.07.23.06.33.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 06:33:25 -0700 (PDT) Message-ID: <0ee2667f-db43-4e5a-9b4d-2c2404d4ae5b@oss.qualcomm.com> Date: Thu, 23 Jul 2026 19:03:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 06/13] dt-bindings: arm: Document reboot mode magic To: Rob Herring Cc: Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , mfd@lists.linux.dev, Srinivas Kandagatla References: <20260714-arm-psci-system_reset2-vendor-reboots-v23-0-e7453c548c21@oss.qualcomm.com> <20260714-arm-psci-system_reset2-vendor-reboots-v23-6-e7453c548c21@oss.qualcomm.com> <20260722171108.GA1097879-robh@kernel.org> Content-Language: en-US From: Shivendra Pratap In-Reply-To: <20260722171108.GA1097879-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 7hfMB9kZW9mp9_-j5wgWpER3OEahk9O0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEzMyBTYWx0ZWRfXzJ71LMxu0lTb grY/2c/SKKgVdNYHP4d2CRhWjByRjFFZpWyvjKnIseqXaeXJ9IVD/kFGvrmnLk36o58tuhaebWQ TCUyAmdJaqGyV34091J18faOg8ul3h0= X-Authority-Analysis: v=2.4 cv=S7DpBosP c=1 sm=1 tr=0 ts=6a621827 cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=PV7ZYYKFBiq-RxTmBQMA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-GUID: 7hfMB9kZW9mp9_-j5wgWpER3OEahk9O0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEzMyBTYWx0ZWRfX9Zzt8xncE4pc XxMgtaDRy/WLg7WZXyg3sv9pT5epFfgTU8AAdi9d3wNJ3zFtkAP8gFimEB4SgjK8975weTovb7f SBol1vzoSTo7ymqz92jau0ueeGlbPxU1dPTRfDblryXP4VepOONAw0IKTv2LYCZ/+fY5rVsN6qR du74tSXcafDCPBBi381VOhuSWMQ9MRCkYwup8iT88cZrqr1V0HzoTHbm6XJ35Af8Va81NqFZ3Ul Ic/j/mWX9JKzZcWj3ikhKNm9vvjTyuQlBAgkTM5Budf/uAxmk0n/2wqslrV+F5oXaVztZZxxY71 td/DQJVpw0cXxx6L56T2hZVCAVE2VVdcOH+PcFDZnZBTpR1hloZrcJ/a/vpz16hjqNMYLk73GUn 2h8XtL41xELsUJ0SwVI/7YBR2JfxTu1FdEAMfZ4+8Qjwd/x7etfyy3m/Pe44WZkjAk0ynm6SbbM p1uDVHVn/oEBdpJsg2Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_04,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230133 On 22-07-2026 22:41, Rob Herring wrote: > On Tue, Jul 14, 2026 at 10:46:34PM +0530, Shivendra Pratap wrote: >> Add bindings to describe vendor-specific reboot modes. Values here >> correspond to valid parameters to vendor-specific reset types in PSCI >> SYSTEM_RESET2 call. >> >> Signed-off-by: Shivendra Pratap >> --- >> Documentation/devicetree/bindings/arm/psci.yaml | 54 +++++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml >> index 6e2e0c551841..11b90e8affb3 100644 >> --- a/Documentation/devicetree/bindings/arm/psci.yaml >> +++ b/Documentation/devicetree/bindings/arm/psci.yaml >> @@ -98,6 +98,37 @@ properties: >> [1] Kernel documentation - ARM idle states bindings >> Documentation/devicetree/bindings/cpu/idle-states.yaml >> >> + reboot-mode: >> + type: object >> + $ref: /schemas/power/reset/reboot-mode.yaml# >> + additionalProperties: false >> + properties: >> + # "mode-normal" is just SYSTEM_RESET >> + mode-normal: false >> + patternProperties: >> + "^mode-.*$": > > Since your example violates naming rules: > > "^mode-[a-z0-9]+$" > >> + minItems: 1 >> + maxItems: 3 >> + items: >> + - description: arg1 (vendor-specific SYSTEM_RESET2 reset_type) >> + minimum: 0x80000000 >> + - description: arg2 (cookie_lo in 2-cell form, cookie_hi in 3-cell form) >> + - description: arg3 (cookie_lo in 3-cell form) >> + description: | >> + Describes a PSCI SYSTEM_RESET2 vendor-specific reset type. The string >> + after "mode-" maps a reboot mode to a vendor-specific reset. >> + A vendor-specific reset takes two arguments, a 32-bit reset_type and a >> + 64-bit cookie. The arguments are encoded as up to three 32-bit cells. >> + Each mode property is encoded as mode-xxx = , >> + where: >> + - arg1 is reset_type and must be >= 0x80000000. >> + - In 2-cell form, arg2 is lower 32 bits of cookie. >> + - In 3-cell form, arg2 is high 32 bits of cookie >> + and arg3 is low 32 bits of cookie. >> + >> + All values should be provided as per the PSCI SYSTEM_RESET2 >> + specification. >> + >> patternProperties: >> "^power-domain-": >> $ref: /schemas/power/power-domain.yaml# >> @@ -137,6 +168,15 @@ allOf: >> required: >> - cpu_off >> - cpu_on >> + - if: >> + not: >> + properties: >> + compatible: >> + contains: >> + const: arm,psci-1.0 >> + then: >> + properties: >> + reboot-mode: false >> >> additionalProperties: false >> >> @@ -260,4 +300,18 @@ examples: >> domain-idle-states = <&cluster_ret>, <&cluster_pwrdn>; >> }; >> }; >> + >> + - |+ >> + >> + // Case 5: SYSTEM_RESET2 vendor resets >> + psci { >> + compatible = "arm,psci-1.0"; >> + method = "smc"; >> + >> + reboot-mode { >> + mode-edl = <0x80000000 0x00000001>; >> + mode-bootloader = <0x80010001 0x00000002>; >> + mode-needscookie_64 = <0x80000000 0x00000001 0x00000002>; > > Don't use '_' in property names. This is a W=2 warning. sure thanks. Will fix this. thanks, Shivendra