From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED93B22A4FC for ; Tue, 10 Feb 2026 09:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770716255; cv=none; b=m4si+3t4kQpgkkr5bgPzfl3wC9kr1M+cpD0cBhpPyToEyq4wXNnepfy33b7N8KBHQQiA5MNsEuvO2FN4Hda3ZGo7AJtpp2s0Ep25J5P43vEfbzJrapNldBe3t0/WlajOiksotHLstuV20E3znqC66qV3szDgg6Gvzp5o/kVAePY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770716255; c=relaxed/simple; bh=1pBCYnHFsgic841R37PpD+tVqAXLXnxjHHtGtlF68x0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=HbOE6XFFmJ8FQ88nktP1cZb0R66UTJfRfs/6V4qkv2QoXKIDWEMiE3AmnbnHFyQRH7l9rIxRfBc2muzDefmHWb5FCDdjcP7if2EUZKKts0gQr3ADqHYhVWVZg/DFpC48nRq71VBYsK6jVifjT/3RZ9fQIKobwtzB0T3Qw/ZUn9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HJC9lWKu; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HJC9lWKu" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4806dffc64cso46516425e9.1 for ; Tue, 10 Feb 2026 01:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770716252; x=1771321052; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1pBCYnHFsgic841R37PpD+tVqAXLXnxjHHtGtlF68x0=; b=HJC9lWKuwufyEOyXeojsEu7DUvK3XfzX733Do+b8W59uE6tPLVMoNNdsZu/stjza81 rwzIOpA/a1HC7giEUKjXEvS8j4QdoGW31l+/5r/IEe1ExBi+kKcrlaPBS1MVrRp8k1PR LhmWIm+zhlmp1EQwhHcLFwolMt3eA4GpU/uPPxDzJtgevawsahmKEUdHpMnxwqI5eotw EFa3HbE3B0Ij84z92nEYif3Dw+peJuucOywU04qgfFdMGXBttnNU6PsEfjdPnnwpqqzI 5x03SAiS37tZPTGC0M24QQF+Le+7QUXBi8skMCWi2begBhxdPCc2jrG3JorA8CEkeYaP Xbaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770716252; x=1771321052; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1pBCYnHFsgic841R37PpD+tVqAXLXnxjHHtGtlF68x0=; b=NRgBv2Cub2TMeVE581c9e99tCxEZPTaEidWWOhI6x+Evh0B+J/6AmrS503NUx82fOU hFCKDZHAXEhg/pQHiG6Us8lfGo4YEmhBXUMQCPIID1+xn1Bya14Zax+haVdjdFqw38Gb b+6dxH5aaWQKIk/O3eCUvcfgmyMr8wRmQg6hqQzL1r2QGWtL+7Mha/gXLKZMauQBRap7 eN+FAEidg7CSZLhTg91tneWpEEf9uDTh1C+Eyw2V5fNDi6T1NttjC91dYFctWQsz1dLX 4r0+zcVMeZEgKlS9KGB/lYTGPNfP6vfWqMYaZKjek7EWxI5b7jFY+sgU0K4oKBW1vG62 G/Eg== X-Gm-Message-State: AOJu0YzXmSz7KGxxKD54l0S9q3oDw7/ejWfpM0fXgq6uIgLa3Iq62nmh 3wC5y7soHr3SLpoT1DpOfAnmXA18ejJ6zU6SczJfuGusNFy9LxWZRj+E8uqEahsZfVg= X-Gm-Gg: AZuq6aJQWQhHQXWUCWF42lquRazjXO4p0ZphCNL5MlYG0Ev+Aexr+JxKsJHyVkWqg/+ Zt5hDCFwv3mgwh+7jMszYgS+4sl7yvHg///E5jCinccaSifgJm9qVdWJ2OVBjMcP+Lrv2WfIRdf ivIYravaCPTAYrH7uUN7/OdQXi/JAW34loXN9ehG1HognflBsDjy4sJWN8K6KLEqYDqYSjoXyAQ NIWrFJ4itJBJiRTE+PmqVtpmP0L+4FKoUQBnh3M41lKvp6tsKDYlATIak9G2JFvEOpHaIfuZksE ZM4evuyb179MXBtew9pWygxvNUjPMlc99NediPf9VB6hXZZI6k93czFDeQ5qFU9M7R+QjfKThGR RcPqjqtMnq+WgDVL0QVcfyQCha6iyBbC3qEFhCdAcw6tY0raR1dTe1y2zkOxo2yJFu3vZ/IR9gC +AV3NwTDwpiGU5QwoYVnhPRYqxZQXi0Q== X-Received: by 2002:a05:600c:6592:b0:47e:e7e5:ff32 with SMTP id 5b1f17b1804b1-483209c6dd4mr218940985e9.34.1770716252254; Tue, 10 Feb 2026 01:37:32 -0800 (PST) Received: from draszik.lan ([212.129.79.225]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d7e64b0sm57319715e9.11.2026.02.10.01.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 01:37:31 -0800 (PST) Message-ID: <0ee40d36397bfd4c04aea6ead07e42848203e9d6.camel@linaro.org> Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Dan Carpenter Date: Tue, 10 Feb 2026 09:37:59 +0000 In-Reply-To: <1e8ee0ae-a74d-418a-80b1-4d2379614548@kernel.org> References: <20260209-s2mpg1x-regulators-fixes-v1-0-ead348e64e14@linaro.org> <20260209-s2mpg1x-regulators-fixes-v1-1-ead348e64e14@linaro.org> <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org> <4f1b1d857c0ee17436cd61e97219f508bd89f917.camel@linaro.org> <1e8ee0ae-a74d-418a-80b1-4d2379614548@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Tue, 2026-02-10 at 08:28 +0100, Krzysztof Kozlowski wrote: > On 10/02/2026 06:59, Andr=C3=A9 Draszik wrote: > > Hi Krzysztof, > >=20 > > On Mon, 2026-02-09 at 17:09 +0100, Krzysztof Kozlowski wrote: > > > On 09/02/2026 16:07, Andr=C3=A9 Draszik wrote: > > > > The sanity checks being removed in this commit are useless as earli= er > > > > code checks for out-of-bounds conditions already. They also are > > > > incorrect (as they're off-by-one). > > > >=20 > > > > Simply remove this incorrect code. > > > >=20 > > > > No functional change. > > >=20 > > > If they are incorrect then how it could be "no functional change"? To= me > > > original code looks buggy and this is a fix. Fix must have functional > > > change... > >=20 > > Earlier code already checks for all conditions, including all error cas= es. > > So the code being removed here has no effect, as any potential error it > > could catch will already have been caught by earlier code. Removing it > > therefore doesn't change behaviour or functionality. > >=20 > > I can reword to 'incomplete test' instead of 'incorrect code' if you th= ink > > that's more clear? >=20 > Perhaps you should mention which "one" in off-by-one that it has no impac= t. OK. > I also wonder why you left the second - ext_control_s2mpg11 - untouched. Could you point me to it please? I'm not sure I see what you mean. Cheers, Andre'