From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCD8C7618E for ; Mon, 24 Apr 2023 22:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232827AbjDXW1I (ORCPT ); Mon, 24 Apr 2023 18:27:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjDXW1F (ORCPT ); Mon, 24 Apr 2023 18:27:05 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E60D3A5CC; Mon, 24 Apr 2023 15:26:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E4E74B3; Mon, 24 Apr 2023 15:27:21 -0700 (PDT) Received: from [10.57.56.16] (unknown [10.57.56.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D3C43F64C; Mon, 24 Apr 2023 15:26:35 -0700 (PDT) Message-ID: <0ee62e42-2a9d-789c-86ad-8f92b08b31ac@arm.com> Date: Mon, 24 Apr 2023 23:26:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] coresight: core: Add coresight name support To: Jinlong Mao , Mathieu Poirier , Mike Leach , Leo Yan , Alexander Shishkin , Rob Herring , Sudeep Holla Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Hao Zhang References: <20230208110716.18321-1-quic_jinlmao@quicinc.com> <3c105c79-f523-653e-5154-7ba641e51a96@arm.com> <180a66b1-6996-c705-5d8a-0a69ce0353d7@quicinc.com> <619818ad-71cb-6c07-bcae-ea9398f08878@arm.com> <6b976d2b-3c78-96e4-bf35-3ef88828a9dd@quicinc.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/04/2023 14:42, Jinlong Mao wrote: > On 3/17/2023 10:25 PM, Suzuki K Poulose wrote: > >> On 17/03/2023 05:34, Jinlong Mao wrote: >>> >>> On 3/13/2023 5:16 PM, Suzuki K Poulose wrote: >>>> Cc: Rob >>>> >>>> On 01/03/2023 15:11, Jinlong Mao wrote: >>>>> Hi Suzuki, >>>>> >>>>> On 2/9/2023 10:16 AM, Jinlong Mao wrote: >>>>>> >>>>>> On 2/8/2023 10:26 PM, Suzuki K Poulose wrote: >>>>>>> On 08/02/2023 11:07, Mao Jinlong wrote: >>>>>>>> Apart from STM and ETM sources, there will be more sources added to >>>>>>>> coresight components. For example, there are over 10 TPDM sources. >>>>>>>> Add coresight name support for custom names which will be >>>>>>>> easy to identify the source. >>>>>>>> >>>>>>> >>>>>>> As we have previously discussed, please don't make this a generic >>>>>>> code change. If your device has a "specifici" name, use that for >>>>>>> allocating in the driver and leave the core code alone. >>>>>>> >>>>>>> Suzuki >>>>>>> >>>>>> Hi Suzuki, >>>>>> >>>>>> Not only for TPDMs. There could be dozens of CTI devices. >>>>>> It is hard for user to know which CTI device it is with current >>>>>> names. >>>>>> >>>>>> Thanks >>>>>> Jinlong Mao >>>>> >>>>> The coresight name support is applicable to CTI and TPDM devices. >>>>> This is a generic change for the source which has dozens of devices. >>>> >>>> I took a look at the CTI situation and I agree that the situation >>>> is a bit tricky. The CTI could be connected to multiple devices, >>>> some of them may not be even CoreSight devices. Given there could >>>> be numerous of them, we need some way to make the "devices" naming >>>> a bit more intuitive. >>>> >>>> Before we go ahead and add something specific to coresight, I would >>>> like to see if there is a generic property. Ideally, the "labels" >>>> in the DTS sources would have been an ideal choice, but can't >>>> see how that is available in the FDT. >>>> >>>> Suzuki >>> Hi Suzuki, >>> >>> Shall we use the full_name of device_node struct as coresight >>> component's name ? >>> >>>    struct device_node { >>>      const char *name; >>>      phandle phandle; >>> *    const char *full_name; >>> >>> *For component below, the full_name will be "coresight-tpdm-ipcc". >>> * >>> **coresight-tpdm-ipcc* { >> >> Does that go against the convention of naming the DT nodes ? >> I am not sure. Also, we would need a way to solve this for ACPI too. >> >> Suzuki > Hi Suzuki, > > Does ACPI device also use "coresight_alloc_device_name" to get the > device's name ? All driver code is common for both DT & ACPI. The only difference is the coresight_get_platform_data() which uses DT vs ACPI information and populates the platform_data. See coresight-platform.c. Suzuki