From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7C375028C for ; Tue, 21 Jan 2025 16:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737476246; cv=none; b=MKJ+DyW0rtVmDH6nN/BIFou6K6ixK2OtTKFOcZ6hxDdxgtAduROd7IEh8RDtrnnogadBfVg/pNsP6/4JNDeqyBLUQvBdrfdRbB3yxS30DTshxReFMPiQNQBeqcb8I+BxMtlHaRNZIJVI7bxNiW2juWTicCbchvL0fIzI3ttwPBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737476246; c=relaxed/simple; bh=Dghs9siubkgtkaZ3i0SC7IvTxG8AoPnGvWCxTUvupNE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SC6NgM16E4OQTFDb+R3ZcYDD9t/eFHOoMRpckeV9hy4iWZyfbAYvsAI9e1nmIa896uWWOSaT58PGvyZu5fIDOpyTVctIII7hcAFBp09hwF3hY6B+xMRqq+ffnGlB9plKv9fnWCuYhl/kHn0lTSQiy003tsyKzoQB1OUp/R58E3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iCT1BKHx; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iCT1BKHx" Message-ID: <0ee72316-11e1-4930-8c49-92db8d148b8a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737476226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pohg729KqjlON/Y3qVQcQ7ga5GWM9jcQEdryp7KPBOQ=; b=iCT1BKHxy6GTT5TGP9OPEs5MRsWamD58cdpjuWiozNK06H7Xhzzt6y+XTjQCUiKS2AQ5sI sJTZA4n/kv8Q4XFqDqdQK1BdSl+x8ND896elX4zKQGhQxhbTJ4l+j4xvEAiLKm9KFXOhkT WFwYDIsCzpvhLGkMqSqqh2ItH2plyB0= Date: Tue, 21 Jan 2025 11:17:03 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 5/7] spi: zynqmp-gqspi: Split the bus To: Mark Brown Cc: "Mahapatra, Amit Kumar" , "Simek, Michal" , "linux-spi@vger.kernel.org" , Jinjie Ruan , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Miquel Raynal , "amitrkcian2002@gmail.com" , "git (AMD-Xilinx)" References: <20250116232118.2694169-1-sean.anderson@linux.dev> <20250116232118.2694169-6-sean.anderson@linux.dev> <1f7cb52d-31a4-458c-9b81-b46bf56fd8a8@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/21/25 11:01, Mark Brown wrote: > On Tue, Jan 21, 2025 at 10:53:53AM -0500, Sean Anderson wrote: >> On 1/21/25 08:19, Mahapatra, Amit Kumar wrote: > >> > IMHO, restricting users to fixed names is not ideal. A better approach would be to >> > introduce a Device Tree (DT) property for the bus number and select the bus >> > accordingly. > >> Why? It's not an artificial restriction; it reflects the hardware. And this is how >> SPI busses are typically represented. If you have two SPI busses, there should be >> two devicetree nodes. > > Perhaps the thing is more that the buses are named instead of numbered? Well, we could number them, but it's not like they have different addresses in memory. They use all the same registers except for a bit in the genfifo. So it doesn't make sense to do address translation (e.g. with reg/ranges). As for the names, these are the names used by the documentation, as well as the exising driver. There are some references to SPI0/SPI1, but there are more to upper/lower. If you want to bikeshed spi-0/spi-1 instead of spi-lower/spi-upper, be my guest. --Sean