From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: fabricioakio@gmail.com, Georgi Djakov <djakov@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexey Minnekhanov <alexeymin@postmarketos.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: qcom: sdm660: Enable keep_alive and sync_state
Date: Mon, 12 Oct 2026 18:18:39 +0200 [thread overview]
Message-ID: <0ee83fd8-dcc2-4666-a864-de52fdef1c7f@oss.qualcomm.com> (raw)
In-Reply-To: <20261009-sdm660-icc-sync-state-v1-1-77b8d2501cb2@gmail.com>
On 10/9/26 10:45 PM, Fabricio Akio via B4 Relay wrote:
> From: Fabricio Akio <fabricioakio@gmail.com>
>
> The interconnect core starts every node at INT_MAX and only lowers it in
> icc_sync_state(), which this driver never hooks up. Every bus therefore
> stays at its maximum rate, in the active and the sleep set.
>
> Hook up icc_sync_state(). Releasing those votes also drops buses that no
> driver votes for, so enable keep_alive on the providers with a bus clock,
> as QCM2290 does: it keeps a minimum active-set vote and leaves the sleep
> set free.
>
> On a Motorola Moto X4 (SDM630) with the screen off, this takes the
> battery current from 117 mA to 68 mA.
>
> Fixes: f80a1d414328 ("interconnect: qcom: Add SDM660 interconnect provider driver")
> Signed-off-by: Fabricio Akio <fabricioakio@gmail.com>
> ---
None should be necessary on 660, except on bus_0 / RPM_CNOC_PERIPH_CLK,
which is not associated with any interconnect master on this platform
(so it will actually get disabled through clock cleanup!)
Konrad
next prev parent reply other threads:[~2026-10-12 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 20:45 Fabricio Akio via B4 Relay
2026-10-09 23:07 ` Dmitry Baryshkov
2026-10-12 16:18 ` Konrad Dybcio [this message]
2026-10-12 20:57 ` Fabricio Akio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee83fd8-dcc2-4666-a864-de52fdef1c7f@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=djakov@kernel.org \
--cc=fabricioakio@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®