From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EAC447ACF4 for ; Tue, 22 Sep 2026 18:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790100571; cv=none; b=NHV8ex+K8BcWt408iSVw+xPeBLOvOI3z6F1Iw0gzQ39d2dIz79lHwjxz3xKvM3TDMHe2/mM9oDFqgYVnqydj4zDT5cRiwzq2nB0Ej6k3rB0cInltuhNhZnhZZd4pYt/bbq2VwoSkLcBZNWfQEfpPeQzOy1XNDLr7V7AdRrCNI5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790100571; c=relaxed/simple; bh=VqkBZkDaJiRDdADJ8Lxaecq3PYa0YExXfSjFPd9R/Fw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ttbDe0TkpNlCEpNxbEu8n1IpCIkv7ynqL1uJzxvJvVBrc8cDvyG2R7voMd4NUp+oRLxn6dpk8/YZwTgg+mYPkBVmq7tiTqh7C2FMIHggDEehFfvPaS4pPegaIcMkQyDZspCWKDyWKHTfYYwzWL6LebTWXghyYkzarl6eYv3eaz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UqQowyh+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RLIit7ib; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UqQowyh+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RLIit7ib" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68MI6wiW1873475 for ; Tue, 22 Sep 2026 18:09:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OUYfzTv8ACTsYRs+CfRzQrQLm7ATPQuahpCau7u+jJY=; b=UqQowyh+tpao22yu zk+Hbc1nl42ZY+WUJb/SGORwpESizUkz3N+XG2KEzcX6eaOMt1tJvML51Ko55FOs /oOrL7lOStXMJs4yt9b+GQEMSS16oHP05MwmEUn2H7NoiY/bnrJ0SdCrTLm1tq1b t7qToka4SmSnFTkNJSzNT3DctekjReYyEOcPcJKGnA3+rpDYSKKorkJEIwxVTdGF pOtlIItLEXEvDPqXTikKK3tRek9UqsqTUCmWRwr6dntck5Ki9gBmBoHc2DYJ3OmD 5xuu9yENPmZ1PEkatFJOZLPYIZnGFRu2JY7Qq1KD9hg3xeR291HxsPmDHm8IwHsY 5xMuMw== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4guqk4t9fc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 22 Sep 2026 18:09:29 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-313d1015161so219213eec.1 for ; Tue, 22 Sep 2026 11:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790100569; x=1790705369; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OUYfzTv8ACTsYRs+CfRzQrQLm7ATPQuahpCau7u+jJY=; b=RLIit7ibw/isKb6VFqbxIYXnZwtBVV0WVXBBh9k44AgVRp/3r0g6cQ1XjBmfBsnyze IH1p0qkfQBbljTbm0PW1IKY46+IL9T27Eclu6Z0XQAPgO/uQtywh4phWadagU02/WaJr zfGA7teaFhHfNzZU6C1ftvIzXcgXkknVAVE+T66E19WBWzLL48t0mhxL679lHGKFJGh1 IpqsYjFKgYD6u/5NW9uUHJSr772qZRt4Jmnwq5j2Vfn4tMGLLVShAXbZfb+gwctJLPVs HXmBGoJYnivlDNa+oGbSdU3k1lgbJw+Oy0uFUsdilC3/CjVtsCYXWVIQ94m3uEyy1tfR TqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790100569; x=1790705369; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OUYfzTv8ACTsYRs+CfRzQrQLm7ATPQuahpCau7u+jJY=; b=y5JcXeF3CdQKTMih/G8tUx0ViX+cCKzUcV8DuJDCYPhVbCc84ewb5ljw5lVMQ7gCFi gSo+alZ92f2ogKC4+e04RsSoa0SGWFrIrF7mkUMX1c5pRYa7JTt93dXaYo79GSA9/XAD jmHRhxEM4EjzBRTXVyBmx3zcUcAuDJqWxa0g0V+oSpoesJ/wHPsnfd6Wrx9l4JVxfzpO 9rrwUVTvjGPl/b74/fUT7XI6PGJ931EIJ9CXuDCBMoWIFi+3WZ/BPwZvDOMMnCKf85bz 4ShZoba9v59nAJzVNDsuarCgJUkR4st3uea6OJW1sRYDBlY2vUhinsFKp5R2TW/zHRQF 3mNw== X-Forwarded-Encrypted: i=1; AKwUvByRzV8SL28f2UD1dpZMa7QjJkC9kfyLpRKpP0zniGjACqVJ50vBfwk31JKxcwRKAV9MfLxC0nSk0JQ4MAA=@vger.kernel.org X-Gm-Message-State: AFuF++mW8CS7aUMUpBA9nNy+FOsjUGf9hVzTdssjMJjnXLLucoQMDINt qo2bTQg8MfZXvw43pJmqXwDfzZa1f3hlIvP06BPhhSZ7azd2UrfPMQebeXtoY0s/ZmLulsA1DNl YhZKNYGvqPRSQdMJKmH+i7HE0rICPFd0UotuvPiI1tIo+Zm7QD5tiV43UdqlzSqci0Ts= X-Gm-Gg: AYBFou3b6zj8wa35fes0jDvhsD7/mfGpb9bFlIUe6adQGJWPxYNw110rVU2RzpW1+pw qnfSjgSFAchL8+VIHxYtcsSaKJb6hLbIItLNdF8wU1s6zSAMjRRmWE4sBtbjeaMM8g6D/xsjSy7 Ve44qR2pK9y7nTx/xcHu5kv3AT7M26QHtMWQay7il1zCOLu70HQC/Nox9tgY+JdoVdrS4znCQfG CH25wxBD7gC5dn/ga3sc5vt2tGDhqd7ffTOn4i/2JBWIfMDgosWL3djUw+NrYXEZ0exP6eZXpAj sQB5RvyL7fYV+7aBuotDklj/KTo9aeiTPqGeuaCbvNMNYPJztjfxz3kSPNfeRDFTY17igGICYB2 HgNktTe/SXrtpU7lcyNyoBKI49NSwT21lbw== X-Received: by 2002:a05:7301:2e34:b0:33e:6812:29d7 with SMTP id 5a478bee46e88-33e8d9ce170mr70662eec.19.1790100568464; Tue, 22 Sep 2026 11:09:28 -0700 (PDT) X-Received: by 2002:a05:7301:2e34:b0:33e:6812:29d7 with SMTP id 5a478bee46e88-33e8d9ce170mr70631eec.19.1790100567834; Tue, 22 Sep 2026 11:09:27 -0700 (PDT) Received: from [192.168.0.172] ([183.83.143.245]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e95c7d003sm7215eec.9.2026.09.22.11.09.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2026 11:09:27 -0700 (PDT) Message-ID: <0eea448d-da5c-434a-909f-b50cc7c57754@oss.qualcomm.com> Date: Tue, 22 Sep 2026 23:39:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 3/9] media: iris: Replace enum-indexed clock and power domain tables with per-block structures To: Vishnu Reddy , Bryan O'Donoghue , Dikshita Agarwal , Abhinav Kumar , Dmitry Baryshkov , Mauro Carvalho Chehab , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260917-glymur-v11-0-e0c8bc914742@oss.qualcomm.com> <20260917-glymur-v11-3-e0c8bc914742@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260917-glymur-v11-3-e0c8bc914742@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIyMDI2NSBTYWx0ZWRfX4cbLNZLjLorM odOxJXLV6Pj2/5uXIE4W8bM9EHihDUhuJ6aQHPlNg64/jx6vHKfh3XQuWZZDFdxGtaCSiNldEan 7kYR3v2vGYRIgtXX92QM+bFP3KB2C78MlBYlSH37ONHqaeh+O/gNQuuPnQAuBylYR92YSIMd4Pr yd45vSlgCeRt6u442LgyLXq9JCkSvFY42tp+T3eeE+7G/L11AryTMDNs3OSp50FOpyQ3s9PoHMY aH+ZzNMmL/4UAzA1FhUlbl090E7wIkIsTc7NI93xIIbnFNAdzefTxgef9RoygsBGMX+99axTknH mOhylcJR0KLNC3NyXFx1nA98HwyKLw3IV8vyfkVfg/LpJIdwOFPIcsIVgKoSyuuzACz1wapLGi6 GPbkHOqAdSyxjzn1eKHYlHAC7UHGNMcD6XV51k5ieAsjOVa52M+j26H8e+EczzpqSRVGaBkR5O0 ioLik0YuywWkBerV4cA== X-Proofpoint-GUID: Ha41J6OPgVjYLT_wB1cnmdkpUNIMSmoc X-Proofpoint-ORIG-GUID: Ha41J6OPgVjYLT_wB1cnmdkpUNIMSmoc X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIyMDI2NSBTYWx0ZWRfX6jFfDDcQn3XY B3Z/LioiNaqb4Sm+ocew+Eg9QIHjElJ4i4VXsrJEACtzSKohjk7vJ7NFi4n7+boMuNSlqw2YH5R TN2YL314CWoycjiZ1aAHtsCYkutlQQM= X-Authority-Analysis: v=2.4 cv=XrVvqlF9 c=1 sm=1 tr=0 ts=6ab2c459 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=d+GKXRUq2vCLDWIvqUj1TA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=cQsnMm6kD37X6GfbhGIA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-22_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609220265 On 9/17/2026 10:30 AM, Vishnu Reddy wrote: > As new platforms are added, the platform_clk_type and > platform_pm_domain_type enums keep growing. Every new clock or > power domain requires a new enum entry, and every enable/disable > path has to loop through the clock table to find the right clock > by enum value, adding overhead and boilerplate on each path. > The enum index space is also shared across all hardware blocks. > On the Glymur platform, the VPP0 index for VPU4x and the VCODEC1 > index clash, making it error-prone to extend support without > breaking existing platforms. > Replace the flat tables and enum-based lookups with > iris_power_domain, which bundles a power domain device and its > associated clocks together per hardware block. Platform data > describes each block via iris_power_domain_data, and the enable > and disable helpers operate directly on an iris_power_domain > instance, removing the need for any index lookup at runtime. > > Signed-off-by: Vishnu Reddy > --- > drivers/media/platform/qcom/iris/iris_core.h | 23 +++- > .../platform/qcom/iris/iris_platform_common.h | 41 ++---- > .../platform/qcom/iris/iris_platform_sc7280.h | 28 ++++- > .../platform/qcom/iris/iris_platform_sm8250.h | 26 +++- > .../platform/qcom/iris/iris_platform_sm8550.h | 26 +++- > .../platform/qcom/iris/iris_platform_sm8750.h | 29 +++-- > .../media/platform/qcom/iris/iris_platform_vpu2.c | 20 +-- > .../media/platform/qcom/iris/iris_platform_vpu3x.c | 32 ++--- > .../platform/qcom/iris/iris_platform_x1p42100.h | 27 +++- > drivers/media/platform/qcom/iris/iris_probe.c | 137 +++++++++++++++++++-- > drivers/media/platform/qcom/iris/iris_resources.c | 81 ++++++------ > drivers/media/platform/qcom/iris/iris_resources.h | 8 +- > drivers/media/platform/qcom/iris/iris_vpu3x.c | 37 +----- > drivers/media/platform/qcom/iris/iris_vpu4x.c | 137 +++------------------ > drivers/media/platform/qcom/iris/iris_vpu_common.c | 98 ++------------- > 15 files changed, 347 insertions(+), 403 deletions(-) Reviewed-by: Vikash Garodia