From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CAF44DB6D for ; Fri, 21 Aug 2026 09:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787305247; cv=none; b=RgYnbmeYVcMIedNDuGXcwz+yxIsPi2LMwnplIXUQLkhBd+KuqzMLb5Ekl8sx9oaPt89uVve+3DtR+HK1mWcKXB1G+z9P0hmAAyfytmXeCwRKWtvRYEOvqArYLYSj76gy1jYsGwU/YsVmWAaVkMAVvTPoescrbnRUtk0Iw6gyynQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787305247; c=relaxed/simple; bh=rje9kgYuMA1aq3fzUJvJvQXzw+bsrsWwQiF7njuvW4M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DF+z2LP2dMw1jElIIqTX+RslYuqmc7OElBOoDJ6TJiI8JMJv1yy4u0NdKFTfDbs2k2F4YwZAL3PRm9/u5oO2M4/HbiQptWdv/+nVs1A4471R0QrgbnZh7WucTgMX8p2MudjWKmTel49wO6glsiTcJ64Zc5xESHpVWqq7PvYa8tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SP+5iXG4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KOLO0zc7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SP+5iXG4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KOLO0zc7" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L9Live1983083 for ; Fri, 21 Aug 2026 09:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8XxJnaSrtt5CjTwOdeQ9vMPi4AA9i6v5V+T6kkVelS4=; b=SP+5iXG4hAssiTAz PHDJN/6NeDUx6Dk2ZAH4KObRyveAIuauE8XGN0VItQx/1J8j+C6HhhJ3WD14oNlF 4qA0Aqwk/Z9cnoFtixe1Vd/J2QaovktCNrSQvWw6aRvTz6Tp8FXKgHyadtJH1meU H2I1M1AJlrlSMrWIqxptL/UWlDCJukTCyI9mt+k23jHOek/qRxvhqWCHI62WfxxX EdPpcFHmQgGQFb/jPQ/QmQ9x6c+U7/Iy9wpYW7dvI7TQsjrsA9rZH/3i/pM37068 3vWTF8JdGbTdpXdBP1sfRa5/rzGp2ivtC79Kj/WWarFsftwL7g7lwl7UcW9HUeoY cfcp/g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6cdshpny-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 09:40:40 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38f283baf1fso1134285a91.3 for ; Fri, 21 Aug 2026 02:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787305240; x=1787910040; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8XxJnaSrtt5CjTwOdeQ9vMPi4AA9i6v5V+T6kkVelS4=; b=KOLO0zc7d26viJ+TNTkpWFbOuDoB+08dAMtToKJcO/Xfkhal4587cqYRnXAQvXVHY7 Ry1jV+s2AOtTGAD8eofwrwUXrWrkLPQWa9NdqD4KHA92rY+1FP6HV8t3EJnOy5pkuk0m /1qdUCL6bPUT2cUoBaSwJGBT2AHZgAOq6boDonwQRwzrSEh66f6yKQ3ZV8Y1Qzvc7nAR IH6/ndY5ALghypAYIAB2wLhyZEbEfCOgAMcnZfYms/wTcl8M8j9jA7ybY7cJtV0iwpKn rx77d4ziHVcQuEXPPlqXU0ZyB1WQzpoSu7ao+iMucgtD5RNiwQin7YW4Ixi92u6S7Orb b7ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787305240; x=1787910040; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8XxJnaSrtt5CjTwOdeQ9vMPi4AA9i6v5V+T6kkVelS4=; b=paf6l4Uv+29YYCkbuBOkpPH4OY1deTwwYQ7ZGFilm/szNtsM1Wp50mEg/CJDgBr/Bz jnM8MSRUgmU3N7+MQkk6PJNvf4GmXt1bPSp5drYc98AqvZIS8xPElyGN+DtWeFq+aiz7 ZFDH5r0Gamn9Dex7fcFw8x7OMDFT9j/HbbTd6TKCeQ6IZfZmuwflKmL+OzRfgkthBvDw dyNy1MVcMLhrDSu+qT5xIejzQoqMwi16nsI7N4d1WSHHXKt0lhrfVlIZj2yWOfdjcpGD uIS/nMrsG6TnlYf+SxzzkWtBdXXy8uTkZMSH/3eczWta7WdsNtreFi+6swH0+HIT5chf Zpnw== X-Forwarded-Encrypted: i=1; AHgh+Rpl6JWyVbj1UtsxNevwfG29WY5G2BLpHU5JSuKgsmcs24T7ueUtNev4QkctpyEK9cd95ZMmImY1J4RxKVw=@vger.kernel.org X-Gm-Message-State: AFuF++le4w18NxBKvh+qmKvHM/u2RJE3Q3dhDfrJx4u9fm6HRxPwoO8N T1zwMlUFymbpz0s5hu4aO9aGkaFGR2ThoamvTaHmRcQG2GW49zGBfOTCPPiW2c8JLVri0hQ3M4E Ruy7D6hP63u646blE+qbrd/imVRCtupcIAIGfLjYTajbSBL2zFY/Bqo79NOy+iawxjbs= X-Gm-Gg: AR+sD10DlR6tk1jhQj1C3SdvSrZqykGHVhjY1h4LGdM5pemQEebO9B/RtulRr+gd/1s y7FihBUYVsi0PoBlTt2/Jo5jjqgBbR6Ed0PemmdlwAWqpH0P3aJQ2kQQOc9fWEbXfj1sU0b40wB BHtuiLCi/k7KZQ14maTEoXGZ6hH9hukRvp6FYMOLaeBrFb8Jz6N9Uc0N0U8PdZezi6dfKK4r1g9 j3UUW7f/vDUKMmRoFVlIbohfJncTxFN3UHHM/TiYYDK9AzBlNPx0P6npqKE34YTYAgVAv9INlyp Nus4BSO3XQl3A7b7wTbhOCSGJvJb8SnBTy6AYbTB+575eOrogorDkHnDR0t+ulVkusdTsEKWlU0 F+nVzsMH/tjINJUoQt+0nGSXaVr2vuJFlRs4ohPDUOrHhk9N3IRxvg2TwfI7dr6bd/7cQHNc= X-Received: by 2002:a17:90a:c88b:b0:38e:6a44:671b with SMTP id 98e67ed59e1d1-395c2f4b17emr10746519a91.0.1787305239783; Fri, 21 Aug 2026 02:40:39 -0700 (PDT) X-Received: by 2002:a17:90a:c88b:b0:38e:6a44:671b with SMTP id 98e67ed59e1d1-395c2f4b17emr10746426a91.0.1787305239331; Fri, 21 Aug 2026 02:40:39 -0700 (PDT) Received: from [10.133.33.51] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c48ffd70sm2407392a91.10.2026.08.21.02.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 02:40:38 -0700 (PDT) Message-ID: <0eebafb4-951d-4360-b514-22ed24078611@oss.qualcomm.com> Date: Fri, 21 Aug 2026 17:40:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpufreq: airoha: fix probe failure with correct error check To: Christian Marangi , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Schwierzeck , stable@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260821084541.139703-1-ansuelsmth@gmail.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260821084541.139703-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 7Cp0tXgyHAqOcX3ao4OOdoUNU85Giphb X-Proofpoint-GUID: 7Cp0tXgyHAqOcX3ao4OOdoUNU85Giphb X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA3MSBTYWx0ZWRfX1qBOwPeZ7V49 rMQDi7Z+HJfRfe+mGMQ27UTTKkpUZOsn2OfiPdePwafZRBoytM+hraVnLtFpym3xYrIqM0OFm2t Aa/8d763RACvikJ9JeuuEuykeOxItYI= X-Authority-Analysis: v=2.4 cv=RN2D2Yi+ c=1 sm=1 tr=0 ts=6a881d18 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=lLE1e_VV37mLdjPsc6kA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA3MSBTYWx0ZWRfX0uQLHT6R7cIW Rurq/vE80QZTS1AUDmCPLtxDWWIU/Vss5GBGAJgRg9JZimroxCNX+OeESX0oPr/HoixNGznFT4B gN3TrRbg58j20OIbmSYY9RpOH0Fp+VDOphCZB+Zf8p0ZYfe8o0ORqkJSfTll7TXMC5/HdTl4fKh ED2/KHutDA6B0E/OAzCxOwe40Z8Dvc53NSLe71wGJ8X0yOdZ4I67/dG2uOX4800O5mNcNXBWPGq WKmzxntLTlCfxOEEGneCX7cVDyiPxc0O7v+DP0jt6TV1Lxqcwl3I7Ki9OxI1gO5hU6gfnJkkpGQ SZgZhRb+9nNcEk+L19Y7jJF8CpQg9x4lu01GjKrn72c083Bk/T0JKmUuh3gj1vBaVWl4c+YicLg 012NI3Cla1oitKPlqWsTyS9Im2WAqI75x0hnTT2YksMXXvXego+wu7Xhi+jH8S3rbUH/jPE0zmm 7qeEbTGIFOK19XmYCcQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_03,2026-08-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210071 On 8/21/2026 4:45 PM, Christian Marangi wrote: > From: Daniel Schwierzeck > > dev_pm_domain_attach_list() returns the number of attached PM domains > on success (a positive count), or a negative error code on failure. > The driver checks "if (ret)" which treats a successful attachment of > one or more PM domains as an error, causing the probe to fail with > return code 1. > > Fix by checking "if (ret < 0)" like all other users of this API. > > Cc: stable@vger.kernel.org > Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver") > Signed-off-by: Daniel Schwierzeck > Signed-off-by: Christian Marangi Reviewed-by: Zhongqiu Han > --- > drivers/cpufreq/airoha-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/airoha-cpufreq.c b/drivers/cpufreq/airoha-cpufreq.c > index 3e7770860d13..8283c528d0c1 100644 > --- a/drivers/cpufreq/airoha-cpufreq.c > +++ b/drivers/cpufreq/airoha-cpufreq.c > @@ -64,7 +64,7 @@ static int airoha_cpufreq_probe(struct platform_device *pdev) > /* Attach PM for OPP */ > ret = dev_pm_domain_attach_list(cpu_dev, &attach_data, > &priv->pd_list); > - if (ret) > + if (ret < 0) > goto clear_opp_config; > > cpufreq_dt = platform_device_register_simple("cpufreq-dt", -1, NULL, 0); -- Thx and BRs, Zhongqiu Han