From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB9A3379EC4 for ; Thu, 16 Apr 2026 06:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776321298; cv=none; b=o5wpFghcT1iOVZA0Nj8y/QpIJMaHoihEcA/BZ6kA+ESdFSh9jTtqfhjaMC9O9XycZNS/8M8JuGvcKWD9iK4dy8gr/fmNh3xw7MT2X04iz1uUwg2RTnUAxBci5uO6JK7LuCwnQalaXNpGOF7sK4BackzjuwgxuPJ5NCPQPqUTQC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776321298; c=relaxed/simple; bh=ziInnYwfR3yWZrCQOeoQ1nSAx4XZG4lKRwK0zno5cuk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t09fSthGj1WIrpBnE+0Siluc3N5vUB+YglJ6AJwWk7/C6Lu2RVSfBC0GaYBSkBjHy29aaX5zOCV6DiJ8Xh5fX/vbhl/hENOG/PCKMCWrFSYYKWJm7Bff0g3ZWSmKt0W0MltZOADIErmWcBzB24zFiSDKBSD9jJZ0OEw0tUPoSyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=CA+zeACm; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="CA+zeACm" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1239125E9; Wed, 15 Apr 2026 23:34:49 -0700 (PDT) Received: from [10.164.148.39] (MacBook-Pro.blr.arm.com [10.164.148.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 871D73F7D8; Wed, 15 Apr 2026 23:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776321294; bh=ziInnYwfR3yWZrCQOeoQ1nSAx4XZG4lKRwK0zno5cuk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CA+zeACmHsjs86HPLF61HtcjzxdugiXRD6NoW5ykZrsPdNT1h/FT/yCamV2pD1/Dt ewBcfl5s4zR2SsqaBUCRHqr2x2KXxQPX3i7tAjZcY+kYZoL9TrFc2V+xVYvbPzCODZ nmochaV7pKzP7jqRzMAzfS71pTtFKzu2UKj9Zr14= Message-ID: <0eed63fd-4119-44e8-90e9-79bca1620826@arm.com> Date: Thu, 16 Apr 2026 12:04:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/page_alloc: fix spaces used for indentation instead of tabs To: Xiang Gao , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, donet.tom@gmail.com, Xiang Gao References: <20260416021945.682234-1-gxxa03070307@gmail.com> <20260416052752.713821-1-gxxa03070307@gmail.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260416052752.713821-1-gxxa03070307@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/04/26 10:57 am, Xiang Gao wrote: > From: Xiang Gao > > checkpatch.pl reports two indentation errors in page_alloc.c where > spaces are used instead of tabs: > > ERROR: code indent should use tabs where possible > #887: FILE: mm/page_alloc.c:887: > + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,$ > > ERROR: code indent should use tabs where possible > #6626: FILE: mm/page_alloc.c:6626: > + sysctl_min_unmapped_ratio) / 100;$ > > In __del_page_from_free_list(), the VM_WARN_ONCE at line 887 uses 8 > spaces for indentation instead of a tab. The identical VM_WARN_ONCE > calls in __add_to_free_list() and move_to_free_list() both correctly > use a tab. > > In setup_min_unmapped_ratio(), the continuation line at 6626 uses 6 > tabs + 9 spaces for alignment. Replace the excess spaces with 6 tabs 6 tabs + 9 spaces -> 7 tabs + 1 space. > + 1 space to correctly align with the opening parenthesis on the > previous line. > > Signed-off-by: Xiang Gao > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2d4b6f1a554e..752673a9b43c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -884,7 +884,7 @@ static inline void __del_page_from_free_list(struct page *page, struct zone *zon > { > int nr_pages = 1 << order; > > - VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype, > + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype, > "page type is %d, passed migratetype is %d (nr=%d)\n", > get_pageblock_migratetype(page), migratetype, nr_pages); > > @@ -6623,7 +6623,7 @@ static void setup_min_unmapped_ratio(void) > > for_each_zone(zone) > zone->zone_pgdat->min_unmapped_pages += (zone_managed_pages(zone) * > - sysctl_min_unmapped_ratio) / 100; > + sysctl_min_unmapped_ratio) / 100; > } > >