mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "M K, Muralidhara" <muralimk@amd.com>
To: Muralidhara M K <muralidhara.mk@amd.com>, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] platform/x86/amd/hsmp: Validate num_args and Report raw SMU mailbox status
Date: Mon, 16 Nov 2026 10:50:57 +0530	[thread overview]
Message-ID: <0ef2bc00-ed43-4f99-876a-ebc6d819c27f@amd.com> (raw)
In-Reply-To: <76e78226-66ba-420f-bf89-74b8504bcafc@amd.com>

Hi Ilpo,

Could you please review the patches below and provide your comments if any ?

On 11/3/2026 1:02 PM, M K, Muralidhara wrote:
> Hi Ilpo,
> 
> For your information, I noticed a "Failed to Apply" status on the 
> sashiko.dev review system for the patch series I submitted below.
> You can find the details here:
> https://sashiko.dev/#/patchset/20261017165153.3748458-1- 
> muralidhara.mk@amd.com
> I hope you could review the series.
> 
> On 10/17/2026 10:21 PM, Muralidhara M K wrote:
>> This series adds a __u32 smu_response field to struct hsmp_message and
>> struct hsmp_telemetry_data, so userspace can inspect the raw SMU
>> mailbox status instead of only the translated errno.
>>
>> Patch 1 is a preparatory fix: hsmp_ioctl_msg()'s fd-mode gate calls
>> is_get_msg(), which reads msg.args[0], before checking that num_args
>> matches the message descriptor, so a request with no args can still
>> reach that read. Validate num_args first.
>>
>> Patch 2 adds smu_response to both structs, set from the polled SMU
>> mailbox status register, and has hsmp_ioctl_msg() always copy the
>> message struct back to userspace, even on failure, so smu_response is
>> visible on every call. It also fixes a related copy_to_user()
>> error-check bug in hsmp_ioctl_get_telemetry() uncovered along the way.
>> Both structs grow under #pragma pack(4) (44->48 and 16->20 bytes),
>> changing the encoded HSMP_IOCTL_CMD and HSMP_IOCTL_GET_TELEMETRY_DATA
>> command numbers; existing userspace needs to rebuild against the
>> updated header.
>>
>> Each patch builds individually and is clean under checkpatch.pl
>> --strict.
>>
>> Muralidhara M K (2):
>>    platform/x86/amd/hsmp: Validate num_args before the fd-mode gate in
>>      hsmp_ioctl_msg()
>>    platform/x86/amd/hsmp: Report raw SMU mailbox status via smu_response
>>
>>   Documentation/arch/x86/amd_hsmp.rst  |  28 +++++--
>>   arch/x86/include/uapi/asm/amd_hsmp.h |  35 ++++++---
>>   drivers/platform/x86/amd/hsmp/hsmp.c | 111 +++++++++++++++++++--------
>>   3 files changed, 123 insertions(+), 51 deletions(-)
>>
>>
>> base-commit: 03f79b70cfa59c76751bc176e6a85a5a67c91801
> 


      reply	other threads:[~2026-11-16  5:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 16:51 Muralidhara M K
2026-10-17 16:51 ` [PATCH 1/2] platform/x86/amd/hsmp: Validate num_args before the fd-mode gate in hsmp_ioctl_msg() Muralidhara M K
2026-10-17 16:51 ` [PATCH 2/2] platform/x86/amd/hsmp: Report raw SMU mailbox status via smu_response Muralidhara M K
2026-11-03  7:32 ` [PATCH 0/2] platform/x86/amd/hsmp: Validate num_args and Report raw SMU mailbox status M K, Muralidhara
2026-11-16  5:20   ` M K, Muralidhara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef2bc00-ed43-4f99-876a-ebc6d819c27f@amd.com \
    --to=muralimk@amd.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muralidhara.mk@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®