From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Alan J. Wylie" <alan@wylie.me.uk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: 5.4 Regression in r8169 with jumbo frames - packet loss/delays
Date: Sun, 1 Dec 2019 10:26:58 +0100 [thread overview]
Message-ID: <0ef3ef69-bfb2-11c5-fb63-6b83cffff0ed@gmail.com> (raw)
In-Reply-To: <24035.32883.173899.812456@wylie.me.uk>
On 01.12.2019 09:57, Alan J. Wylie wrote:
> at 22:37 on Sat 30-Nov-2019 Heiner Kallweit (hkallweit1@gmail.com) wrote:
>
>> Thanks for the report. A jumbo fix for one chip version may have
>> revealed an issue with another chip version. Could you please try
>> the following?
>> I checked the vendor driver r8168 and there's no special sequence
>> to configure jumbo mode.
>>
>> What would be interesting:
>> Do you set the (jumbo) MTU before bringing the device up?
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
>> index 0b47db2ff..38d212686 100644
>> --- a/drivers/net/ethernet/realtek/r8169_main.c
>> +++ b/drivers/net/ethernet/realtek/r8169_main.c
>> @@ -3873,7 +3873,7 @@ static void rtl_hw_jumbo_enable(struct rtl8169_private *tp)
>> case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28:
>> r8168dp_hw_jumbo_enable(tp);
>> break;
>> - case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34:
>> + case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33:
>> r8168e_hw_jumbo_enable(tp);
>> break;
>> default:
>> --
>> 2.24.0
>
> That patch fixes the issue for me.
>
Great, thanks for the feedback!
> Thanks
>
> Alan
>
Heineer
prev parent reply other threads:[~2019-12-01 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 21:12 Alan J. Wylie
2019-11-30 21:37 ` Heiner Kallweit
2019-11-30 22:54 ` Alan J. Wylie
2019-12-01 8:57 ` Alan J. Wylie
2019-12-01 9:26 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef3ef69-bfb2-11c5-fb63-6b83cffff0ed@gmail.com \
--to=hkallweit1@gmail.com \
--cc=alan@wylie.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome