mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: afaerber@suse.de, alexandre.belloni@bootlin.com,
	claudiu.beznea@microchip.com, festevam@gmail.com,
	gregkh@linuxfoundation.org, ilpo.jarvinen@linux.intel.com,
	kernel@pengutronix.de, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, mani@kernel.org,
	nicolas.ferre@microchip.com, richard.genoud@gmail.com,
	s.hauer@pengutronix.de, shawnguo@kernel.org,
	sudeep.holla@arm.com, tklauser@distanz.ch, vz@mleia.com
Subject: Re: [PATCH v5 2/3] tty: serial: use uart_port_tx() helper
Date: Tue, 22 Nov 2022 09:09:36 +0100	[thread overview]
Message-ID: <0ef4f1e6d92601a39fe0d1c316506c12@walle.cc> (raw)
In-Reply-To: <f95ef7b7-cc23-9fed-5d05-1aa66aaeb86a@kernel.org>

Hi,

Am 2022-11-22 08:02, schrieb Jiri Slaby:
> On 21. 11. 22, 21:27, Michael Walle wrote:
>> This will break serial output for the userspace on my board
>> (arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt*dts). The 
>> uart_port_tx()
>> helper will call __port->ops->stop_tx(__port) if 
>> uart_circ_chars_pending()
>> returns 0. But the code above, doesn't do that. In fact, removing the
>> stop_tx() call in the helper macro, will fix the console output.
>> 
>> Any ideas how to fix that?
> 
> Hm, so ATMEL_US_TXRDY is removed from tx_done_mask in stop_tx, but not
> added back in start_tx. So the tx interrupt is never handled (the tx
> tasklet is not scheduled to send the queue chars) in
> atmel_handle_transmit().
> 
> Any chance, the below fixes it?
> 
> diff --git a/drivers/tty/serial/atmel_serial.c
> b/drivers/tty/serial/atmel_serial.c
> index 11bf2466390e..395370e0c77b 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -596,6 +596,8 @@ static void atmel_start_tx(struct uart_port *port)
>                 /* re-enable PDC transmit */
>                 atmel_uart_writel(port, ATMEL_PDC_PTCR, 
> ATMEL_PDC_TXTEN);
> 
> +       atmel_port->tx_done_mask |= ATMEL_US_TXRDY;
> +
>         /* Enable interrupts */
>         atmel_uart_writel(port, ATMEL_US_IER, 
> atmel_port->tx_done_mask);
> 
> 
> thanks,

Unfortunately, that doesn't help. Btw, some characters are transmitted:


[    6.219356] Key type dns_resolver registered
[    6.223679] Registering SWP/SWPB emulation handler
[    6.247530] Loading compiled-in X.509 certificates
[    6.288467] Freeing unused kernel image (initmem) memory: 1024K
[    6.297789] Run /init as init process
WbSOROSOSOSOSOStarting linuxptp system clock synchronization: O

-michael

  reply	other threads:[~2022-11-22  8:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 10:49 [PATCH v5 0/3] tty: TX helpers Jiri Slaby (SUSE)
2022-10-04 10:49 ` [PATCH v5 1/3] tty: serial: introduce transmit helpers Jiri Slaby (SUSE)
2022-10-04 10:49 ` [PATCH v5 2/3] tty: serial: use uart_port_tx() helper Jiri Slaby (SUSE)
2022-11-21 20:27   ` Michael Walle
2022-11-22  7:02     ` Jiri Slaby
2022-11-22  8:09       ` Michael Walle [this message]
2022-11-22  8:18         ` Michael Walle
2022-11-22  8:23           ` Jiri Slaby
2022-11-22  8:25             ` Jiri Slaby
2022-11-22  9:13               ` Michael Walle
2022-10-04 10:49 ` [PATCH v5 3/3] tty: serial: use uart_port_tx_limited() Jiri Slaby (SUSE)
2022-10-04 11:22   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef4f1e6d92601a39fe0d1c316506c12@walle.cc \
    --to=michael@walle.cc \
    --cc=afaerber@suse.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mani@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard.genoud@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tklauser@distanz.ch \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®