From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
To: Thierry Reding <thierry.reding@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [linux-safety] [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO
Date: Mon, 23 Nov 2020 14:51:08 +0000 [thread overview]
Message-ID: <0ef6fc37-4e91-68a1-0744-90b4093ce5ba@codethink.co.uk> (raw)
In-Reply-To: <20201116170137.GA2587640@ulmo>
On 16/11/2020 17:01, Thierry Reding wrote:
> On Mon, Nov 16, 2020 at 04:54:07PM +0000, Sudip Mukherjee wrote:
>> Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code,
>> we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then
>> doing 'return 0'.
>>
>> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>> ---
>> drivers/pci/controller/pci-tegra.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> This has been proposed multiple times in the past and Bjorn and I have
> agreed every time that this is not an improvement, so sorry, but NAK.
Thanks Thierry and Neil. I have now added a blacklist script in our CI
so "PTR_ERR_OR_ZERO" will not be flagged for anything in drivers/pci/*
anymore in our testing.
--
Regards
Sudip
next prev parent reply other threads:[~2020-11-23 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:54 Sudip Mukherjee
2020-11-16 17:01 ` Thierry Reding
2020-11-23 14:51 ` Sudip Mukherjee [this message]
2020-11-23 15:01 ` [linux-safety] " Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef6fc37-4e91-68a1-0744-90b4093ce5ba@codethink.co.uk \
--to=sudip.mukherjee@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®