mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Habil Eren Türker" <habilerenturker@hotmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Clemens Ladisch" <clemens@ladisch.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com"
	<syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com>
Subject: Re: [PATCH RESEND] char/hpet: Fix missing TASK_RUNNING before put_user() in hpet_read()
Date: Thu, 19 Nov 2026 22:16:48 +0100	[thread overview]
Message-ID: <0efc7469-55fd-4295-bea2-04881f2758a2@app.fastmail.com> (raw)
In-Reply-To: <20261119182822.60160-1-habilerenturker@hotmail.com>

On Thu, Nov 19, 2026, at 19:28, Habil Eren Türker wrote:
> On Thu, Nov 19, 2026 at 03:02:07PM +0000, Greg Kroah-Hartman wrote:

>> And why hasn't this ever been noticed before, what changed to cause it
>> to show up now?  And because of that, why is there not a Fixes: tag?
>
> My initial clone was shallow, so I fetched the full history and repeated
> the investigation. I traced the history of hpet_read().
> The TASK_INTERRUPTIBLE state handling followed by the put_user() call is 
> already present in the earliest available Git history, in the initial Git
> import (1da177e4c3f4). I couldn't identify a later commit that introduced
> this behavior.
>
> The 2010 (54066a57c584) and 2024 (4e60131d0d36) changes I examined do not
> appear to have introduced the issue. I couldn't identify a suitable commit
> for a `Fixes:` tag.

I think the warning came from 8eb23b9f35aa ("sched: Debug nested sleeps"),
the behavior seems to be older. Maybe by that time user had moved
on from /dev/hpet to posix timers?

     Arnd

      reply	other threads:[~2026-11-19 21:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:16 Habil Eren Türker
2026-11-19 15:02 ` Greg Kroah-Hartman
2026-11-19 18:28   ` Habil Eren Türker
2026-11-19 21:16     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0efc7469-55fd-4295-bea2-04881f2758a2@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=clemens@ladisch.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=habilerenturker@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®