From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
<~postmarketos/upstreaming@lists.sr.ht>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask
Date: Wed, 19 Apr 2023 09:05:47 -0700 [thread overview]
Message-ID: <0eff5993-7826-25c7-cdde-8291b947eed4@quicinc.com> (raw)
In-Reply-To: <p5b6zwgbrxbhs7hgo4sh2btwmbjgoyxp5mxdutt4fkh2hjv7dz@6dq5ug5l2ohu>
On 4/19/2023 2:28 AM, Marijn Suijten wrote:
> On 2023-04-18 09:06:34, Abhinav Kumar wrote:
>>
>> On 4/17/2023 4:14 PM, Marijn Suijten wrote:
>>> The WB debug log mask ended up never being assigned, leading to writes
>>> to this block to never be logged even if the mask is enabled in
>>> dpu_hw_util_log_mask via sysfs.
>>
>> This should be debugfs not sysfs.
>
> Good catch! I've queued this up for v2 if it comes to it, otherwise it
> can perhaps be fixed up while applying for msm-fixes?
>
Yes, I can fix it up while applying to -fixes.
>>> Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks")
>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>> ---
>>
>> With that fixed,
>>
>> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
> Thanks!
>
> - Marijn
next prev parent reply other threads:[~2023-04-19 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 23:14 [PATCH 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup Marijn Suijten
2023-04-17 23:14 ` [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs Marijn Suijten
2023-04-18 1:54 ` Abhinav Kumar
2023-04-18 7:54 ` Marijn Suijten
2023-04-20 14:33 ` Dmitry Baryshkov
2023-04-20 15:46 ` [Freedreno] " Abhinav Kumar
2023-04-20 21:39 ` Marijn Suijten
2023-04-20 22:20 ` Dmitry Baryshkov
2023-04-17 23:14 ` [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask Marijn Suijten
2023-04-18 16:06 ` Abhinav Kumar
2023-04-19 9:28 ` Marijn Suijten
2023-04-19 16:05 ` Abhinav Kumar [this message]
2023-04-20 14:32 ` Dmitry Baryshkov
2023-04-17 23:14 ` [PATCH 3/3] drm/msm/dpu: Pass catalog pointers directly from RM instead of IDs Marijn Suijten
2023-04-20 14:36 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eff5993-7826-25c7-cdde-8291b947eed4@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jordan@cosmicpenguin.net \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®