From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdJ0UZk (ORCPT ); Fri, 27 Oct 2017 16:25:40 -0400 Received: from mail-sn1nam01on0063.outbound.protection.outlook.com ([104.47.32.63]:37568 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752112AbdJ0UZb (ORCPT ); Fri, 27 Oct 2017 16:25:31 -0400 Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171023092020.GB19523@nazgul.tnic> <20171026135614.GA12359@nazgul.tnic> <9258d8e7-b185-01d2-be92-d7d2820c7eb6@amd.com> <20171026174427.GB29782@nazgul.tnic> <20171026201322.GA32181@nazgul.tnic> <89f4ec21-e31e-18f2-27c5-946c38cd128d@amd.com> <20171027075650.GA1276@nazgul.tnic> <323f3862-b326-e6b4-015f-6d923d7c700f@amd.com> <20171027201554.GH12039@nazgul.tnic> From: Brijesh Singh Message-ID: <0f039ac4-a9c4-9920-4fb9-b1c5eadf3128@amd.com> Date: Fri, 27 Oct 2017 15:25:24 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171027201554.GH12039@nazgul.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: CY4PR04CA0062.namprd04.prod.outlook.com (10.171.243.155) To BY2PR12MB0148.namprd12.prod.outlook.com (10.162.82.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54136e64-b1ae-4ff2-0e25-08d51d78dd64 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603238);SRVR:BY2PR12MB0148; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;3:vOFpmAgzWQK9iIWLPGTdu8HJ6KaJg/UFiEOjy9uG7HCtrqyLRT1VdS/DIkUmWbiT7mdtwMA0y1o2WR1+3OQFeOC4yQYcg3jD0m5HRh2WmPp9VRg03Fm2yVgkuD6OHhJQG4QvvXmsnT1xgPxalVkxWW7LKmk/i06fZ0z/X5bI3jLWOB7ri0tldei2kmhlAVsERg/Iwc5lVSCTfos7xKeN1Xf3Rt3LyvRX3nkHZUtxbPFzHUsWrQqz0Ga4N7edghig;25:gLKtNzmLaeRtFnGh6P7OxkGykEgfOSG1w7Xqnt7uV/gPi38/AchNjxG50g29Hecd2lxMJ3nkhAIOXYpQnqfI3MDFhwLypFPK4d55Bwa9hKT9ub0wg70syFcJh5saKDNkuWi6mZ9pScESDsGXSkOZsej6b7AxmH+BNrfjWNF1eLxJaqX9Ynbr1tdJKvAJNekRoo9ygYzdd03CIHepjGFLxUTwnUdoYhJuMD6D4L+0J48jtPf0GUQcjU0jT3+0r3mrBseXTOca0Sop6O43QKBXZ+bVZULc+fBvZEUOC81+YLoicf8k21RWsaxV6q4Ro6Vx4hTAYTLGzaGhQNQwwpkoKA==;31:m9SsUaXqLv9+XiLxTXizTJE464S328Id/FzzH+dDcbWO1DOVTpHYthaAPBbB7rSU8QCPx2Cmqkjhk0nwnbKFm9p6+R0+OP4nwKn1+8GpUzhMj/mqAj5fBc6MyO7AP39dPViLxQBVvcUYB0opwWn1ki1qrhLREFvdTGvmHa34kZD3RZnzTgBoE8TRpiLqsw8HPwXKhpHR4s567uc3vFzG5gfyomS0Uo0r1vHTZKz/gSg= X-MS-TrafficTypeDiagnostic: BY2PR12MB0148: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:wH3aP1cX211GMUp9gJXDIl771DnV1w0qIvTrZz5IFZT2SMfbKsi2QoAwmL9+YUtuklb/e42EnZ0zBKfW9PWDbptJ1sf5BxRSdSPRSQLKak7/sv0TXgq84Qt69Viup3yIXa3HOUTJRbToMcgU73ZMSBLMZgvgVtwUzsR/uJaXtoNRbnQDtyqG6lnZAZhpSnsUuZODIsZTU6bEumo1iueOG62NLQ3ntiKKzKLVl/O0jrzn2eQtKTURP9aYApMYcjBn+5HWBWEyw1dnm1RtmtoezJUsXS3rIUGyXhnLfwSBKzprr1qe9B3MJa/zmz+PloUDFqCxUO2ACj17Z307ABM6QKtjn2pwbs1dG4TAX3uERdVIc4bqsBToWMR6EvTDDvUVztkO98wuYpdYqstoa6q1g0kmhsFVkEPz6qWFiV3zGoZ6KphaxIc3+T9J1Wvw5D33WEdyeHPefpQzNzCud2aLicGe3Rkro+/QJpYPNf4nljQAUrQhb0Wl9egWbx1/NeDV;4:ayQhwhTaZgVlp4D3w9ImIR66JfsKIkQS7zsTJ9aBlf3Jf02Ds5nTShHo+6M9qqtbHMOdgHT5zp/BnM4ellQoy9jzYPHg9i+dDxDC3TeeCsfbZM50BaMgzgUSSM9NLW/6MCK8K68f3DWMf0qAbLw+GShKF1i6eqNmNzzRH0kCPq9iqexz92PeDQZ8GKgWNtrduyUmj4yy35NwU23o5/gjnjX8Q8/HsxhPLFF2KIdNtilNTgcHSVBsEa4oZIaVYtq2W0z9DH8XMeEpYLPoPm7UeA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3231020)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0148;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0148; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(39860400002)(376002)(189002)(199003)(24454002)(36756003)(53546010)(6486002)(101416001)(4326008)(6506006)(478600001)(54356999)(76176999)(50986999)(97736004)(316002)(54906003)(93886005)(64126003)(23676002)(58126008)(6666003)(6512007)(31696002)(50466002)(86362001)(106356001)(8936002)(6246003)(33646002)(2950100002)(53936002)(3846002)(2906002)(5660300001)(16526018)(6116002)(65826007)(230700001)(7736002)(66066001)(81156014)(305945005)(81166006)(105586002)(47776003)(31686004)(8676002)(83506002)(25786009)(229853002)(68736007)(65956001)(6916009)(65806001)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0148;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ4OzIzOjNKclFiOHQydldOOU1BclN1VkdFdEMxc0Y5?= =?utf-8?B?WTFoM211MFV5bm9IMVFqWlFCVEUva1hraHB2MWcxZmFubnRMRWRkQnhGRWg0?= =?utf-8?B?eHNOOXY5RGpLUVBMbThyaEx5dFIrdWlBVHl2RXVDd3dvakYvRUNHUzBISk00?= =?utf-8?B?T1VZazFCelRwclVOUTY2UVZHZVc5cVlwa0pzc05CTVFKY1ZQNnZwZnVHdEln?= =?utf-8?B?WjdWbmt4ZU5neWEzNVBJRzlTc1krZVgvYURkSzF1eFhxdU1FNTNDZU9Pb0li?= =?utf-8?B?WXhDREwwcHo4bnoyVWRXKzNoSGdpdG5VQ3hJWjh2T2drVnNWQkxoYzZPL2Fj?= =?utf-8?B?OFlwNUp6eU92UHJQVkU5NTRWMjZiMmtZK0R0WEpxRjg2SFMrSjAyZWdpaUtQ?= =?utf-8?B?YUgrcE9LWDZ3RklnaXBMOXlwTTIybzNCMi9uSkZPRjJna2QwVE52bkFXcGlC?= =?utf-8?B?bE14ck5na0ZQTVBMamFlNThWNzVGRXQvakdsQmNBaHp1aVh4WEtRTG1PYzZC?= =?utf-8?B?eGtJRFhTQzB2WmZld291VGtKVE1BRWZ4dzNIeE1ibE1TbmJiSG1RRjV2cmMy?= =?utf-8?B?NzZUMWROMWFtclRQNU0rUDB4cHozWWN4SWRKb1BMRGVId3ZnbUFHdGhDYzY3?= =?utf-8?B?VHJUL2pTUFAxRk54UU5xK0M4WVQ2amZwYXpXdGpBRXBLa29qazNvbnpBeTk1?= =?utf-8?B?a0h3OFFhS0ZQeE5RdFRoajFuZHlPOEJxalRqczI0NjJubHJha2U0b3JsODRt?= =?utf-8?B?ZDVsWkkveTNPY2xlcHFWa3hZR0F5QTlET1ZwWFdRY3gyVVdydTZhd0tQWkR3?= =?utf-8?B?N1draGlUNWNyRlBkdzIvZVVNUDBsYkU4OTg3NGQrdUZrOG5kYkFrdHRBMm9Z?= =?utf-8?B?b0RnMS9yZ2gwdVBkeG1hOXpGMFBPRjBBcmlXenY0RG94ZkdoUDFReUgwRHBT?= =?utf-8?B?T0RoRlUzV1UySHBvbTVFZ1NGWEZMK0Z1MjFrb0JsYVpPdVJid3JKLzZSUGJa?= =?utf-8?B?KzY3aTJJbW9aYVcvNEd3L2JEc3NodTZCc3d1R1c2OGZjaUJ1YkU1ZE41ak90?= =?utf-8?B?Ymk2b1g3cU4wZm1GUVV1ejVBU3krdVU1TTJVa1B2Q29GeWJEdXBId0RSWCtm?= =?utf-8?B?VjJuMXphc05DSUE2SGF0SzRMbDhWOFRCWnZmY0wyQ2I4cTUwaXlJWXNHVWlQ?= =?utf-8?B?UEF3MHhxalVpZ1JoRFdGdi9uNWc0VG9BRjJzNFl6UWhVZlZQeURDellvZWRR?= =?utf-8?B?cGNVZ3VFaTA4MThyZjFMUy8xZ1FQS2kxR2d2Z3NIbDZmU25yY1VmRFZOUmhz?= =?utf-8?B?U3FnZGtWVjdGZ2tKN1hVajlPcGNGN3U2ZE9Jakd2NVdoUGtmZnZBeHFWUHVk?= =?utf-8?B?b1lONHM2eEYyZ3ZsZFowRW9wbGJ4MVJvUHY1TmdxL0lvZGs5RjdlblViWWxD?= =?utf-8?B?UzRZQW9yU0xlS3F1TVhFTVY4UkJuT3R2RFF3bU1rdm9YNk5LOThWVFc4ZFhX?= =?utf-8?B?Zi8yMGJsTVJCK1ZzTXlEYnJjeE51RUJqRy9vbXcxdVE2SGlYazRZTmNDZ1hm?= =?utf-8?B?eDJFUkFZNVNHb0JWM01sVjBRQkRjcDRaQy9sWUtRRUIrNndJYUdlM2Fhb0U0?= =?utf-8?B?bC9mdEpyNVN6RTM0N29MblNOcWRmOFRoZjh6S0QyeGpsR2JxUkJXNzdWcDUw?= =?utf-8?B?a3hXc0ZUSjNuSHg1azZ6amdkZnZtTzc1UTAxcUp3RkpPMjhZckxpRHZaR1oz?= =?utf-8?B?SmNyZURjbE5PV080WXJoLzVEdUVvVkNHWVR0YThSNVZ2NGlhVnRCcDgwbUhn?= =?utf-8?B?ZVZVL1ExeW54TFlVWG15SlRHWDRXNXlULzdMWWVpTWF6RGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;6:lknpqpUf7wHSJPuksSwyo1UI5iRv8cVVxC9Hvb9WARXc22vu9kB9BUa0VLAc0HaulL5vKpVmLNE6D0q47Qn6I2efJqHgWE7WWL5drgU0qEB40IjeWtpVRWdj1blJwoUB3+x8gRzVIkwW3fpxMmzkSek7aEzVoxzWcprHs10H5P+okNnHzVIdN9XQ1WcdE+UA1xySu8/+bT/n1AGhGwNoB3Sk/1+PnTLKDVC65uqbP/scFirGS82vT4WyKSaktKBZZ+GBNBzCfk/tFAffyt3yESW7GupPGyIDb6sKK2pLcGsTGXkl08HNcPfOLucMhA5LtwxYcyx9ISeI4UFil6heSKHf1tsfjizSX1yNaWpbAu0=;5:93d7jJ9Rvm75HU1jOp8soxwfBZAEv71PmRRDiNBeXpwtNCcK6iQE7BT71tkonDrUffj4kJ77EJw5+mHqA5M5yXxz9cdaEoVwMQOtKAWmi/g2VZz2AAdAUwDmd/qziO9bKwxs7q/Bh3s3yVVKDaOdo3i7nKyS2U7a1VvZi1cWLjw=;24:zUVYDQaynyE848hdc1mbKASiwC6Pef7Rbtoa27gVFt4mekwfjr9UeiuV4N8bGTgRS3Qctzi+PtK0tIA581vKsG8CytMg6xMc5tyTFPZ6QUY=;7:vuQZjCd6Y9QO7xgIDDfX+k4zNWnp3OqBPqPpVOw1UBs0vsuQLiJOb0ek3YLfjDn2tQ/UUM+MU5WMPIUjfldgM5CO7v64c6ilnpabk8fkpNfoYBvTGlww4F7572DeDki6ovAtNOHst9kIeGzzTlfHoy3EWn6VNPhY/g2XPsNi8ar/fGkUfpuk8jXMAiuUfbafacvNgLZY1UingrjRTfB5hp7DFBQq/elJuPPrgDGFp3yq9ztpB+kqSkcXfdobiSVm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:u4Su7f5upetr9IIhvitRX6Wy2ufdnJ2AHGkUg+y+T0LG1E38SLvAITjdWoL8gSan2I6j2WSRemmXKJIC677xW0xEzn06jJhTEmwlA4Rd7fC+AOc22Jd0JJxuC7X2nNrifxJ2qYhmga8ARgiMtX+tqNKvmL+uex6VE6sbn6M8P8y8MLGL7j7FTHVX57PiGwjbGdXJW57+GxCE3HVyS0MA3qXjGNcNE7SEF5RhJ29cSvrFqbEsXtYBNDfTrVaVlMxr X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 20:25:27.6177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54136e64-b1ae-4ff2-0e25-08d51d78dd64 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0148 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/17 3:15 PM, Borislav Petkov wrote: > On Fri, Oct 27, 2017 at 06:28:38AM -0500, Brijesh Singh wrote: >> ... User can retry the command sometime later when nobody else is >> using the PSP. > That still doesn't prevent you from doing two things: > > * make that fw_init_count a proper kref instead of your homegrown thing OK, I can use kref in next patch. > > * do not preemptively execute commands on the PSP if you can't possibly > know what the next command is going to be - instead, just put it in the > required state only when you really have to. I.e., don't do all that > unnecessary INIT -> CMD -> SHUTDOWN game for no reason. Yep, we are doing state transition only when we really need to. At least so far I have tried to avoid making any unnecessary state transitions. > Thx. >