From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbeAZOcW (ORCPT ); Fri, 26 Jan 2018 09:32:22 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41400 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753168AbeAZOcT (ORCPT ); Fri, 26 Jan 2018 09:32:19 -0500 Subject: Re: [PATCH v1 2/2] fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES To: Tomi Valkeinen , Thomas Huth , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: schwidefsky@de.ibm.com, borntraeger@de.ibm.com, stefan.kristiansson@saunalahti.fi References: <033e4a497792b2fa484c1288b9ed05c068565088.1516892845.git.alifm@linux.vnet.ibm.com> <036978d8-0628-9841-4bc1-b09c5231b577@redhat.com> <1fae3814-705e-a221-5e58-cef8da3a2f7d@ti.com> From: Farhan Ali Date: Fri, 26 Jan 2018 09:32:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1fae3814-705e-a221-5e58-cef8da3a2f7d@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18012614-0012-0000-0000-000015A8654B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008431; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000248; SDB=6.00980656; UDB=6.00497147; IPR=6.00759957; BA=6.00005796; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019225; XFM=3.00000015; UTC=2018-01-26 14:32:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012614-0013-0000-0000-0000513A7EF6 Message-Id: <0f10ed78-3275-6356-8357-a6f499213d52@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-26_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801260191 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2018 07:38 AM, Tomi Valkeinen wrote: > On 26/01/18 14:33, Thomas Huth wrote: >> On 25.01.2018 16:47, Farhan Ali wrote: >>> The Opencores framebuffer device uses I/O memory and with >>> CONFIG_HAS_IOMEM disabled will lead to build errors: >>> >>> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined! >>> >>> Fix this by adding HAS_IOMEM dependency for FB_OPENCORES. >>> >>> Signed-off-by: Farhan Ali >>> --- >>> drivers/video/fbdev/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>> index 5e58f5e..8667e5d 100644 >>> --- a/drivers/video/fbdev/Kconfig >>> +++ b/drivers/video/fbdev/Kconfig >>> @@ -976,7 +976,7 @@ config FB_PVR2 >>> >>> config FB_OPENCORES >>> tristate "OpenCores VGA/LCD core 2.0 framebuffer support" >>> - depends on FB && HAS_DMA >>> + depends on FB && HAS_DMA && HAS_IOMEM >>> select FB_CFB_FILLRECT >>> select FB_CFB_COPYAREA >>> select FB_CFB_IMAGEBLIT >> >> I think it would be better if fbdevs in general would depend on >> HAS_IOMEM ... or could there be any frame buffer devices without IOMEM ? > > There are some small ones which are updated with, say, i2c > (ssd1307fb.c). I think those don't need iomem. > > Tomi > Most of the other framebuffer devices are fenced of by architecture dependency or PCI dependency. So I am hesitant to introduce a blanket dependency for all fbdevs. Thank you guys for reviewing! Thanks Farhan