mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	"Pekka Paalanen" <pekka.paalanen@collabora.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v3 5/6] Documentation/admin-guide: Document nomodeset kernel parameter
Date: Mon, 8 Nov 2021 13:48:24 +0100	[thread overview]
Message-ID: <0f152d33-6362-b04b-6661-1d5cd7f32015@suse.de> (raw)
In-Reply-To: <20211108121544.776590-6-javierm@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1871 bytes --]

Hi

Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas:
> The nomodeset kernel command line parameter is not documented. Its name
> is quite vague and is not intuitive what's the behaviour when it is set.
> 
> Document in kernel-parameters.txt what actually happens when nomodeset
> is used. That way, users could know if they want to enable this option.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
> 
> (no changes since v1)
> 
>   Documentation/admin-guide/kernel-parameters.txt | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git Documentation/admin-guide/kernel-parameters.txt Documentation/admin-guide/kernel-parameters.txt
> index 91ba391f9b32..ed9859fd0734 100644
> --- Documentation/admin-guide/kernel-parameters.txt
> +++ Documentation/admin-guide/kernel-parameters.txt
> @@ -3521,6 +3521,10 @@
>   			shutdown the other cpus.  Instead use the REBOOT_VECTOR
>   			irq.
>   
> +	nomodeset	Disable kernel modesetting. DRM drivers will not be
> +			loaded when this kernel boot parameter is used. The
> +			simpledrm driver is the only DRM driver that loads.
> +

That's misleading and to the general admin it might not be clear what 
simpledrm is about. Rather say something like

  Disable kernel modesetting. DRM drivers will not perform
  display-mode changes or accelerated rendering. Only the
  system framebuffer will be available for use. Requires the
  firmware or boot loader to setup the display. Useful as
  fallback, or for testing and debugging.

Best regards
Thomas

>   	nomodule	Disable module load
>   
>   	nopat		[X86] Disable PAT (page attribute table extension of
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2021-11-08 12:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 12:15 [PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-08 12:15 ` [PATCH v3 1/6] drm: Don't print messages if drivers are disabled due nomodeset Javier Martinez Canillas
2021-11-08 12:15 ` [PATCH v3 2/6] drm/vboxvideo: Drop CONFIG_VGA_CONSOLE guard to call vgacon_text_force() Javier Martinez Canillas
2021-11-08 12:15 ` [PATCH v3 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem Javier Martinez Canillas
2021-11-08 12:15 ` [PATCH v3 4/6] drm: Decouple nomodeset from CONFIG_VGA_CONSOLE Javier Martinez Canillas
2021-11-08 12:15 ` [PATCH v3 5/6] Documentation/admin-guide: Document nomodeset kernel parameter Javier Martinez Canillas
2021-11-08 12:48   ` Thomas Zimmermann [this message]
2021-11-08 15:32     ` Daniel Vetter
2021-11-08 12:15 ` [PATCH v3 6/6] drm: Make the nomodeset message less sensational Javier Martinez Canillas
2021-11-08 12:50   ` Thomas Zimmermann
2021-11-08 12:50 ` [PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic Thomas Zimmermann
2021-11-08 12:54   ` Javier Martinez Canillas
2021-11-08 16:31     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f152d33-6362-b04b-6661-1d5cd7f32015@suse.de \
    --to=tzimmermann@suse.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=pbrobinson@gmail.com \
    --cc=pekka.paalanen@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®