From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941334AbcIHPzn (ORCPT ); Thu, 8 Sep 2016 11:55:43 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:57832 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932299AbcIHPzl (ORCPT ); Thu, 8 Sep 2016 11:55:41 -0400 From: Amitkumar Karwar To: Javier Martinez Canillas , Kalle Valo CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Nishant Sarmukadam" , Arend van Spriel Subject: RE: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() Thread-Topic: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() Thread-Index: AQHSCDf5S2hWGO2xRUaSH1cUPmxZf6BvwGIA Date: Thu, 8 Sep 2016 15:55:34 +0000 Message-ID: <0f15fe320fa34ae287f8a6b91ec78a34@SC-EXCH04.marvell.com> References: <20160903103520.8C69C6201B@smtp.codeaurora.org> <66735eb5-c831-8e06-337b-80ccfc392061@osg.samsung.com> In-Reply-To: <66735eb5-c831-8e06-337b-80ccfc392061@osg.samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_08:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609080231 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u88Ftr3M026708 Hi Javier, > From: Javier Martinez Canillas [mailto:javier@osg.samsung.com] > Sent: Tuesday, September 06, 2016 5:43 PM > To: Kalle Valo > Cc: linux-kernel@vger.kernel.org; Amitkumar Karwar; > netdev@vger.kernel.org; linux-wireless@vger.kernel.org; Nishant > Sarmukadam; Arend van Spriel > Subject: Re: mwifiex: propagate error if IRQ request fails in > mwifiex_sdio_of() > > Hello Kalle, > > On 09/03/2016 12:35 PM, Kalle Valo wrote: > > Javier Martinez Canillas wrote: > >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error > >> message is printed but the actual error is not propagated to the > caller function. > >> > >> Signed-off-by: Javier Martinez Canillas > > > > What's the conclusion with this patch? Should I drop it or take it? > > > > (The discussion is available from the patchwork link in the > > signature.) > > > > My understanding is that Arend agrees with the patch and that the > question raised was caused by looking at an older kernel version. IOW, > the patch is OK and should be picked. > > I'm adding Arend to cc, so can comment in case I misunderstood him > though. > This error doesn't affect actual wifi functionality. Only thing is wakeup on interrupt when system is in suspended state won't work. I think, we can make below change. ------------------ @@ -122,9 +122,11 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card) IRQF_TRIGGER_LOW, "wifi_wake", cfg); if (ret) { - dev_err(dev, + dev_dbg(dev, "Failed to request irq_wifi %d (%d)\n", cfg->irq_wifi, ret); + card->plt_wake_cfg = NULL; + return 0; } disable_irq(cfg->irq_wifi); } ----------------- Regards, Amitkumar