From: Sudeep Holla <sudeep.holla@arm.com>
To: chenhuacai@gmail.com, gregkh@linuxfoundation.org
Cc: Sudeep.Holla@arm.com, rafael@kernel.org,
linux-kernel@vger.kernel.org, zhangfx@lemote.com,
wuzhangjin@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH V3] cacheinfo: Keep the old value if of_property_read_u32 fails
Date: Tue, 22 Jan 2019 10:30:42 +0000 [thread overview]
Message-ID: <0f1a742c-9123-e615-6abc-bc6325a7644c@arm.com> (raw)
In-Reply-To: <CAAhV-H61Muv7V358Mfe27C0tEedOQGncN1Dfq2wu1ddaVT1o0w@mail.gmail.com>
On 22/01/2019 00:51, Huacai Chen wrote:
> Ping?
>
> On Wed, Dec 19, 2018 at 4:15 PM Huacai Chen <chenhc@lemote.com> wrote:
>>
>> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
>> property_read_u32 instead of get_property,read_number") makes cache
>> size and number_of_sets be 0 if DT doesn't provide there values. I
>> think this is unreasonable so make them keep the old values, which is
>> the same as old kernels.
>>
>> Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Huacai Chen <chenhc@lemote.com>
>> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Looks like this slipped through the cracks during holiday period.
Wait until Greg responds for a week, if not please repost as it may be
difficult to dig out old emails especially the ones during holidays.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-01-22 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 8:16 Huacai Chen
2019-01-22 0:51 ` Huacai Chen
2019-01-22 10:30 ` Sudeep Holla [this message]
2019-01-22 12:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f1a742c-9123-e615-6abc-bc6325a7644c@arm.com \
--to=sudeep.holla@arm.com \
--cc=chenhuacai@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®