From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Kai Huang <kai.huang@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 0/5] x86: Enumerate TME and PCONFIG, add MKTME_KEY_PROG helper
Date: Wed, 7 Feb 2018 10:49:40 -0800 [thread overview]
Message-ID: <0f1e32ce-81a5-bfc8-d830-a97df5bbee8a@intel.com> (raw)
In-Reply-To: <20180207125946.5906-1-kirill.shutemov@linux.intel.com>
On 02/07/2018 04:59 AM, Kirill A. Shutemov wrote:
> The patchset does some ground work for MKTME enabling:
> - Adds two new cpufeatures: TME and PCONFIG;
> - Detects if BIOS enabled TME and MKTME;
> - Enumerates what PCONFIG targets are supported;
> - Provides helper to program encryption keys into CPU;
>
> As part of TME enumeration we check of how many bits from physical address
> are claimed for encryption key ID. This may be critical as we or guest VM
> must not use these bits for physical address.
For this kind of stuff, I'd really appreciate if you included some
high-level descriptions. I'd assume that a reviewer has no idea what
PCONFIG or MKTME is.
It would also be really nice to say which hardware will implement this.
Is it in particular CPUs today, for instance?
prev parent reply other threads:[~2018-02-07 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 12:59 Kirill A. Shutemov
2018-02-07 12:59 ` [PATCHv2 1/5] x86/cpufeatures: Add Intel Total Memory Encryption cpufeature Kirill A. Shutemov
2018-02-07 12:59 ` [PATCHv2 2/5] x86/tme: Detect if TME and MKTME is activated by BIOS Kirill A. Shutemov
2018-02-07 19:02 ` Dave Hansen
2018-02-07 22:09 ` Kai Huang
2018-02-08 15:45 ` Kirill A. Shutemov
2018-02-07 12:59 ` [PATCHv2 3/5] x86/cpufeatures: Add Intel PCONFIG cpufeature Kirill A. Shutemov
2018-02-07 12:59 ` [PATCHv2 4/5] x86/pconfig: Detect PCONFIG targets Kirill A. Shutemov
2018-02-07 12:59 ` [PATCHv2 5/5] x86/pconfig: Provide defines and helper to run MKTME_KEY_PROG leaf Kirill A. Shutemov
2018-02-07 18:49 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f1e32ce-81a5-bfc8-d830-a97df5bbee8a@intel.com \
--to=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kai.huang@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome