From: "Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>
To: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"ribalda@chromium.org" <ribalda@chromium.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"nfraprado@collabora.com" <nfraprado@collabora.com>
Subject: Re: [PATCH 7/7] ASoC: mediatek: mt8195-afe-pcm: Drop .remove_new() callback
Date: Fri, 12 Jan 2024 06:13:10 +0000 [thread overview]
Message-ID: <0f21493732370dcf344ca5f1e417f79e27a74f3c.camel@mediatek.com> (raw)
In-Reply-To: <20240111105247.117766-8-angelogioacchino.delregno@collabora.com>
On Thu, 2024-01-11 at 11:52 +0100, AngeloGioacchino Del Regno wrote:
> As we're calling devm_pm_runtime_enable() in the probe function of
> this
> driver we don't need to disable it on remove as that's devm managed:
> drop the .remove_new() callback entirely.
>
> While at it, also add the sentinel comment to the last of_device_id
> entry.
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
Reviewed-by: Trevor Wu <trevor.wu@mediatek.com>
next prev parent reply other threads:[~2024-01-12 6:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 10:52 [PATCH 0/7] ASoC: mediatek: AFE drivers cleanups AngeloGioacchino Del Regno
2024-01-11 10:52 ` [PATCH 1/7] ASoC: mediatek: mt8173-afe-pcm: Convert to devm_pm_runtime_enable() AngeloGioacchino Del Regno
2024-01-11 10:52 ` [PATCH 2/7] ASoC: mediatek: mt8173-afe-pcm: Use devm_snd_soc_register_component() AngeloGioacchino Del Regno
2024-01-12 8:17 ` Chen-Yu Tsai
2024-01-12 12:14 ` kernel test robot
2024-01-11 10:52 ` [PATCH 3/7] ASoC: mediatek: mt8183-afe-pcm: Convert to devm_pm_runtime_enable() AngeloGioacchino Del Regno
2024-01-11 10:52 ` [PATCH 4/7] ASoC: mediatek: mt8183-afe-pcm: Simplify with dev_err_probe() AngeloGioacchino Del Regno
2024-01-11 10:52 ` [PATCH 5/7] ASoC: mediatek: mt8192-afe-pcm: Convert to devm_pm_runtime_enable() AngeloGioacchino Del Regno
2024-01-11 10:52 ` [PATCH 6/7] ASoC: mediatek: mt8192-afe-pcm: Simplify with dev_err_probe() AngeloGioacchino Del Regno
2024-01-12 3:13 ` kernel test robot
2024-01-12 8:01 ` kernel test robot
2024-01-11 10:52 ` [PATCH 7/7] ASoC: mediatek: mt8195-afe-pcm: Drop .remove_new() callback AngeloGioacchino Del Regno
2024-01-12 6:13 ` Trevor Wu (吳文良) [this message]
2024-02-01 10:08 ` [PATCH 0/7] ASoC: mediatek: AFE drivers cleanups AngeloGioacchino Del Regno
2024-02-01 11:25 ` Mark Brown
2024-03-26 15:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f21493732370dcf344ca5f1e417f79e27a74f3c.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=ribalda@chromium.org \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®