mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Alexandru Ardelean <aardelean@deviqon.com>,
	Cai Huoqing <caihuoqing@baidu.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: stm: don't always auto-enable I2C and SPI interface drivers
Date: Sun, 2 Jan 2022 13:59:56 +0300	[thread overview]
Message-ID: <0f233def-99c8-d6f1-b4e6-26cc21187a01@cogentembedded.com> (raw)
In-Reply-To: <CACRpkdYcR7SA1bfzAtMBpXZiXZeZnV8hWGddx26VvvKwiZC4Sw@mail.gmail.com>



02.01.2022 10:02, Linus Walleij wrote:
> On Wed, Dec 29, 2021 at 8:29 AM Nikita Yushchenko
> <nikita.yoush@cogentembedded.com> wrote:
> 
>>   config IIO_ST_ACCEL_I2C_3AXIS
>> -       tristate
>> -       depends on IIO_ST_ACCEL_3AXIS
>> -       depends on IIO_ST_SENSORS_I2C
>> +       tristate "STMicroelectronics accelerometers 3-Axis I2C Interface"
>> +       depends on (I2C && IIO_ST_ACCEL_3AXIS)
>> +       default y if (I2C && IIO_ST_ACCEL_3AXIS)
>> +       select IIO_ST_SENSORS_I2C
> 
> This thing that a Kconfig symbol is made to depend on itself just
> boggles my head but it wouldn't surprise me if KConfig is this weird :(
> 
> I CCed Arnd who knows KConfig a bit better than anyone I know.

Sorry but I don't see a dependency on itself here.

"IIO_ST_ACCEL_I2C_3AXIS" depends on "IIO_ST_ACCEL_3AXIS"

Name with I2C embedded not at end could be a bit wired, but in this patch I don't change any names to 
keep things 100% backward-compatible.

Nikita

  reply	other threads:[~2022-01-02 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29  7:29 Nikita Yushchenko
     [not found] ` <CAHp75VfKcKyc8fdu0XnaYYnY2UP+27=8hKJMtzwH5755Cw=sww@mail.gmail.com>
2021-12-30 20:21   ` Nikita Yushchenko
2022-01-02  7:02 ` Linus Walleij
2022-01-02 10:59   ` Nikita Yushchenko [this message]
2022-01-02 13:49   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f233def-99c8-d6f1-b4e6-26cc21187a01@cogentembedded.com \
    --to=nikita.yoush@cogentembedded.com \
    --cc=aardelean@deviqon.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=caihuoqing@baidu.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®