From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E9B34D4F7 for ; Wed, 4 Mar 2026 09:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616547; cv=none; b=qRTW3QAm7fpcjtyf34XnN4onVKQ76vgd4lFkbcBhEYoWoNDWz7x7s6bfU0Tp1XbMYaUO10uzQ1h8TdK5fV4WP585ydTtF0EYFf+UKKJ+VJkoJHcFJ1fX6P/bjew2UFo1mWixO3RrU2pgIMWoNQE8kMS8yC3DVIzU3HL19HX99RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616547; c=relaxed/simple; bh=+iZwt2542TCvLOegTbYJXlTOngpzejOxddz+prY+cYs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=bqbXp85gatFQ2TjqBr0Fe3kWdnAv45yMIKQg8wvanWLRx6TKyapCT58ew8/AZ3fG75KgwFra/ehfJV9T6EBagLnq3fZXdkI0HnXv9FLM0FNb00VLbkH6HOtvGsZWaZvn0pBW3WqLVkyLZjL0+ePuBxsvUmkIJ7RMavzZCpll1H0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VZJa9yr6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XGJEBzdW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VZJa9yr6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XGJEBzdW" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245T6QS1678611 for ; Wed, 4 Mar 2026 09:29:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DW5EUg1yaoYe86hPewYMQORzz9/C/R4GlG4Kgu4d2j8=; b=VZJa9yr6rmrbFWTY jkihApjPB49cJJk5FW7LGKhpiWIi+deLiNSYs1kIz4vjiA6/N8jx3+5Kstnv/apO Uod6i5/9Azf4p3Z/EKp1DI0M1+5+G4aRU9k7e6whI3uVNS1pmxRXA/Nflh4Ar5Ox /EB9RyXVTQJzsEE4D13ZfGo1B9axh+zWaCpJgweouIP65+5DAzOM+EWqq8sfHysX JEB9C1zkfuspONJCxSViQMNmlzDgjpjiLhjRR96U7NUiAsg18RrZY1NqLOVGewmF n6K3ysWL6LLrDXOq4yMzvJQC9tT31bASsyunpYjeRNXtBcHZdgPfWKlFdUo3UAcK bOnw+g== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp73ha8fd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 09:29:05 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c881d0c617so3986948885a.1 for ; Wed, 04 Mar 2026 01:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772616544; x=1773221344; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=DW5EUg1yaoYe86hPewYMQORzz9/C/R4GlG4Kgu4d2j8=; b=XGJEBzdW+PMrRH6RuAizH10hSSJ/VgcYx80rWP6yzYxkq+Ubj7rehYw/UuiLb6juZm Us81dzXOZJe12b13ypeb92Apf/wHh5kDcwTblrn7eFr+8+7Hq/zFhP0vfJ4MmqJxkqYt 7C5zS7GEaRCZqL7N0rizCLv5sPd4BYprG9MmXtJZoQS4xDJpWcPUnyuLvIQ5ymGcsCBa KAOTwhRIPPxgMua2GVte4SoPFq76IsCFQ8ESeUr/vGpJA/xlpcPLW169ZXZKit3fcjYK X6eYEaujDDTu7GdS9kWJTvXxrzb6ZGyeoUA45TQxMhiQgiKeD6AmGXHsjFoQXYkBE7ZH MK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616544; x=1773221344; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DW5EUg1yaoYe86hPewYMQORzz9/C/R4GlG4Kgu4d2j8=; b=YeIcQCFXrG+zzVKJ+Ei5FRr8IdXYzDYyi7KBBWB5+UC5SxiWagfuka09HbGOG7gkd1 2OdJOUJ74iZP7alPr2CzrHh46XobDk6Ob6x/43ZAd3zOsEU0OHse6R92yfB1YehGt5Jp BSXl1LuXrLDDE5jniN/Q/+j/62Gg8EF2zJErKSz/yDXQg2KQSPoYlaF7Bn8tXX5E+hNU InZ0hoEERclBXSCdV2xLCSLekM0BDEC2J2WKWvDXJBe22WSZlPRGsEgZdzOSCIXOfRXe SsXLvrJH6C2LKKbm9g7OOJkTROWTkawvY+Twv7YDnWY9TQyOnaDsmtUVXMafeX08jOFw +kJg== X-Forwarded-Encrypted: i=1; AJvYcCU2EX635fzGlC2kvDFuN/5pc5cwlr8ILrVMPe2kSLkOOsGju2EoUuw/gTvPOrnT4TSwyFOP2v1JMdHSN8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+SB1iLKo6RkhVoT9zPiCeS1t/bevtZbsMuyhUZfywfQ1oI0PH miGEtGQoRLrO/yH7dC4TodQeCfKPAuwFqQSy7zYhI30GXKfZbxzF3vO38COpl1oJRTzie38YuYI aJu4xT4ZDfSOWGzvcihsLnpl3aEbou90YICy7UEDszFpc7VWsx8r3CAK/Wp8W/Th65Nk= X-Gm-Gg: ATEYQzz2o58u/8W9RHJaYHI+UMArJOZWFN0LBGE7d8n3/yBGxg2/CAs0ULRmvjS6TMy Xbolmud0VZIn0+J6s10PVetqrxGgLcaHVe9ZB/e1DPG76n+PpwsD9jq1fNcKpV9cb2lBJDZ2Eos xavkuUvau9SzupoWhd/hONE75cbTwijL6NchyfR5kZ0SlOzZznfSZilJDZl0eQTEY+E/RPonYz8 e4GEdzMd0b3gBoff4s/Du9G/9mK9HrJ7lpDm2Vu5EReXnFXT6k2As7Qr3mmd0uLwizxcqUUrS+P ExCtJzCEc6I9zgCFsd6nRO5Ru73y9hDu9X/+LcXQ5D+Yy4uW1AjF85HSdydmghVozJnc6yofx3o YXpWaiLWmKf2xFat3e7b5NQgfeqpBcNRPBamfgEA4Mjol5eBmmT3/Og+ek0udkEQynkTGx4kQiO x7kBzOyknseuWwK2bj23K0WTyJuzcSR33j8zZfCcjg9JIJOS861po6dr6RWvEeb8rS4+J8ox6NX CF0gcPUTjrvV2Rx X-Received: by 2002:a05:620a:470c:b0:85e:b7b6:81e2 with SMTP id af79cd13be357-8cd5af818c4mr135783485a.50.1772616544415; Wed, 04 Mar 2026 01:29:04 -0800 (PST) X-Received: by 2002:a05:620a:470c:b0:85e:b7b6:81e2 with SMTP id af79cd13be357-8cd5af818c4mr135781385a.50.1772616543833; Wed, 04 Mar 2026 01:29:03 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ab123e8sm713717466b.4.2026.03.04.01.29.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 01:29:03 -0800 (PST) Message-ID: <0f2502fb-20cd-4638-8428-9a9eb5318147@oss.qualcomm.com> Date: Wed, 4 Mar 2026 10:29:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v2 1/2] platform/x86: int3472: Add board data for Intel nvl To: Sakari Ailus , Arun T Cc: mehdi.djait@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260130092431.2335363-2-arun.t@intel.com> <20260227133542.970820-1-arun.t@intel.com> <20260227133542.970820-2-arun.t@intel.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Svrv5JZLzWmuY19Qnt8TKcEKMeXySH7J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA3MSBTYWx0ZWRfX3qs1z3tcQ9WN Q6ryX8yRmzLEIhgk2eyzlSneNNasrDpiaBlYg3XFonmXiEtEnbxdnwYw+LugmGhn/Scbw+KlWXM DolB3S9jVPASi+MN2Y56aee0xsUc7ab3vUcpd8gawQYKQAwMBnFn9r6jesB93KoecU8YyLcOmKK v7h1Bd5Adfu4m05WHE/6yCB5Rtyd0QosIUFja09ap1Tik9442Z+9lq+K9o+ipMedRUtezUqJ0Ru nhUfQh51xYR9gQY/G3oxfAj5jbzl+xqelRBp2aXMHvkDZ5RH9UefXaVkLGJXkMHyZhKG2yTmoPR Jfbm8pVdCD3iXK0laimDyF6VbjD4duL6hyWrROXixzJwN1yKKJrDnLGvEBE0ygHrYPg37M7AXZT kmlosM+ucdLjvVf0srrZdv9sZ8cNnmUIFVuOcn4MU0rZz5KMFtMKhfZb64DG+2tgPDt5GhK/S9i rrrvYpHq+941z6Txwkg== X-Proofpoint-ORIG-GUID: Svrv5JZLzWmuY19Qnt8TKcEKMeXySH7J X-Authority-Analysis: v=2.4 cv=BpWQAIX5 c=1 sm=1 tr=0 ts=69a7fb61 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=QyXUC8HyAAAA:8 a=htL7Jlt0GR6tHhuy9c8A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_04,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040071 Hi, On 1-Mar-26 15:37, Sakari Ailus wrote: > Hi Arun, > > Thanks for the update. Please avoid using --in-reply-to argument for git > send-email when sending a new version of the patchset on the next time. > > Could you cc me to my @linux.intel.com address on the next time? > > Also cc other maintainers, see what > > $ scripts/get_maintainer.pl drivers/platform/x86/intel/int3472/ > > prints. > > On Fri, Feb 27, 2026 at 07:05:41PM +0530, Arun T wrote: >> The Intel Nvl O13b10 sensor with the Intel IPU8 ISP. >> The sensor is powered by a TPS68470 PMIC, and so we >> need some board data to describe how to configure the GPIOs and >> regulators to run the sensor. > > This can be rewrapped and fits to three lines; also see > Documentation/process/submitting-patches.rst . Most editors can do that > without too much manual work. > >> >> Signed-off-by: Arun T >> --- >> .../x86/intel/int3472/tps68470_board_data.c | 150 ++++++++++++++++++ >> 1 file changed, 150 insertions(+) >> >> diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> index 71357a036292..71dc0940a94b 100644 >> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> @@ -143,6 +143,34 @@ static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { >> REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), >> }; >> >> +/* Settings for Intel NVL platform */ >> + >> +static struct regulator_consumer_supply int3472_core_consumer_supplies[] = { >> + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3472_ana_consumer_supplies[] = { >> + REGULATOR_SUPPLY("ana", "i2c-OVTI13B1:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3472_vcm_consumer_supplies[] = { >> + REGULATOR_SUPPLY("vdd", "i2c-OVTI13B1:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3472_vsio_consumer_supplies[] = { >> + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:00"), >> + REGULATOR_SUPPLY("vsio", "i2c-OVTI13B1:00"), >> + REGULATOR_SUPPLY("vddd", "i2c-OVTI13B1:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3472_aux1_consumer_supplies[] = { >> + REGULATOR_SUPPLY("vdda", "i2c-OVTI13B1:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3472_aux2_consumer_supplies[] = { >> + REGULATOR_SUPPLY("vdddo", "i2c-OVTI13B1:00"), >> +}; > > That's a lot of regulators. The sensor driver appears to use only three, > even after the second patch. Also the names still do not match up with the sensor driver, the sensor driver (after patch 2/2) has: "dovdd", /* Digital I/O power */ "avdd", /* Analog power */ "dvdd", /* Digital core power */ Where as above there is no "avdd" only "vdda" and "ana" which are both candidates to actually be "avdd" I guess you want to change the "ana" one but please double check. Note all other regulator_consumer_supply maps except for the 3 actually used by the sensor-driver are *wrong* and should be dropped. Even if there is a VCM, then the second part of the mapping to "i2c-OVTI13B1:00" is wrong. The "i2c-OVTI13B1:00" consumer will only consume "dovdd", "avdd" and "dvdd" supplies so for that consumer there should only be those 3 maps. Regards, Hans > > Is there a VCM there, for instance? > >> + >> static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { >> .constraints = { >> .min_uV = 1200000, >> @@ -220,6 +248,82 @@ static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = >> .consumer_supplies = int3479_aux2_consumer_supplies, >> }; >> >> +static const struct regulator_init_data intel_nvl_tps68470_core_reg_init_data = { >> + .constraints = { >> + .min_uV = 1200000, >> + .max_uV = 1200000, >> + .apply_uV = true, >> + .always_on = true, > > Setting always_on to true shouldn't be necessary here. > >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_core_consumer_supplies), >> + .consumer_supplies = int3472_core_consumer_supplies, >> +}; >> + >> +static const struct regulator_init_data intel_nvl_tps68470_ana_reg_init_data = { >> + .constraints = { >> + .min_uV = 2815200, >> + .max_uV = 2815200, >> + .apply_uV = true, >> + .always_on = true, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_ana_consumer_supplies), >> + .consumer_supplies = int3472_ana_consumer_supplies, >> +}; >> +static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = { >> + .constraints = { >> + .min_uV = 2815200, >> + .max_uV = 2815200, >> + .apply_uV = true, >> + .always_on = true, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_vcm_consumer_supplies), >> + .consumer_supplies = int3472_vcm_consumer_supplies, >> +}; >> + >> +/* Ensure the always-on VIO regulator has the same voltage as VSIO */ >> +static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = true, >> + .always_on = true, >> + }, >> +}; >> + >> +static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = true, >> + .always_on = true, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_vsio_consumer_supplies), >> + .consumer_supplies = int3472_vsio_consumer_supplies, >> +}; >> + >> +static const struct regulator_init_data intel_nvl_tps68470_aux1_reg_init_data = { >> + .constraints = { >> + .min_uV = 2815200, >> + .max_uV = 2815200, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_aux1_consumer_supplies), >> + .consumer_supplies = int3472_aux1_consumer_supplies, >> +}; >> + >> +static const struct regulator_init_data intel_nvl_tps68470_aux2_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3472_aux2_consumer_supplies), >> + .consumer_supplies = int3472_aux2_consumer_supplies, >> +}; >> + >> + >> static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { >> .reg_init_data = { >> [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, >> @@ -232,6 +336,18 @@ static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = >> }, >> }; >> >> +static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata = { >> + .reg_init_data = { >> + [TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data, >> + [TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data, >> + [TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data, >> + [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data, >> + [TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data, >> + [TPS68470_AUX1] = &intel_nvl_tps68470_aux1_reg_init_data, >> + [TPS68470_AUX2] = &intel_nvl_tps68470_aux2_reg_init_data, >> + }, >> +}; >> + >> static struct gpiod_lookup_table surface_go_int347a_gpios = { >> .dev_id = "i2c-INT347A:00", >> .table = { >> @@ -258,6 +374,23 @@ static struct gpiod_lookup_table dell_7212_int3479_gpios = { >> } >> }; >> >> +static struct gpiod_lookup_table intel_nvl_int347a_gpios = { >> + .dev_id = "i2c-OVTI13B1:01", >> + .table = { >> + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), >> + GPIO_LOOKUP("tps68470-gpio", 8, "s_idle", GPIO_ACTIVE_LOW), >> + { } >> + } >> +}; >> + >> +static struct gpiod_lookup_table intel_nvl_int347e_gpios = { >> + .dev_id = "i2c-OVTI13B1:01", >> + .table = { >> + GPIO_LOOKUP("tps68470-gpio", 7, "s_enable", GPIO_ACTIVE_LOW), >> + { } >> + } >> +}; >> + >> static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { >> .dev_name = "i2c-INT3472:05", >> .tps68470_regulator_pdata = &surface_go_tps68470_pdata, >> @@ -287,6 +420,16 @@ static const struct int3472_tps68470_board_data dell_7212_tps68470_board_data = >> }, >> }; >> >> +static const struct int3472_tps68470_board_data intel_nvl_tps68470_board_data = { >> + .dev_name = "i2c-INT3472:04", >> + .tps68470_regulator_pdata = &intel_nvl_tps68470_pdata, >> + .n_gpiod_lookups = 2, >> + .tps68470_gpio_lookup_tables = { >> + &intel_nvl_int347a_gpios, >> + &intel_nvl_int347e_gpios, >> + }, >> +}; >> + >> static const struct dmi_system_id int3472_tps68470_board_data_table[] = { >> { >> .matches = { >> @@ -316,6 +459,13 @@ static const struct dmi_system_id int3472_tps68470_board_data_table[] = { >> }, >> .driver_data = (void *)&dell_7212_tps68470_board_data, >> }, >> + { >> + .matches = { >> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Nova Lake Client Platform"), >> + }, >> + .driver_data = (void *)&intel_nvl_tps68470_board_data, >> + }, >> { } >> }; >> >