mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: gomba007@gmail.com, Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
	csokas.bence@prolan.hu
Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: Add support for SD2405AL.
Date: Thu, 29 Aug 2024 07:55:32 +0200	[thread overview]
Message-ID: <0f328688-99e1-41c0-9300-c7ff847ebabc@kernel.org> (raw)
In-Reply-To: <20240828-rtc-sd2405al-v5-2-9e3f8fa5ea6b@gmail.com>

On 28/08/2024 10:22, Tóth János via B4 Relay wrote:
> From: Tóth János <gomba007@gmail.com>
> 
> Add the necessary documentation for SD2405AL.
> 
> Signed-off-by: Tóth János <gomba007@gmail.com>
> ---

The patch is trivial but I don't understand why opting out of automated
testing. People still make mistakes in for example white-spaces, so no
review from me, sorry.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof


  reply	other threads:[~2024-08-29  5:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  8:22 [PATCH v5 0/2] Add support for the DFRobot SD2405AL I2C RTC Module Tóth János via B4 Relay
2024-08-28  8:22 ` [PATCH v5 1/2] drivers: rtc: Add driver for SD2405AL Tóth János via B4 Relay
2024-08-28  8:22 ` [PATCH v5 2/2] dt-bindings: rtc: Add support " Tóth János via B4 Relay
2024-08-29  5:55   ` Krzysztof Kozlowski [this message]
2024-08-29 11:10     ` Tóth János

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f328688-99e1-41c0-9300-c7ff847ebabc@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=csokas.bence@prolan.hu \
    --cc=gomba007@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®