From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932963AbcIVJhk (ORCPT ); Thu, 22 Sep 2016 05:37:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756510AbcIVJhj (ORCPT ); Thu, 22 Sep 2016 05:37:39 -0400 Subject: Re: [PATCH] KVM: nVMX: Fix the NMI IDT-vectoring info handling To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1474515259-3197-1-git-send-email-wanpeng.li@hotmail.com> Cc: Wanpeng Li , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jan Kiszka , Bandan Das From: Paolo Bonzini Message-ID: <0f3504ad-a9a8-9716-ee0b-8f39ad15cba6@redhat.com> Date: Thu, 22 Sep 2016 11:37:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474515259-3197-1-git-send-email-wanpeng.li@hotmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 22 Sep 2016 09:37:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2016 05:34, Wanpeng Li wrote: > - if (vmx->rmode.vm86_active) { > - if (kvm_inject_realmode_interrupt(vcpu, NMI_VECTOR, 0) != EMULATE_DONE) > - kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu); > - return; > + ++vcpu->stat.nmi_injections; > + vmx->nmi_known_unmasked = false; > + if (vmx->rmode.vm86_active) { > + if (kvm_inject_realmode_interrupt(vcpu, NMI_VECTOR, 0) != EMULATE_DONE) > + kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu); > + return; > + } > } > vmcs_write32(VM_ENTRY_INTR_INFO_FIELD, > INTR_TYPE_NMI_INTR | INTR_INFO_VALID_MASK | NMI_VECTOR); Hi, the patch is mostly okay but the "if (vmx->rmode.vm86_active)" part should be done also if the VCPU is in guest mode. See vmx_queue_exception for a similar example. I would like to know which processors lack virtual NMI support. I'd rather rip that code out... Thanks, Paolo