From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C284C7EE2F for ; Mon, 12 Jun 2023 14:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237532AbjFLOUx (ORCPT ); Mon, 12 Jun 2023 10:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237233AbjFLOTc (ORCPT ); Mon, 12 Jun 2023 10:19:32 -0400 Received: from out199-2.us.a.mail.aliyun.com (out199-2.us.a.mail.aliyun.com [47.90.199.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D674C00 for ; Mon, 12 Jun 2023 07:16:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R841e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vl-Q3HB_1686579340; Received: from 192.168.1.5(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vl-Q3HB_1686579340) by smtp.aliyun-inc.com; Mon, 12 Jun 2023 22:15:41 +0800 Message-ID: <0f371bd6-9db9-758a-8495-a1a2b10381f3@linux.alibaba.com> Date: Mon, 12 Jun 2023 22:15:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v7 1/5] erofs: use absolute position in xattr iterator To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230612123745.36323-1-jefflexu@linux.alibaba.com> <20230612123745.36323-2-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230612123745.36323-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/12 20:37, Jingbo Xu wrote: > Replace blkaddr/ofs with pos in 'struct erofs_xattr_iter'. > > After erofs_bread() is introduced to replace raw page cache APIs for > metadata I/Os handling, xattr_iter_fixup() is no longer needed anymore. > > In addition, it is also unnecessary to check if the iterated position is > span over the block boundary as absolute offset is used instead of > blkaddr + offset pairs. > > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang