From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: <mingo@kernel.org>, <tglx@linutronix.de>, <fweisbec@gmail.com>
Cc: <srinivas.eeda@oracle.com>, <joe.jin@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2] tick/broadcast: Remove redundant code in tick_check_new_device()
Date: Tue, 14 Nov 2017 06:36:30 -0800 (PST) [thread overview]
Message-ID: <0f379758-282c-40de-a71e-d09fe768d2b5@default> (raw)
There is no way a timer used as broadcast clockevent device is also used as
percpu tick clockevent device currently.
-v2: remove meaningless description suggested by tglx
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
kernel/time/tick-common.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 49edc1c..9bcc866 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev)
/*
* Replace the eventually existing device by the new
- * device. If the current device is the broadcast device, do
- * not give it back to the clockevents layer !
+ * device.
*/
- if (tick_is_broadcast_device(curdev)) {
- clockevents_shutdown(curdev);
- curdev = NULL;
- }
clockevents_exchange_device(curdev, newdev);
tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
--
1.7.3
next reply other threads:[~2017-11-14 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 14:36 Zhenzhong Duan [this message]
2018-01-05 1:28 Zhenzhong Duan
2018-12-04 9:21 Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f379758-282c-40de-a71e-d09fe768d2b5@default \
--to=zhenzhong.duan@oracle.com \
--cc=fweisbec@gmail.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®