From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751814AbdHRTT3 (ORCPT ); Fri, 18 Aug 2017 15:19:29 -0400 Received: from vern.gendns.com ([206.190.152.46]:35035 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbdHRTT2 (ORCPT ); Fri, 18 Aug 2017 15:19:28 -0400 Subject: Re: [PATCH v3] fbcon: add fbcon=margin: command line option To: Geert Uytterhoeven Cc: Linux Fbdev development list , Bartlomiej Zolnierkiewicz , "linux-kernel@vger.kernel.org" References: <1501605357-30815-1-git-send-email-david@lechnology.com> From: David Lechner Message-ID: <0f404f59-f494-bd33-9a9a-f9b07a0dd7ee@lechnology.com> Date: Fri, 18 Aug 2017 14:19:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2017 01:21 PM, Geert Uytterhoeven wrote: > Hi David, > > On Tue, Aug 1, 2017 at 6:35 PM, David Lechner wrote: >> This adds a new command line option to select the fbcon margin color. >> >> The motivation for this is screens where black does not blend into the >> physical surroundings of the screen. For example, using an LCD (not the >> backlit kind), white text on a black background is hard to read, so >> inverting the colors is preferred. However, when you do this, most of the >> screen is filled with white but the margins are still filled with black. >> This makes a big, black, backwards 'L' on the screen. By setting >> fbcon=margin:7, the margins will be filled with white and the LCD looks as >> expected. >> >> Signed-off-by: David Lechner > >> --- a/Documentation/fb/fbcon.txt >> +++ b/Documentation/fb/fbcon.txt >> @@ -148,6 +148,13 @@ C. Boot options >> Actually, the underlying fb driver is totally ignorant of console >> rotation. >> >> +5. fbcon=margin: >> + >> + This option specifies the color of the margins. The margins are the >> + leftover area at the right and the bottom of the screen that are not >> + used by text. By default, this area will be black. The 'color' value >> + is 0 to 7 where 0 is black and 7 is white. >> + > > Given the standard console palette contains 16 colors, why limit this to > the first 8 colors, and not 0 to 15? Good question. I think in some of my previous attempts there was a 0x7 mask involved somewhere and this is a carryover from that. But, after having looked at this again, I don't see a reason for limiting to 7.