From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B904C25B06 for ; Sun, 14 Aug 2022 17:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239830AbiHNR5C (ORCPT ); Sun, 14 Aug 2022 13:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiHNR5A (ORCPT ); Sun, 14 Aug 2022 13:57:00 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D0022518; Sun, 14 Aug 2022 10:56:59 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5DB11320046F; Sun, 14 Aug 2022 13:56:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 14 Aug 2022 13:56:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660499817; x= 1660586217; bh=+e13GbezqOI4ArqJrTYXTju73ASowLwd6TUNF4QfnPQ=; b=B PkH8n1qtJvm7VBJNwGkObUaA3PFcMM77RrZ6op6aSV9KOPeqJC+Sb21geMOM2Boc K2Dl0bTkg9V/UcugvwnVvEUna+DZZIqZwJ/BYlw5zBHciLkVTp6mzmcJrkLRThSW eZmGPLO5FhU8gNSf0kzZruQR0wxQpo/MEoxSo9JnXkTlCBDAsNngCz/q7uatpsg3 frwPBrU6dmJ4aBNggKdqnYZQ8DZvkiGh0JJWKvLqVSRek9RGygPGmLRbaMcnWM7J aVV1rZAORqO9IK1fgSBMF1Ftfu8YsPCyJLp6728AvtlCvfg5p+4R12ldHUpX3bMf +H9qImtd7ZvnZNXlNfFkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660499817; x= 1660586217; bh=+e13GbezqOI4ArqJrTYXTju73ASowLwd6TUNF4QfnPQ=; b=l zNvG/n0ryQT6vV6bSKCVKUem94QzKI42QIDJP2oprfcWgKtncyFIsgh7giDPZ3fR x9A7P43CzW+PuFTMi5Bj8pZDefIe1/jh4Mriax3Y7fptDSgOYICaguovNKVzxovg aEd6nH1gFC+kDQjOufxnhgYkcSWaR0g7pXWEazevuAtcs8TuEwuN17hu0ulg0bKy X5rcmGWe9dauHT+yPNclsFMVd85+mjwCgdv0XOSjeQb1255njOa2N2s7AEIIonF6 5WwB+ir/4jZ+OVTTuGgW4mZFko/BmagNaiEEb/o+6s4uVUxwUbrtrgPVuis+wGfD lzhb+VLOY1GE/CTY5BX7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehtddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfevfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgr mhhuvghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqne cuggftrfgrthhtvghrnheptdevhfehhefgvdekteffleduueduheduuedvtdevleelkeev vdeuvdeihfekueehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 14 Aug 2022 13:56:57 -0400 (EDT) Subject: Re: [PATCH] mmc: sunxi-mmc: Fix clock refcount imbalance during unbind To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , Chen-Yu Tsai , Ulf Hansson , Wolfram Sang Cc: Andre Przywara , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220810022509.43743-1-samuel@sholland.org> <21565294.EfDdHjke4D@jernej-laptop> From: Samuel Holland Message-ID: <0f40b1cf-1f5d-41b6-04bb-0566f18cd91e@sholland.org> Date: Sun, 14 Aug 2022 12:56:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <21565294.EfDdHjke4D@jernej-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/14/22 3:22 AM, Jernej Škrabec wrote: > Dne sreda, 10. avgust 2022 ob 04:25:09 CEST je Samuel Holland napisal(a): >> If the controller is suspended by runtime PM, the clock is already >> disabled, so do not try to disable it again during removal. Use >> pm_runtime_disable() to flush any pending runtime PM transitions. >> >> Fixes: 9a8e1e8cc2c0 ("mmc: sunxi: Add runtime_pm support") >> Signed-off-by: Samuel Holland > > Did you get any warnings for unbalanced disable calls? Yes, I got warnings while I was doing unbind/bind cycles to force the SDIO WiFi driver to reload. Regards, Samuel > Anyway: > Acked-by: Jernej Skrabec > > Best regards, > Jernej > >