From: Steve Longerbeam <steve_longerbeam@mentor.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Steve Longerbeam <slongerbeam@gmail.com>, <lars@metafoo.de>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v2 01/10] v4l: of: add "newavmode" property for Analog Devices codecs
Date: Wed, 20 Jul 2016 10:14:14 -0700 [thread overview]
Message-ID: <0f49b30a-62ca-7a72-e12e-1c81cc3ca691@mentor.com> (raw)
In-Reply-To: <1d7e9b86-a4c9-8223-d8bd-8f4b9effcce8@xs4all.nl>
On 07/20/2016 12:37 AM, Hans Verkuil wrote:
> On 07/20/2016 02:03 AM, Steve Longerbeam wrote:
>> This patch adds a "newavmode" boolean property as part of the v4l2 endpoint
>> properties. This indicates an Analog Devices decoder is generating EAV/SAV
>> codes to suit Analog Devices encoders.
>>
>> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
>> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
>> ---
>> Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++
>> drivers/media/v4l2-core/v4l2-of.c | 4 ++++
>> include/media/v4l2-mediabus.h | 5 +++++
>> 3 files changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
>> index 9cd2a36..6f2df51 100644
>> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
>> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
>> @@ -88,6 +88,8 @@ Optional endpoint properties
>> - field-even-active: field signal level during the even field data transmission.
>> - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
>> signal.
>> +- newavmode: a boolean property to indicate an Analog Devices decoder is
>> + operating in NEWAVMODE. Valid for BT.656 busses only.
> This property is adv7180 specific and does not belong here.
Hi Hans, yes that was my initial reaction to this idea as well, but
you didn't respond to my first request for comment.
>
> Add this to Documentation/devicetree/bindings/media/i2c/adv7180.txt instead.
Yes, I'll move this property into adv7180.
Steve
next prev parent reply other threads:[~2016-07-20 17:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467846004-12731-1-git-send-email-steve_longerbeam@mentor.com>
2016-07-20 0:03 ` [PATCH v2 00/10] adv7180 subdev fixes, v2 Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 01/10] v4l: of: add "newavmode" property for Analog Devices codecs Steve Longerbeam
2016-07-20 7:37 ` Hans Verkuil
2016-07-20 17:14 ` Steve Longerbeam [this message]
2016-07-20 0:03 ` [PATCH v2 02/10] media: adv7180: Fix broken interrupt register access Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 03/10] media: adv7180: define more registers Steve Longerbeam
2016-07-20 8:54 ` Lars-Peter Clausen
2016-07-20 0:03 ` [PATCH v2 04/10] media: adv7180: add support for NEWAVMODE Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 05/10] media: adv7180: add power pin control Steve Longerbeam
2016-07-20 8:53 ` Lars-Peter Clausen
2016-07-20 0:03 ` [PATCH v2 06/10] media: adv7180: implement g_parm Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 07/10] media: adv7180: change mbus format to UYVY Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 08/10] v4l: Add signal lock status to source change events Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 09/10] media: adv7180: enable lock/unlock interrupts Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 10/10] media: adv7180: fix field type Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f49b30a-62ca-7a72-e12e-1c81cc3ca691@mentor.com \
--to=steve_longerbeam@mentor.com \
--cc=hverkuil@xs4all.nl \
--cc=javier@osg.samsung.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®